> if (mutex_lock_interruptible(>lock))
> return -ERESTARTSYS;
I'm suspect returning -ERESTARTSYS is a bug.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ble. It's useful on by
itself. I always put the person who wrote the original patch in the To:
header so they can review and comment if I have made a mistake.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the exynos_drm_gem_init() function. Also the
exynos_drm_gem_init() has no documentation about how it is supposed to
be freed.
611 return ERR_PTR(ret);
612 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
) + (u64)pmcnt_low;
Fixes: 3d87b02281a2 ('PM / devfreq: exynos-ppmu: Add the support of PPMUv2 for
Exynos5433')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/devfreq/event/exynos-ppmu.c
b/drivers/devfreq/event/exynos-ppmu.c
index f9901f5..daf2cdb 100644
--- a/drivers
| PPMU_PMCNT0_MASK | PPMU_PMCNT1_MASK
+ | PPMU_PMCNT2_MASK | PPMU_PMCNT3_MASK);
+
+ __raw_writel(clear, info-ppmu.base + PPMUv2_FLAG);
Why aren't you using normal readl()/writel()? What are the endiannesses
here?
regards,
dan carpenter
--
To unsubscribe from this list: send
On Fri, Jun 26, 2015 at 12:20:35PM +0200, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Friday, June 26, 2015 07:03:25 PM Krzysztof Kozlowski wrote:
2015-06-26 18:54 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Hello Thomas Abraham,
The patch ddeac8d968d4: clk: samsung: add
div1 = cfg_data-div1;
166 if (readl(base + E4210_SRC_CPU) E4210_MUX_HPM_MASK)
167 div1 = readl(base + E4210_DIV_CPU1)
168 (E4210_DIV1_HPM_MASK |
E4210_DIV1_COPY_MASK);
169 }
regards,
dan
built-in.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos5440.c
b/drivers/pinctrl/samsung/pinctrl-exynos5440.c
index fa84db6..5574b8a 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos5440.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos5440.c
We were allocating enough space because sizeof(-grp) and
sizeof(-mux) are both equal to 5 but in the snprintf() we only allowed
for 4 characters so the last 'p' and 'x' characters were truncated.
The allocate and sprintf can be done in one step with the kasprintf().
Signed-off-by: Dan Carpenter
issue I think that function suffix would also be
truncated in the same way.
Sorry for the delayed response, I've been offline for a few days.
Yeah, you're right.
Let me resend.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body
checkpatch.pl these days complains
that the allocation failed printks aren't needed so I removed them.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos5440.c
b/drivers/pinctrl/samsung/pinctrl-exynos5440.c
index f5619fb..f804a61c 100644
There is a typo here so we test edev but we intended to test
edev[i].
Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/devfreq/event/exynos-ppmu.c
b/drivers/devfreq/event/exynos-ppmu.c
index 135be0a
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
We recently changed this function to return a pointer instead of an int
so we need to change this zero to a NULL or Sparse complains:
drivers/gpu/drm/exynos/exynos_drm_drv.h:346:47:
warning: Using plain integer as NULL pointer
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
return 0. That
will cause a Sparse warning.
2) Also there are still a number of checks for if (ctx-display).
Those things are weird to me, are those checks to see
CONFIG_DRM_EXYNOS_DPI is enabled or are they checking that
exynos_dpi_probe() succeeded?
regards,
dan carpenter
--
To unsubscribe from
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Whatever happened with this btw? Also are you sure we don't need a
second check after line 457?
regards,
dan carpenter
On Tue, Aug 27, 2013 at 04:26:07PM +0200, Sylwester Nawrocki wrote:
On 08/27/2013 04:19 PM, Dan Carpenter wrote:
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki
My guess is we aren't going to have a 2 digit cpuid here any time soon
but the static checkers don't know that and complain that the snprintf()
could overflow.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
(file-driver_priv);
200 file-driver_priv = NULL;
201 }
The function is different in the current code. I glanced through
drm_open_helper() and I don't see that file-driver_priv to NULL is
needed anyway...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe
should actually be (0xf 28).
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
b/drivers/media/platform/exynos4-is/mipi-csis.c
index 9fc2af6..31dfc50 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki wrote:
On 08/23/2013 11:46 AM, Dan Carpenter wrote:
[ Going through some old warnings... ]
Hello Sylwester Nawrocki,
This is a semi-automatic email about new static checker warnings.
The patch babde1c243b2: [media] V4L: Add
If irq == NUM_EINT then it writes one space beyond the end of the
eint_data-domains[] array.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/pinctrl-s3c24xx.c
b/drivers/pinctrl/pinctrl-s3c24xx.c
index 24446da..ad3eaad 100644
--- a/drivers/pinctrl/pinctrl
offset = S5PCSIS_PKTDATA_EVEN;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
There is a stray '!' character so the error message never gets printed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. Not tested.
diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c
b/drivers/media/platform/exynos4-is/fimc-is-regs.c
index 63c68ec
Because i is unsigned then i-- = 0 is always true. If we don't
find what we are looking for then we loop forever.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Why do we count backwards anyway? Counting upwards is easier.
diff --git a/drivers/media/platform/s3c-camif/camif-regs.c
;
^^
Dereference.
461 }
462
463 if (fmt == NULL)
^^^
Check.
464 return -EINVAL;
465 *num_planes = 1;
regards,
dan carpenter
this dereference.
1522 return -EINVAL;
1523 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 06, 2013 at 09:44:47AM +0100, Lars-Peter Clausen wrote:
On 03/06/2013 05:11 AM, Naveen Krishna Chatradhi wrote:
From: Naveen Krishna Ch ch.nav...@samsung.com
Fixes the compilation warnings and potential NULL pointer
dereferencing pointed out by Dan Carpenter.
I'd say
28 matches
Mail list logo
