Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-12 Thread David Miller
Please do not top-post. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] kbuild: remove unnecessary "obj- := dummy.o" trick

2014-09-09 Thread David Miller
From: Masahiro Yamada Date: Tue, 9 Sep 2014 19:26:19 +0900 > In these Makefiles, at least one of "obj-y" and "obj-" is non-empty, > hence built-in.o is always created without such a trick. > > Signed-off-by: Masahiro Yamada For networking: Acked-by: David S. Miller -- To unsubscribe from th

Re: [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support

2014-05-11 Thread David Miller
From: Byungho An Date: Fri, 09 May 2014 11:03:43 +0900 > This series added > - functions to update rx descriptor tail pointer > - non burst mode support > - fixed dma channel feature. This description is not sufficient. I don't understand what non fixed burst mode means, and why it is so crit

Re: [PATCH 1/3] net: sxgbe: Added condition for non fix_burst mode

2014-05-11 Thread David Miller
From: Byungho An Date: Fri, 09 May 2014 11:03:45 +0900 > - reg_val |= (pbl << SXGBE_DMA_TXPBL_LSHIFT); > + reg_val |= pbl << SXGBE_DMA_TXPBL_LSHIFT; This has nothing to do with the change you are making. -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH] net: sxgbe: Added condition for non fix_burst mode

2014-05-07 Thread David Miller
Please start numbering your patches and submit patch sets properly. You need to provide: 1) A header posting with subject "[PATCH 0/${N}] blah blah blah" that describes at a high level what the patch series does. 2) The patches, in the correct order, numbered in the subject line in the fo

Re: [PATCH] net: sxgbe: Added set function for interrupt on complete

2014-04-30 Thread David Miller
From: Byungho An Date: Tue, 29 Apr 2014 13:15:27 +0900 > > This patch adds set_rx_int_on_com function for interrupt when > dma is completed. > > Signed-off-by: Byungho An Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to major

Re: [PATCH] net: sxgbe: Added rxqueue enable function

2014-04-30 Thread David Miller
From: Byungho An Date: Tue, 29 Apr 2014 13:15:17 +0900 > > This patch adds rxqueue enable function according to number of rxqueue > and adds rxqueue disable function for removing. > > Signed-off-by: Byungho An Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung

Re: [PATCH] net: sxgbe: sw reset moved to probe function

2014-04-30 Thread David Miller
From: Byungho An Date: Tue, 29 Apr 2014 13:15:15 +0900 > > This patch moves sw reset to probe function because > sw reset is needed early stage before open function. > > Signed-off-by: Byungho An Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the b

Re: [PATCH] net: sxgbe: Added phy_found error path

2014-04-22 Thread David Miller
From: Byungho An Date: Fri, 18 Apr 2014 20:59:39 +0900 > This patch adds phy_found error path when there is no phy device > and changes bus_name. > > Signed-off-by: Byungho An Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a mes

Re: [PATCH] net: sxgbe: rearrange dma descriptor

2014-04-22 Thread David Miller
From: Byungho An Date: Fri, 18 Apr 2014 20:59:36 +0900 > This patch moves cksum_ctl to tx_rd_des23 from cksum_pktlen for correct > checksum > offloading and modifies size for Tx/Rx descriptor. > > Signed-off-by: Byungho An Applied, thanks. -- To unsubscribe from this list: send the line "uns

Re: [PATCH net-next] net: sxgbe: fix sparse warnings about static declaration

2014-03-28 Thread David Miller
From: Byungho An Date: Fri, 28 Mar 2014 10:57:36 -0700 > From: Byungho An > > This fixes followings: > > sparse warnings: (new ones prefixed by >>) > >>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:197:5: > sparse: symbol 'sxgbe_platform_freeze' was not declared. Should it be static?

Re: [PATCH net-next] net: sxgbe: fix potential null dereference

2014-03-28 Thread David Miller
From: Byungho An Date: Fri, 28 Mar 2014 10:57:44 -0700 > From: Byungho An > > This fixes following: > > drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1828 sxgbe_hw_init() > error: potential null dereference 'priv->hw'. (kmalloc returns null) > > Reported-by: kbuild test robot > Signed-off

Re: [PATCH V14 0/7] add new Samsung SXGBE driver

2014-03-26 Thread David Miller
From: Byungho An Date: Tue, 25 Mar 2014 12:10:47 -0700 > This is 14th posting for SAMSUNG SXGBE driver. Series applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH V8 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-20 Thread David Miller
From: Byungho An Date: Thu, 20 Mar 2014 10:25:59 -0700 > +config NET_VENDOR_SAMSUNG > + bool "Samsung Ethernet device" > + default y > + depends on HAS_IOMEM && HAS_DMA > + select PHYLIB > + select CRC32 > + select PTP_1588_CLOCK > + ---help--- > + This is the dr

Re: [PATCH V3 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-17 Thread David Miller
From: Byungho An Date: Mon, 17 Mar 2014 13:43:37 -0700 > +static void sxgbe_tx_timer(unsigned long data) > +{ > + struct sxgbe_tx_queue *p = (struct sxgbe_tx_queue *)data; > + sxgbe_tx_queue_clean(p); > +} A empty line after local variable declarations please. > + SXGBE_FOR_EACH_QUE

Re: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver

2014-03-13 Thread David Miller
From: Byungho An Date: Thu, 13 Mar 2014 15:55:28 +0900 > This is 2nd posting for Samsung SXGbE driver and just re-sending because of > line wrapping in previous posting. > > Changes since v1: > - changed name of driver to SXGbE as per Ben's comment > - squashed Joe's neatening for many stuff in

Re: [PATCH 1/1] drivers: net: silence compiler warning in smc91x.c

2014-01-13 Thread David Miller
From: Sergei Shtylyov Date: Fri, 10 Jan 2014 23:42:41 +0300 > Hello. > > On 01/10/2014 06:04 AM, Pankaj Dubey wrote: > >> If used 64 bit compiler GCC warns that: > >> drivers/net/ethernet/smsc/smc91x.c:1897:7: >> warning: cast from pointer to integer of different >> size [-Wpointer-to-int-cast

Re: [RFC 9/9] crypto: Add Samsung crypto engine driver

2010-08-13 Thread David Miller
From: Maurus Cuelenaere Date: Fri, 13 Aug 2010 13:17:53 +0200 > Op 13-08-10 00:32, David Miller schreef: >> From: Maurus Cuelenaere >> Date: Thu, 12 Aug 2010 13:47:24 +0200 >> >> tcrypt can validate async crypto algorithms, but cannot performance >> test them

Re: [RFC 9/9] crypto: Add Samsung crypto engine driver

2010-08-12 Thread David Miller
From: Maurus Cuelenaere Date: Thu, 12 Aug 2010 13:47:24 +0200 > The main issues still remain (DMA not working at all and FIFO not > working for some (T)DES transfers). Additionally, I couldn't get > tcrypt to test the s3c-sss driver for some reason, it always picked > the standard AES/TDES/DES dr

Re: [RFC 9/9] crypto: Add Samsung crypto engine driver

2010-06-27 Thread David Miller
From: Maurus Cuelenaere Date: Sun, 27 Jun 2010 13:06:03 +0200 > I'd go with a threaded interrupt handler in that case then, or do > you also consider this as too much overhead? > > I'll do some performance comparisons of threaded interrupt handler > vs normal and go with the fastest. Yes, best

Re: [RFC 9/9] crypto: Add Samsung crypto engine driver

2010-06-26 Thread David Miller
From: Maurus Cuelenaere Date: Fri, 11 Jun 2010 21:49:21 +0200 > This patch adds support for the Samsung crypto engine driver available in the > S3C64XX and S5PC100 SoCs. Currently this supports AES and (T)DES with ECB and > CBC block ciphers (also CTR for AES). Support for (HMAC)-SHA1 acceleratio