Re: [PATCH V4] drm/exynos: Add DECON driver

2015-02-11 Thread Inki Dae
, Inki Dae On 2015년 02월 11일 19:43, Ajay kumar wrote: > ping. > > On Thu, Feb 5, 2015 at 9:24 PM, Ajay Kumar wrote: >> This patch is based on exynos-drm-next branch of Inki Dae's tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git >>

Re: [PATCH -v2 10/14] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

2015-02-09 Thread Inki Dae
On 2015년 02월 10일 02:07, Gustavo Padovan wrote: > 2015-02-09 Daniel Stone : > >> Hi Inki, >> >> On 9 February 2015 at 14:53, Inki Dae wrote: >>> I'm merging this patch series but I found two issues. One is already >>> pointed out. >> >> F

Re: [PATCH -v2 10/14] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

2015-02-09 Thread Inki Dae
ice_release_driver+0x70/0xc4) [ 230.987615] [] (__device_release_driver) from [] (device_release_driver+0x1c/0x28) [ 230.996904] [] (device_release_driver) from [] (unbind_store+0x78/0xf8) [ 231.005240] [] (unbind_store) from [] (kernfs_fop_write+0xb8/0x19c) [ 231.013223] [] (kernfs_fop_wr

Re: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

2015-02-09 Thread Inki Dae
On 2015년 02월 09일 19:57, Sylwester Nawrocki wrote: > On 07/02/15 12:53, Inki Dae wrote: >> This patch fixes the issue that the try to get a phy object is failed >> to enable mipi phy. >> >> System and power management unit registers should be controlled by >> syscon

[PATCH 3/4] ARM: dts: exynos3250: use pmureg device node to enable mipi phy

2015-02-07 Thread Inki Dae
This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos3250.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 4/4] ARM: dts: exynos5420: use pmureg device node to enable mipi phy

2015-02-07 Thread Inki Dae
This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos5420.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

2015-02-07 Thread Inki Dae
}; ... }; With above, we will find below message while booting, can't request region for resource [mem 0x10020710-0x10020717] Signed-off-by: Inki Dae --- .../devicetree/bindings/video/exynos_dsim.txt |9 ++-- drivers/gpu/drm/exynos/exyno

[PATCH 2/4] ARM: dts: exynos4: use pmureg device node to enable mipi phy

2015-02-07 Thread Inki Dae
This patch removes mipi phy relevant properties from dsim device node and makes the pmureg device node to be used instead to enable mipi phy. Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos4.dtsi |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 0/4] drm/exynos: use syscon framework to enable mipi phy

2015-02-07 Thread Inki Dae
This patch series makes syscon framework to be used instead of phy framework. For this, I adds syscon support to mipi dsi driver and the relevant device tree properties to each dtsi files, Exynos4, Exynos3250 and Exynos5420. Inki Dae (4): drm/exynos: dsim: fix to control mipi phy register

[PATCH] ARM: dts: exynos4412-trats2: set display clock correctly

2015-02-07 Thread Inki Dae
24x768 [1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes") Signed-off-by: Inki Dae --- arch/arm/boot/dts/exynos4412-trats2.dts |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/e

Re: [PATCH v2 1/2] drm/exynos: fix DMA_ATTR_NO_KERNEL_MAPPING usage

2015-02-04 Thread Inki Dae
DMA_ATTR_NO_KERNEL_MAPPING > but we need to fix it before fixing the DMA layer. Applied. Thanks, Inki Dae > > Signed-off-by: Carlo Caione > Acked-by: Joonyoung Shim > --- > drivers/gpu/drm/exynos/exynos_drm_buf.c | 6 +++--- > drivers/gpu/drm/exynos/exynos_drm_fbde

Re: [PATCH] exynos/drm: fix no hdmi output

2015-02-04 Thread Inki Dae
ing get hdmi to ouput proper pixels: > ie call mixer_initialize first then exynos_drm_crtc_create. Applied. Please use prefix of subject correctly, drm/exynos because your patch is filtered in my mail box. Thanks, Inki Dae > > Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_man

Re: [PATCH] drm/exynos: hdmi: replace fb size with mode size from win commit

2015-02-04 Thread Inki Dae
ode size for display size from > the mixer_win_commit(). Applied. Thanks, Inki Dae > > Signed-off-by: Seung-Woo Kim > --- > drivers/gpu/drm/exynos/exynos_mixer.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos

Re: [PATCH] drm/exynos: IOMMU support should not be selectable by user

2015-02-03 Thread Inki Dae
driver. Applied. Thanks, Inki Dae > > Signed-off-by: Marek Szyprowski > --- > drivers/gpu/drm/exynos/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index 7f9f6f9e9b7e

Re: [PATCH v5 9/9] drm/exynos: add support for 'hdmi' clock

2015-02-03 Thread Inki Dae
based boards. Picked it up. Thanks, Inki Dae. > > Suggested-by: Andrzej Hajda > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Signed-off-by: Marek Szyprowski > --- > Documentation/devicetree/bindings/video/exynos_mixer.txt | 1 + > d

Re: [PATCH 1/3] ARM: dts: add fimd device support for exynos3250-rinato

2015-01-12 Thread Inki Dae
On 2015년 01월 12일 18:12, Kukjin Kim wrote: > On 01/03/15 15:50, Inki Dae wrote: >> On 2014년 11월 28일 20:39, Inki Dae wrote: >>> This patch adds fimd device node which is a display controller >>> for Exynos3250 Rinato board. >> >> Hi Kukjin, >&g

Re: [PATCH 00/29] drm/exynos: clean up + atomic phases 1 and 2

2015-01-11 Thread Inki Dae
> changes. Merged only cleanup parts - 2 through 21 - to exynos-drm-next. I will have pull request within a week after testing. p.s. please keep that patch series has consistency of previous ones from next time. Thanks, Inki Dae > > Gustavo > > --- > The following ch

Re: [PULL] drm-exynos-next 2014-12-22

2015-01-07 Thread Inki Dae
On 2015년 01월 08일 03:06, Gustavo Padovan wrote: > 2014-12-26 Inki Dae : > >> On 2014년 12월 22일 22:04, Gustavo Padovan wrote: >>> Hi Dave, >>> >>> Here goes a bunch of clean up for the exynos driver. I've posted this work >>> in >>> t

[Resend][PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver

2015-01-05 Thread Inki Dae
Just resend it with Thierry's request. Thanks, Inki Dae Original Message Subject: [PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver Date: Tue, 09 Dec 2014 18:29:05 +0900 From: Hyungwon Hwang To: dri-de...@lists.freedesktop.org CC: airl...@linux.ie, de

Re: [PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver

2015-01-05 Thread Inki Dae
On 2015년 01월 05일 23:19, Thierry Reding wrote: > On Wed, Dec 31, 2014 at 07:41:43PM +0900, Inki Dae wrote: >> Hi Thierry, >> >> Ping~. >> >> Or is it ok to pick up this patch to my tree, exynos-drm-next? It >> doesn't seem to care for a long time. &g

Re: [PATCH 3/3] ARM: dts: add Panel device support for exynos3250-rinato

2015-01-02 Thread Inki Dae
On 2014년 11월 28일 20:39, Inki Dae wrote: > This patch adds MIPI-DSI and MIPI-DSI based S6E63J0X03 AMOLED panel > device nodes for Exynos3250 Rinato board. Hi Mr. Kukjin, Please, ping~ Thanks, Inki Dae > > Signed-off-by: Inki Dae > Acked-by: Kyungmin Park > --- > arch/ar

Re: [PATCH 1/3] ARM: dts: add fimd device support for exynos3250-rinato

2015-01-02 Thread Inki Dae
On 2014년 11월 28일 20:39, Inki Dae wrote: > This patch adds fimd device node which is a display controller > for Exynos3250 Rinato board. Hi Kukjin, Please, ping~ Thanks, Inki Dae > > Signed-off-by: Inki Dae > Acked-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos3

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2015-01-02 Thread Inki Dae
On 2015년 01월 02일 22:14, Ajay kumar wrote: > Hi Daniel, > > This series is sitting out there since long without any ACKs. > If people can ACK this series, I am ready to rebase and send ASAP. Acked-by: Inki Dae And, for [PATCH V8 5/14] drm/exynos: dp: support drm_bridge, Signed-off-

Re: [PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver

2014-12-31 Thread Inki Dae
Hi Thierry, Ping~. Or is it ok to pick up this patch to my tree, exynos-drm-next? It doesn't seem to care for a long time. Thanks, Inki Dae On 2014년 12월 09일 18:29, Hyungwon Hwang wrote: > From: Inki Dae > > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel drive

Re: [PATCH 26/29] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

2014-12-30 Thread Inki Dae
- /* > - * SHADOWCON/PRTCON register is used for enabling timing. > - * > - * for example, once only width value of a register is set, > - * if the dma is started then fimd hardware could malfunction so > - * with protect window settin

Re: [PATCH 25/29] drm/exynos: atomic phase 1: use drm_plane_helper_disable()

2014-12-30 Thread Inki Dae
On 2014년 12월 18일 22:58, Gustavo Padovan wrote: > From: Gustavo Padovan > > The atomic helper to disable planes also uses exynos_update_plane() to > disable plane so we had to adapt it to both commit and disable planes. > > A check for NULL CRTC was added to exynos_plane_mode_set() since planes >

Re: [PATCH 01/29] drm/exynos/fimd: only finish pageflip if START == START_S

2014-12-30 Thread Inki Dae
; > + if (start == start_s) > exynos_drm_crtc_finish_pageflip(ctx->drm_dev, ctx->pipe); As I already mentioned before, above codes should be called only in case of RGB mode until checked for i80 mode. Have you ever tested above codes on i80 mode? And what if 'start

Re: [PULL] drm-exynos-next 2014-12-22

2014-12-25 Thread Inki Dae
d enough at least for two weeks. Please, do not hurry. Such big changes should really be reviewed enough. I will wait for other reviews and them merge them if reviewed enough. If nobody have reviews then I will merge them. So please, don't worry about that. Thanks, Inki Dae > month ag

Re: drm: exynos: mixer: fix using usleep() in atomic context

2014-12-21 Thread Inki Dae
pped between checking for ctx->powered and > setting it doesn't actually prevent a race. The use of spin lock, reg_slock, has been used for a long time and we hadn't some cleanups to spin lock codes so far. The spin lock is also used in here and t

Re: [PATCH v2] drm/exynos/fimd: only finish pageflip if START == START_S

2014-12-16 Thread Inki Dae
t; - wake_up(&ctx->wait_vsync_queue); > - } > + /* set wait vsync event to zero and wake up queue. */ > + if (atomic_read(&ctx->wait_vsync_event)) { > + atomic_set(&ctx->wait_vsync_event, 0); > + wake_

Re: [PATCH] drm/exynos/fimd: only finish pageflip if START == START_S

2014-12-09 Thread Inki Dae
0, 0)); > + start_s = readl(ctx->regs + VIDWx_BUF_START_S(0, 0)); > + if (start == start_s) > + exynos_drm_crtc_finish_pageflip(ctx->drm_dev, ctx->pipe); > + > + /* set wait vsync event to zero and wake up queue. */ > + if (atomic_read(&am

Re: drm/exynos: some small forgotten patch

2014-12-09 Thread Inki Dae
Hi, On 2014년 11월 30일 09:35, tjak...@math.uni-bielefeld.de wrote: > Hello, > > while looking through my local kernel tree, I noticed that this patch > for the mixer component of drm/exynos, posted some time ago, was That might be a patch I missed. Can you tell me the Subject? Than

Re: [PATCH V3] drm/exynos: Add DECON driver

2014-12-08 Thread Inki Dae
On 2014년 12월 07일 21:04, Ajay Kumar wrote: > This series is based on exynos-drm-next branch of Inki Dae's tree at: > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > > DECON(Display and Enhancement Controller) is the new IP > in exynos7 SOC for generating video signals using

Re: [PATCH 1/2] drm/exynos: fimd: Remove drm_dev and pipe members from fimd_context

2014-12-08 Thread Inki Dae
On 2014년 12월 07일 21:04, Ajay Kumar wrote: > ctx->drm_dev is unnecessary since it can be easily accessed > via ctx->manager->drm_dev. Even the pipe variable inside > fimd_context is redundant. Cleaning up the same. Already applied. Thanks, Inki Dae > > S

[PATCH 0/3] add Display support for exynos3250 Rinato board

2014-11-28 Thread Inki Dae
This patch series adds Display support for exynos3250 Rinato board. For this, it adds fimd, MIPI-DSI and Panel device nodes to exynos3250-rinato dts file, and adds a s6e63j0x03 Amoled panel device driver which is based on MIPI-DSI bus. Inki Dae (3): ARM: dts: add fimd device support for

[PATCH 2/3] drm/panel: add s6e63j0x03 LCD Panel driver

2014-11-28 Thread Inki Dae
This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD Panel driver which uses mipi_dsi bus to communicate with Panel. Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/panel/Kconfig|6 + drivers/gpu/drm/panel/Makefile |1 + drivers/gpu/drm/panel

[PATCH 3/3] ARM: dts: add Panel device support for exynos3250-rinato

2014-11-28 Thread Inki Dae
This patch adds MIPI-DSI and MIPI-DSI based S6E63J0X03 AMOLED panel device nodes for Exynos3250 Rinato board. Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos3250-rinato.dts | 59 +++ 1 file changed, 59 insertions(+) diff --git a/arch

[PATCH 1/3] ARM: dts: add fimd device support for exynos3250-rinato

2014-11-28 Thread Inki Dae
This patch adds fimd device node which is a display controller for Exynos3250 Rinato board. Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos3250-rinato.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b

Re: [RFC PATCH] drm/exynos: Add DECON driver

2014-11-26 Thread Inki Dae
On 2014년 11월 25일 23:02, Ajay kumar wrote: > On Tue, Nov 25, 2014 at 6:59 PM, Inki Dae wrote: >> On 2014년 11월 25일 22:08, Ajay kumar wrote: >>> Hi Inki, >>> >>> On Tue, Nov 25, 2014 at 6:30 PM, Inki Dae wrote: >>>> On 2014년 11월 25일 21:17, Ajay kumar

Re: [RFC PATCH] drm/exynos: Add DECON driver

2014-11-25 Thread Inki Dae
On 2014년 11월 25일 22:08, Ajay kumar wrote: > Hi Inki, > > On Tue, Nov 25, 2014 at 6:30 PM, Inki Dae wrote: >> On 2014년 11월 25일 21:17, Ajay kumar wrote: >>> ping. >>> >> >> You'd need to clean up clocks and fix up binding file. And then let&#

Re: [RFC PATCH] drm/exynos: Add DECON driver

2014-11-25 Thread Inki Dae
On 2014년 11월 25일 21:17, Ajay kumar wrote: > ping. > You'd need to clean up clocks and fix up binding file. And then let's have review in more details. I wish that other people also give you their reviews. Anyway, below is my answer. Thanks, Inki Dae > On Tue, Nov 11, 201

[GIT PULL] exynos-drm-next

2014-11-25 Thread Inki Dae
point. Thanks, Inki Dae The following changes since commit ed1e8777a56f3523712506d608a29f57ed37b613: Merge branch 'drm-next-3.19' of git://people.freedesktop.org/~agd5f/linux into drm-next (2014-11-21 12:17:43 +1000) are available in the git repository at: git://git.kernel.org/pub

[PATCH] drm/exynos: vidi: add component support

2014-11-24 Thread Inki Dae
vidi is invalid so any requests with the crtc number will fail. This patch guarantees drm_vblank_init to be called after all kms drivers are ready by using component framework. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 61 ++ 1 file cha

drm/exynos: vidi: add component support

2014-11-24 Thread Inki Dae
vidi is invalid so any requests with the crtc number will fail. This patch guarantees drm_vblank_init to be called after all kms drivers are ready by using component framework. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 61 ++ 1 file cha

[PATCH] drm/exynos: fix exynos_drm_component_del

2014-11-24 Thread Inki Dae
This patch resolves the issue that component object isn't removed correctly. A given component object couldn't be placed to head of drm_component_list so all component objects added to the drm_component_list should be checked to remove the given component object. Signed-off-by

Re: [PATCH 3/3] drm/exynos: move Exynos platform drivers registration to init

2014-11-23 Thread Inki Dae
quot;, -1, > + NULL, 0); > + if (IS_ERR(exynos_drm_pdev)) > + return PTR_ERR(exynos_drm_pdev); > + > +#ifdef CONFIG_DRM_EXYNOS_VIDI > + ret = exynos_drm_probe_vidi(); > + if (ret < 0) > +

Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-22 Thread Inki Dae
2014-11-23 0:28 GMT+09:00 Inki Dae : > 2014-11-21 23:41 GMT+09:00 Gustavo Padovan : >> 2014-11-21 Inki Dae : >> >>> On 2014년 11월 21일 08:12, Gustavo Padovan wrote: >>> > 2014-11-13 Inki Dae : >>> > >>> >> This patch fixes null pointer d

Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-22 Thread Inki Dae
2014-11-21 23:41 GMT+09:00 Gustavo Padovan : > 2014-11-21 Inki Dae : > >> On 2014년 11월 21일 08:12, Gustavo Padovan wrote: >> > 2014-11-13 Inki Dae : >> > >> >> This patch fixes null pointer dereference issue incurred >> >> when ipp driver is en

Re: [PATCH 1/3] drm/exynos: free DP if probe fails to find a panel or bridge

2014-11-22 Thread Inki Dae
2014-11-21 8:54 GMT+09:00 Gustavo Padovan : > From: Gustavo Padovan > > DP was leaked everytime function returns EPROBE_DEFER, free it before > returning. It seems that you misunderstood devm_* api. Thanks, Inki Dae > > Signed-off-by: Gustavo Padovan > --- >

Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-20 Thread Inki Dae
On 2014년 11월 21일 08:12, Gustavo Padovan wrote: > 2014-11-13 Inki Dae : > >> This patch fixes null pointer dereference issue incurred >> when ipp driver is enabled and Exynos drm driver is closed. >> >> Non kms driver should register its own sub driver to setup ne

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Inki Dae
2014-11-21 0:26 GMT+09:00 Javier Martinez Canillas : > Hello Inki, > > On 11/20/2014 04:06 PM, Inki Dae wrote: >>> BTW, it would be great if exynos-drm-next is pulled in linux-next. That is >>> what most people use to test integration issues so you can catch earlier

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Inki Dae
Hi Javier, On 2014년 11월 20일 23:28, Javier Martinez Canillas wrote: > Hello Inki, > > On 11/20/2014 03:07 PM, Inki Dae wrote: >> Could you re-base this patch on top of exynos-drm-next? I tried to >> separate sub drivers into independent drivers but it seems that we need >

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
On 2014년 11월 20일 23:23, Andrzej Hajda wrote: > On 11/20/2014 02:56 PM, Inki Dae wrote: >> On 2014년 11월 20일 22:19, Andrzej Hajda wrote: >>> On 11/20/2014 11:24 AM, Inki Dae wrote: >>>> This patch makes kms drivers to be independent drivers. >>>> For

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
Hi Javier, On 2014년 11월 20일 23:06, Javier Martinez Canillas wrote: > Hello Inki, > > On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae wrote: >>> If you try to build exynosdrm as module you will receive errors due to >>> multiple definitions of init_module, ie module_init/mod

Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Inki Dae
ing > a deadlock in __driver_attach(). Fix this by moving the platform > drivers registration to exynos_drm_init(). Could you re-base this patch on top of exynos-drm-next? I tried to separate sub drivers into independent drivers but it seems that we need more times. So I will merge your patch. Thanks, In

Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
On 2014년 11월 20일 22:19, Andrzej Hajda wrote: > On 11/20/2014 11:24 AM, Inki Dae wrote: >> This patch makes kms drivers to be independent drivers. >> For this, it removes all register codes to kms drivers >> from exynos_drm_drv module and adds module_init/exit >> for e

[RFC PATCH v3 4/4] drm/exynos: clean up machine compatible string check

2014-11-20 Thread Inki Dae
Use 'for' statemant instead of hard-coded 'if' statement. Changelog v3: - none Changelog v2: - none Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/dr

[RFC PATCH v3 3/4] drm/exynos: make vidi driver to be independent driver

2014-11-20 Thread Inki Dae
this driver can be bound independently. Changelog v3: - none Changelog v2: - none Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 + drivers/gpu/drm/exynos/exynos_drm_drv.h |9 drivers/gpu/drm/exynos/exynos_drm_vidi.c | 81

[RFC PATCH v3 2/4] drm/exynos: make non kms drivers to be indenpendent drivers

2014-11-20 Thread Inki Dae
instead of -EPROBE_DEFER in case of no non kms device registered. This case is not error. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_core.c| 164 +++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 50 +--- drivers/gpu/drm/exynos/exynos_drm_drv.h

[RFC PATCH v3 0/4] separeate sub drivers into independent drivers

2014-11-20 Thread Inki Dae
rs will be built-in kernel image. Thanks, Inki Dae Inki Dae (4): drm/exynos: make kms drivers to be independent drivers drm/exynos: make non kms drivers to be indenpendent drivers drm/exynos: make vidi driver to be independent driver drm/exynos: clean up machine compatible string check

[RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Inki Dae
module_init/exit. - Configure all kms drivers to be built in kernel image. Changelog v2: - none Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c |2 ++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 43 +++--- drivers/gpu/drm/exynos/exynos_drm_drv.h

Re: [RFC PATCH 1/3] drm/exynos: make kms drivers to be independent modules

2014-11-19 Thread Inki Dae
2014-11-19 17:49 GMT+09:00 Andrzej Hajda : > On 11/18/2014 04:26 PM, Inki Dae wrote: >> This patch makes kms drivers to be independent modules. >> For this, it removes all register codes to kms drivers >> from exynos_drm_drv module and adds module_init/exit >> for each

Re: [RFC PATCH v2] drm/exynos: make non kms drivers to be indenpendent modules

2014-11-18 Thread Inki Dae
Hi YoungJun, On 2014년 11월 19일 13:39, YoungJun Cho wrote: > Hi Inki, > > There are 3 comments below. > > On 11/19/2014 12:19 PM, Inki Dae wrote: >> This patch makes non kms drivers to be independent modules. >> For this, it removes all register codes to non kms dri

[RFC PATCH v2] drm/exynos: make non kms drivers to be indenpendent modules

2014-11-18 Thread Inki Dae
. For this, this patch adds a new structure, exynos_drm_non_kms_dev, to exynos_drm_core module. Changelog v2: - check if available g2d device node. - return 0 instead of -EPROBE_DEFER in case of no non kms device registered. This case is not error. Signed-off-by: Inki Dae --- drivers/gpu/drm

Re: [PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-11-18 Thread Inki Dae
On 2014년 11월 19일 07:09, Tobias Jakobi wrote: > Inki Dae wrote: >> Hi Tomasz, >> >> Yes, of course. >> >> We will fix it soon. For this, I mentioned earlier, >> http://web.archiveorange.com/archive/v/hhSc574WhqJAKgdBq7KL >> >> Thanks, >> Ink

[RFC PATCH 2/3] drm/exynos: make non kms drivers to be indenpendent modules

2014-11-18 Thread Inki Dae
. For this, this patch adds a new structure, exynos_drm_non_kms_dev, to exynos_drm_core module. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_core.c| 166 +++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 50 +--- drivers/gpu/drm/exynos

[RFC PATCH 0/3] drm/exynos: add full modularity support to sub drivers

2014-11-18 Thread Inki Dae
loop issue and kernel lockup reported by other people. This patch set is RFC so there might be my missing points. Welcome to any comments. This patch set is based on top of exynos-drm-next branch. Thanks, Inki Dae Inki Dae (3): drm/exynos: make kms drivers to be independent

[RFC PATCH 1/3] drm/exynos: make kms drivers to be independent modules

2014-11-18 Thread Inki Dae
This patch makes kms drivers to be independent modules. For this, it removes all register codes to kms drivers from exynos_drm_drv module and adds module_init/exit for each kms driver so that each kms driver can be called independently. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/Kconfig

[RFC PATCH 3/3] drm/exynos: make vidi driver to be independent module

2014-11-18 Thread Inki Dae
required for modularity. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 + drivers/gpu/drm/exynos/exynos_drm_drv.h |9 drivers/gpu/drm/exynos/exynos_drm_vidi.c | 81 +++--- 3 files changed, 54 insertions(+), 48 deletions(-) diff

Re: [PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-18 Thread Inki Dae
On 2014년 11월 18일 12:20, Inki Dae wrote: > This patch fixes a infinite loop issue incurred when > it doesn't have a pair of crtc and connector drivers, > which was reported by Kevin Hilman like below, > http://www.spinics.net/lists/linux-samsung-soc/msg39050.html > >

Re: [BUG] blocked task after exynos_drm_init

2014-11-18 Thread Inki Dae
>> __driver_attach+0x48/0x98 > > > This is caused by patch moving platform devices to > /sys/devices/platform[1]. Since this patch registering platform > drivers/devices in probe of platform device causes deadlocks. I guess > now all driver registration should be moved t

Re: [PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-18 Thread Inki Dae
ideas why this could happen? As I mentioned above, I guess this issue could be incurred when a driver is probed in probe context of other driver. Actually, we had faced with same issue but we couldn't see this issue anymore for some time. Anyway, we need more checking. Thanks, Inki Dae >

Re: [PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-18 Thread Inki Dae
On 2014년 11월 18일 16:58, Sjoerd Simons wrote: > On Tue, 2014-11-18 at 12:20 +0900, Inki Dae wrote: >> This patch makes the deferred probe is tried up to 3 times in maximum. >> However, this is considered only for Exynos drm so I think other SoC >> drivers could also produce

[PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-17 Thread Inki Dae
ed probe is tried up to 3 times in maximum. However, this is considered only for Exynos drm so I think other SoC drivers could also produce same issue. Therefore, the best way to resolve this issue, infinite loop incurred by defered probe, would be that dd core is fixed up corrrectly. Signed-off-by:

Re: exynos boot falures in linux-next

2014-11-17 Thread Inki Dae
ue with some fixups but not yet. The problem is because -EPROBE_DEFER is returned in case of adding a component of a crtc device but one of a connector device. I will fix it up soon. Thanks for report, Inki Dae > > Best regards, > Javier > -- > To unsubscribe from this list: send th

Re: [PATCH 3/4] ARM: dts: add fimd device node to exynos4415.dtsi

2014-11-14 Thread Inki Dae
On 2014년 11월 07일 15:12, YoungJun Cho wrote: > This patch adds fimd device node to exynos4415.dtsi. > Hi Kukjin, Could you merge patch 3 and 4 to your tree? These are dt part for Exynos4415 drm support. For drm patches, I already merged them. Thanks, Inki Dae > Signed-off-by: You

Re: [PATCH v2 1/2] drm/exynos: Fix DSI resuming fail because power domain being off

2014-11-13 Thread Inki Dae
d to turn on because of system resume in progress. > > Forcing mode should not be needed and removing it solves this particular > problem. only this patch, Applied. Thanks, Inki Dae > > This necessary fix for following scenario reproduced on Exynos DRM: > 1. Power domain is of

Re: [PATCH v2] drm/exynos: add has_vtsel flag

2014-11-13 Thread Inki Dae
On 2014년 11월 14일 11:36, Joonyoung Shim wrote: > The exynos fimd provides video type selection bits from system register > but exynos3 series don't has it, so needs has_vtsel flag and we can > distinguish whether set video type selection bits. Applied. Thanks, Inki Dae >

Re: [PATCH v2 2/2] drm/exynos/dsi: Add runtime PM so LCD power domain could be turned off

2014-11-13 Thread Inki Dae
7;omapdrm'...failed. trying to open device 'exynos'...success. setting mode 720x1280-0Hz@XR24 on connectors 15, crtc 12 select timed out or error (ret 0) I'm not sure why this issue is incurred with this patch even through this patch is reasonable and correct. So we need more che

Re: [PATCH v3 RESEND 1/2] drm/exynos: dp: Remove support for unused dptx-phy

2014-11-13 Thread Inki Dae
On 2014년 11월 12일 18:42, Vivek Gautam wrote: > Now that we have moved to generic phy based bindings, > we don't need to have any code related to older dptx-phy. > Nobody is using this dptx-phy anymore, so removing the > same. Applied. Thanks, Inki Dae > > Signed-off-by: V

Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable

2014-11-13 Thread Inki Dae
I can prepare similar patches for other Exynos > DRM components. Sorry for late. Applied. Can you prepare similar patches for other? If so, I'd happy. Thanks, Inki Dae > > [1]: https://lkml.org/lkml/2014/9/22/148 > > Regards > Andrzej > > > Andrzej Hajda (4): &g

Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping

2014-11-13 Thread Inki Dae
On 2014년 10월 31일 23:17, Gustavo Padovan wrote: > From: Gustavo Padovan > > It is not even used in this header anymore. All patches, Applied. Thanks, Inki Dae > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 - > 1

Re: [PATCH 2/4] drm/exynos: fimd: support Exynos4415 SoC

2014-11-13 Thread Inki Dae
On 2014년 11월 07일 15:12, YoungJun Cho wrote: > This patch supports Exynos4415 SoC. Applied. Thanks, Inki Dae > > Signed-off-by: YoungJun Cho > Acked-by: Kyungmin Park > --- > Documentation/devicetree/bindings/video/samsung-fimd.txt | 1 + > drivers/gpu/drm/exy

Re: [PATCH 1/4] drm/exynos: dsi: support Exynos4415 SoC

2014-11-13 Thread Inki Dae
On 2014년 11월 07일 15:12, YoungJun Cho wrote: > This patch supports Exynos4415 SoC. > Applied. Thanks, Inki Dae > Signed-off-by: YoungJun Cho > Acked-by: Kyungmin Park > --- > Documentation/devicetree/bindings/video/exynos_dsim.txt | 1 + > drivers/gpu/drm/ex

[PATCH 2/2] drm/exynos: remove ifdeferry from initialization code

2014-11-12 Thread Inki Dae
driver in respect to infinite loop issue. Signed-off-by: Andrzej Hajda Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 196 ++- drivers/gpu/drm/exynos/exynos_drm_drv.h | 25 ++-- 2 files changed, 72 insertions(+), 149 deletions(-) diff --git a

[PATCH 1/2] drm/exynos: fix null pointer dereference issue

2014-11-12 Thread Inki Dae
drm driver is closed because ipp core device is registered after component_master_add_with_match call. This patch makes exynos_drm_device_subdrv_probe() to be called after all non kms drivers are registered. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 18

[PATCH 0/2] drm/exynos: fix null pointer dereferenece issue

2014-11-12 Thread Inki Dae
ifdeferry from initialization code Inki Dae (1): drm/exynos: fix null pointer dereference issue drivers/gpu/drm/exynos/exynos_drm_drv.c | 214 ++- drivers/gpu/drm/exynos/exynos_drm_drv.h | 25 ++-- 2 files changed, 81 insertions(+), 158 deletions(-) -- 1.7.9.5

Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping

2014-11-12 Thread Inki Dae
Sorry for late. I started to test and migrate them to exynos-drm-next yesterday. So I guess that you can see your patch series on exynos-drm-next today night or tomorrow. Thanks, Inki Dae On 2014년 11월 12일 23:13, Gustavo Padovan wrote: > Hi Inki, > > 2014-11-06 Inki Dae : > >

[PATCH] drm/exynos: fix possible infinite loop issue

2014-11-07 Thread Inki Dae
, http://comments.gmane.org/gmane.comp.video.dri.devel/117740 http://www.spinics.net/lists/linux-samsung-soc/msg38624.html Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff

[PATCH] drm/exynos: g2d: fix null pointer dereference

2014-11-07 Thread Inki Dae
. This patch makes for g2d_remove function tries to free the cmdlist_poll only in case that the cmdlist_poll is allocated. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: resolve infinite loop issue on non multi-platform

2014-11-07 Thread Inki Dae
On 2014년 11월 07일 17:29, Andrzej Hajda wrote: > On 11/06/2014 03:10 PM, Inki Dae wrote: >> This patch resovles the infinite loop issue incurred >> when Exyno drm driver is enabled but all kms drivers >> are disabled on Exynos board by returning -EPROBE_DEFER >> only in ca

[PATCH] drm/exynos: resolve infinite loop issue on non multi-platform

2014-11-06 Thread Inki Dae
This patch resovles the infinite loop issue incurred when Exyno drm driver is enabled but all kms drivers are disabled on Exynos board by returning -EPROBE_DEFER only in case that there is kms device registered. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c |6

Re: [PATCH] drm/exynos: resolve infinite loop issue on multi-platform

2014-11-06 Thread Inki Dae
On 2014년 11월 06일 22:00, Krzysztof Kozlowski wrote: > On czw, 2014-11-06 at 21:32 +0900, Inki Dae wrote: >> On 2014년 11월 06일 21:11, Krzysztof Kozłowski wrote: >>> On 06.11.2014 11:32, Inki Dae wrote: >>>> This patch resolves temporarily infinite loop issue incurred

Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping

2014-11-06 Thread Inki Dae
Hi Gustavo, On 2014년 11월 06일 21:38, Gustavo Padovan wrote: > > Hi Inki, > > Could you please give a review to this series? It looks good to me. This patch series is just cleanup but not test so I will merge them next week after testing if there is no any comment. Than

Re: [PATCH] drm/exynos: resolve infinite loop issue on multi-platform

2014-11-06 Thread Inki Dae
On 2014년 11월 06일 21:11, Krzysztof Kozłowski wrote: > On 06.11.2014 11:32, Inki Dae wrote: >> This patch resolves temporarily infinite loop issue incurred >> when Exynos drm driver is enabled and multi-platform kernel >> is used by registering Exynos drm device object only in

[PATCH] drm/exynos: resolve infinite loop issue on multi-platform

2014-11-06 Thread Inki Dae
This patch resolves temporarily infinite loop issue incurred when Exynos drm driver is enabled and multi-platform kernel is used by registering Exynos drm device object only in case of Exynos SoC. So this patch will be replaced with more generic way later. Signed-off-by: Inki Dae --- drivers

Re: [RFC PATCH] drm/exynos: Add DECON driver

2014-11-03 Thread Inki Dae
Hi, Fortunately, I could get the user manual for Exynos7420. Below are my comments. Thanks, Inki Dae On 2014년 10월 23일 01:34, Ajay kumar wrote: > On Wed, Oct 22, 2014 at 8:26 PM, Inki Dae wrote: >> >> Thanks for contribution. >> >> It seems reasonable that you separa

Re: [PATCH] drm/exynos: remove ifdeferry from initialization code

2014-10-30 Thread Inki Dae
s device registration >> related ifdefs to header file. >> >> Signed-off-by: Andrzej Hajda > > ping > Oops, this is one of them I missed. Sorry for this. Can you rebase this patch on top of exynos-drm-next?. I just had a setup to exynos-drm-next. Thanks, In

Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable

2014-10-30 Thread Inki Dae
gt; duplication >> and finally it does not allow to handle more than one device in system. >> It seems better to embed such structures in private context of the device. > > Gently ping. This patch series already is in exynos-drm-next-todo branch. I will move it to exynos-drm-n

Re: [PATCH 2/3] drm/exynos: dp: Remove support for unused dptx-phy

2014-10-30 Thread Inki Dae
== -EPROBE_DEFER) { > + return ret; > + } else { WARNING: else is not generally useful after a break or return #146: FILE: drivers/gpu/drm/exynos/exynos_dp_core.c:1208: + return ret; + } else { How about just returning ret like

<    1   2   3   4   5   6   >