[PATCH v7 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-09 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Acked-by: Lee Jones Acked-by: Olof Johansson --- Changes since v6

[PATCH v7 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-09 Thread Javier Martinez Canillas
sysfs inferface for cros_pd. Also reduce number of allocated objects, make chromeos sysfs class object a static and add refcounting to prevent object deletion while command is in progress. Signed-off-by: Gwendal Grignou Reviewed-by: Dmitry Torokhov Signed-off-by: Javier Martinez Canillas Tested

[PATCH v7 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-09 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH v7 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-09 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Tested-by: Heiko Stuebner Acked-by: Lee Jones Acked-by: Olof Johansson --- Changes since v6: - Add Olof Johansson Acked-by tag Changes since v5: None Changes

[PATCH v7 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-09 Thread Javier Martinez Canillas
other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones Acked-by: Olof Johansson --- Changes

[PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-09 Thread Javier Martinez Canillas
_ec_dev" series [3] are needed. The series is composed of the following patches: Alexandru M Stan (2): mfd: cros_ec: spi: Add a DT property to delay asserting the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple EC in a system Javier

Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators

2015-06-08 Thread Javier Martinez Canillas
Hello Krzysztof, On Mon, Jun 8, 2015 at 8:52 AM, Krzysztof Kozlowski wrote: > 2015-06-08 15:42 GMT+09:00 Javier Martinez Canillas : >> Hello, >> >> On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski >> wrote: >> >> [...] >> >>> >>

Re: [PATCH] thermal: exynos: Disable the regulator on probe failure

2015-06-07 Thread Javier Martinez Canillas
lator defined at > device tree") > Cc: > Reviewed-by: Javier Martinez Canillas > --- > > I am not entirely convinced that this should go to stable. Leaving a > regulator enabled in case of probe failure (no exynos TMU device) or > after deferred probe (regulator won't

Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators

2015-06-07 Thread Javier Martinez Canillas
Hello, On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski wrote: [...] > > To summarize my point of view: > 1. Unless Vivek's says otherwise, please give him the credits with > proper "from" field. > 2. Issues mentioned in previous mail should be addressed (missing > IS_ERR(), how disabling th

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Javier Martinez Canillas
Hello Lee, On 06/05/2015 12:38 PM, Lee Jones wrote: [...] >> >> -err = mfd_add_devices(dev, 0, cros_devs, >> - ARRAY_SIZE(cros_devs), >> +err = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_cell, 1, >>NULL, ec_dev->irq, NULL)

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Javier Martinez Canillas
Hello Lee, On 06/05/2015 12:17 PM, Lee Jones wrote: > On Thu, 04 Jun 2015, Javier Martinez Canillas wrote: > >> From: Gwendal Grignou >> >> Chromebooks can have more than one Embedded Controller so the >> cros_ec device id has to be incremented for each E

[PATCH v6 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-04 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v5: None Changes since v4: None Changes since v3: - Added tested-by from Heiko Stuebner. - Added

[PATCH v6 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-04 Thread Javier Martinez Canillas
l cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v5:

[PATCH v6 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-04 Thread Javier Martinez Canillas
n, to make sure that the EC has already woken up, if the property has been defined in the DTS. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v5: None

[PATCH v6 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-04 Thread Javier Martinez Canillas
other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v5: None Changes

[PATCH v6 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-04 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Acked-by: Lee Jones --- Changes since v5: None Changes since v4

[PATCH v6 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-04 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-04 Thread Javier Martinez Canillas
sysfs inferface for cros_pd. Also reduce number of allocated objects, make chromeos sysfs class object a static and add refcounting to prevent object deletion while command is in progress. Signed-off-by: Gwendal Grignou Reviewed-by: Dmitry Torokhov Signed-off-by: Javier Martinez Canillas Tested

[PATCH v6 1/8] mfd: cros_ec: Use a zero-length array for command data

2015-06-04 Thread Javier Martinez Canillas
er is used for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v5: None Changes since v4: None Changes since v3: - A

[PATCH v6 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-04 Thread Javier Martinez Canillas
a DT property to delay asserting the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for command data mfd: cros_ec: Move protocol helpers out of the MFD d

Re: [PATCH 01/11] ARM: dt: Add SPI CS on Samsung Snow board.

2015-06-03 Thread Javier Martinez Canillas
Hello Michal, On Wed, Jun 3, 2015 at 11:26 PM, Michal Suchanek wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek > --- > arch/arm/boot/dts/exynos5250-snow.dts | 3 ++- > 1 file

Re: [PATCH] ARM: multi_v7_defconfig: enable usb3503

2015-06-03 Thread Javier Martinez Canillas
Hello Kevin, On 06/04/2015 03:08 AM, Kevin Hilman wrote: > riku.voi...@linaro.org writes: > >> From: Riku Voipio >> >> CONFIG_USB_HSIC_USB3503 is needed by exynos5250-arndale for the on-board >> asix network controller. Enable it so networking works with >> multi_v7_defconfig out of box like it

Re: [PATCH v5 7/9] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, On 06/03/2015 03:49 PM, Lee Jones wrote: [...] >> >> int cros_ec_register(struct cros_ec_device *ec_dev) >> @@ -52,14 +68,39 @@ int cros_ec_register(struct cros_ec_device *ec_dev) >> >> cros_ec_query_all(ec_dev); >> >> -err = mfd_add_devices(dev, 0, cros_devs, >> -

[PATCH v5 6/9] mfd: cros_ec: Add DT property to define ChromeOS EC name

2015-06-03 Thread Javier Martinez Canillas
character device name and the sysfs entries. Add a "google,cros-ec-name" DT property to the ChromeOS EC binding document to change the EC name based on its function. Signed-off-by: Gwendal Grignou Reviewed-by: Doug Anderson Signed-off-by: Javier Martinez Canillas --- Changes since v4: None,

[PATCH v5 1/9] mfd: cros_ec: Use a zero-length array for command data

2015-06-03 Thread Javier Martinez Canillas
er is used for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v4: None Changes since v3: - Added acked-by tag from

[PATCH v5 5/9] mfd: cros_ec: add bus-specific proto v3 code

2015-06-03 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Acked-by: Lee Jones --- Changes since v4: None Changes since v3

[PATCH v5 2/9] mfd: cros_ec: rev cros_ec_commands.h

2015-06-03 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH v5 3/9] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-03 Thread Javier Martinez Canillas
other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v4: None Changes

[PATCH v5 4/9] mfd: cros_ec: add proto v3 skeleton

2015-06-03 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v4: None Changes since v3: - Added tested-by from Heiko Stuebner. - Added acked-by tag from Lee

[PATCH v5 8/9] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-03 Thread Javier Martinez Canillas
l cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v4:

[PATCH v5 0/9] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-03 Thread Javier Martinez Canillas
spi: Add a DT property to delay asserting the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (2): mfd: cros_ec: Add DT property to define ChromeOS EC name mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for c

[PATCH v5 9/9] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-03 Thread Javier Martinez Canillas
the EC has already woken up. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v4: None. Changes since v3: - New patch, split DT binding and driver impl

[PATCH v5 7/9] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
sysfs inferface for cros_pd. Also reduce number of allocated objects, make chromeos sysfs class object a static and add refcounting to prevent object deletion while command is in progress. Signed-off-by: Gwendal Grignou Reviewed-by: Dmitry Torokhov Signed-off-by: Javier Martinez Canillas Tested

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, On 06/03/2015 01:27 PM, Lee Jones wrote: > On Wed, 03 Jun 2015, Javier Martinez Canillas wrote: [snip] >> >> >> >> - err = mfd_add_devices(dev, 0, cros_devs, >> >> - ARRAY_SIZE(cros_devs), >> &

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 06/03/2015 10:53 AM, Lee Jones wrote: > On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: > >> From: Gwendal Grignou >> >> Chromebooks can have more than one Embedded Controller so the >> cros_ec device id has

Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-02 Thread Javier Martinez Canillas
Hello Heiko, On 06/02/2015 11:15 PM, Heiko Stübner wrote: > Am Dienstag, 2. Juni 2015, 10:11:03 schrieb Javier Martinez Canillas: >> Hello, >> >> Newer Chromebooks have more than one Embedded Controller (EC) in the >> system. These additional ECs are connected through

Re: [PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()

2015-06-02 Thread Javier Martinez Canillas
Hello Gustavo, On Tue, Jun 2, 2015 at 4:06 PM, Gustavo Padovan wrote: > Hi Inki, > > 2015-06-02 Inki Dae : > >> Hi, >> >> On 2015년 06월 02일 00:04, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > To follow more closely the new atomic API we split the dpms() >> > helper into the enable(

[PATCH v4 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-02 Thread Javier Martinez Canillas
l cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v3: - S

[PATCH v4 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-02 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Acked-by: Lee Jones --- Changes since v3: - Added acked-by tag from

[PATCH v4 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-02 Thread Javier Martinez Canillas
the EC has already woken up. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v3: - New patch, split DT binding and driver implementation as suggested

[PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-02 Thread Javier Martinez Canillas
: Gwendal Grignou Reviewed-by: Dmitry Torokhov Signed-off-by: Javier Martinez Canillas --- Changes since v3: - Add defines for the EC and PD index constants. - Remove cros_ec_dev_register() and declare the mfd_cells as static structs. Suggested by Lee Jones. - Add a new line before the return

[PATCH v4 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-02 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH v4 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-02 Thread Javier Martinez Canillas
other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v3: - Added tested

[PATCH v4 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-02 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v3: - Added tested-by from Heiko Stuebner. - Added acked-by tag from Lee Jones. Changes since v2

[PATCH v4 1/8] mfd: cros_ec: Use a zero-length array for command data

2015-06-02 Thread Javier Martinez Canillas
er is used for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Acked-by: Lee Jones --- Changes since v3: - Added acked-by tag from Lee Jones. Changes since

[PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-02 Thread Javier Martinez Canillas
spi: Add a DT property to delay asserting the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for command data mfd: cros_ec: Move protocol helpers out of t

Re: [PATCHv2] ARM: dts: odroidxu3: Enable USB3 regulators

2015-05-29 Thread Javier Martinez Canillas
-off-by tag should be before Krzysztof's Tested-by since first you posted the patch and then he tested it. > -Anand Moon > Best regards, Javier > On 29 May 2015 at 19:19, Javier Martinez Canillas wrote: >> Hello Anand, >> >> On Fri, May 29, 2015 at 3:34 PM, Anand

Re: [PATCHv2] ARM: dts: odroidxu3: Enable USB3 regulators

2015-05-29 Thread Javier Martinez Canillas
Hello Anand, On Fri, May 29, 2015 at 3:34 PM, Anand Moon wrote: > Enable regulator for usbdrd3_0 and usbdrd3_1. > Looking at the schematic pin diagram for MAX77802 > USB3_0 and USB3_1 is regulated by LDO9 and LD011. > > Fix the boot message of failed. > [3.503539] exynos-dwc3 usb@1200: Lo

Re: [PATCH v3 6/7] mfd: cros_ec: Support multiple EC in a system

2015-05-28 Thread Javier Martinez Canillas
Hello Lee, [...] On 05/28/2015 04:26 PM, Lee Jones wrote: >> >> >> >> + if (ec_dev->max_passthru) { >> >> + /* >> >> + * Register a PD device as well on top of this device. >> >> + * We make the following assumptions: >> >> + * - behind an EC, we have a pd >>

Re: [PATCH v3 6/7] mfd: cros_ec: Support multiple EC in a system

2015-05-28 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 05/27/2015 11:11 AM, Lee Jones wrote: > On Fri, 22 May 2015, Javier Martinez Canillas wrote: > >> From: Gwendal Grignou >> >> Chromebooks can have more than one Embedded Controller so the >> cros_ec device id has

Re: [PATCH v3 5/7] mfd: cros_ec: add bus-specific proto v3 code

2015-05-27 Thread Javier Martinez Canillas
Hello Lee, On 05/27/2015 10:53 AM, Lee Jones wrote: > On Fri, 22 May 2015, Javier Martinez Canillas wrote: > >> From: Stephen Barber >> >> Add proto v3 support to the SPI, I2C, and LPC. >> >> Signed-off-by: Stephen Barber >> Signed-off-by: Jav

Re: [PATCH v3 1/7] mfd: cros_ec: Use a zero-length array for command data

2015-05-27 Thread Javier Martinez Canillas
Hello Lee, On 05/27/2015 10:36 AM, Lee Jones wrote: >> --- >> drivers/i2c/busses/i2c-cros-ec-tunnel.c| 45 ++--- >> drivers/input/keyboard/cros_ec_keyb.c | 29 -- >> drivers/mfd/cros_ec.c | 28 -- >> drivers/mfd/cros_ec_i2c.c | 4 +-

Re: [PATCH 1/2] of: Add vendor prefix for Hardkernel

2015-05-25 Thread Javier Martinez Canillas
Hisilicon Limited. > hit Hitachi Ltd. > Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC

2015-05-25 Thread Javier Martinez Canillas
g: > sec_pmic 4-0066: No interrupt specified, no interrupts > > Signed-off-by: Krzysztof Kozlowski > --- I haven't checked with the board schematics but the patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list:

[PATCH v3 6/7] mfd: cros_ec: Support multiple EC in a system

2015-05-22 Thread Javier Martinez Canillas
: Gwendal Grignou Reviewed-by: Dmitry Torokhov Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Squash patch that adds support to represent EC's as different char devices (e.g: /dev/cros_ec, /dev/cros_pd): https://chromium-review.googlesource.co

[PATCH v3 1/7] mfd: cros_ec: Use a zero-length array for command data

2015-05-22 Thread Javier Martinez Canillas
er is used for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner --- Changes since v2: - Set the version field in the cros_ec_command. Reported by Heiko Stueb

[PATCH v3 3/7] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-05-22 Thread Javier Martinez Canillas
other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones Signed-off-by: Javier Martinez Canillas --- Changes since v2: None, new patch. --- drivers/i2c/busses/Kconfig

[PATCH v3 2/7] mfd: cros_ec: rev cros_ec_commands.h

2015-05-22 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH v3 7/7] mfd: cros_ec: spi: Add delay for asserting CS

2015-05-22 Thread Javier Martinez Canillas
ay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan Reviewed-by: Doug Anderson Signed-off-by: Chris Zhong Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: None, new patch --- Documentation/devi

[PATCH v3 4/7] mfd: cros_ec: add proto v3 skeleton

2015-05-22 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou --- Changes since v2: - Add the helpers to the drivers/platform/chrome/cros_ec_proto.c driver instead of drivers/mfd/cros_ec.c. Suggested by Lee Jones. - Rename

[PATCH v3 5/7] mfd: cros_ec: add bus-specific proto v3 code

2015-05-22 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Tested-by: Heiko Stuebner Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou --- Changes since v2: None Changes since v1: - Added Gwendal

[PATCH v3 0/7] mfd: cros_ec: Add multi EC and proto v3 support

2015-05-22 Thread Javier Martinez Canillas
rry their Tested-by tags for the patches that had not trivial changes. So testing on more platforms will be highly appreciated. The series is composed of the following patches: Alexandru M Stan (1): mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple

Re: [PATCH 2/2] ARM: multi_v7_defconfig: Enable display on Trats2 board

2015-05-22 Thread Javier Martinez Canillas
ONFIG_DRM_PTN3460=m > CONFIG_DRM_PS8622=m > CONFIG_DRM_EXYNOS=m > +CONFIG_DRM_EXYNOS_DSI=y > CONFIG_DRM_EXYNOS_FIMD=y > CONFIG_DRM_EXYNOS_HDMI=y > CONFIG_DRM_RCAR_DU=m > CONFIG_DRM_TEGRA=y > +CONFIG_DRM_PANEL_S6E8AA0=m > CONFIG_DRM_PANEL_SIMPLE=y > CONFIG_FB_ARMCLCD=y >

Re: [PATCH 1/2] ARM: exynos_defconfig: Enable display on Trats2 board

2015-05-22 Thread Javier Martinez Canillas
; CONFIG_DRM_PS8622=y > CONFIG_DRM_EXYNOS=y > +CONFIG_DRM_EXYNOS_DSI=y > CONFIG_DRM_EXYNOS_FIMD=y > CONFIG_DRM_EXYNOS_DP=y > CONFIG_DRM_PANEL=y > +CONFIG_DRM_PANEL_S6E8AA0=y > CONFIG_DRM_PANEL_SIMPLE=y > CONFIG_FB=y > CONFIG_FB_MODE_HELPERS=y > Reviewed-by:

Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias

2015-05-21 Thread Javier Martinez Canillas
Hello Thierry, On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote: > On 14.05.2015 09:32, Javier Martinez Canillas wrote: >> If the pwm-samsung driver is built as a module, modalias information is >> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE() >>

Re: [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250

2015-05-21 Thread Javier Martinez Canillas
250. >>> >>> Signed-off-by: Beata Michalska >> >> Reviewed-by: Krzysztof Kozlowski >> Tested-by: Krzysztof Kozlowski >> >> Tested on Gear 2 (Exynos3250) board. > > Oh, I was too fast. It seems that "reg" property is not needed > anymore.

Re: [PATCH 2/2] ARM: dts: exynos4415: Add syscon property to the MIPI DPHY

2015-05-21 Thread Javier Martinez Canillas
g,s5pv210-mipi-video-phy"; > - reg = <0x10020710 8>; > #phy-cells = <1>; > + syscon = <&pmu_system_controller>; > }; > > pd_cam: cam-power-domain@10024000 { > -- Reviewed-by: Javier

Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property

2015-05-21 Thread Javier Martinez Canillas
reg = <0x10020710 8>; > #phy-cells = <1>; > syscon = <&pmu_system_controller>; > }; Indeed, is even removed from the DT binding so this is clearly a left over. Reviewed-by: Javier Martinez Canillas Best regards, Jav

[RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string

2015-05-19 Thread Javier Martinez Canillas
achines. Also, it would require to duplicate a DTS since the machine is the same besides using a different SPI flash part. Signed-off-by: Javier Martinez Canillas --- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index dd616ff0ffc5

Re: [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support

2015-05-14 Thread Javier Martinez Canillas
Hello Krzysztof, On Fri, May 15, 2015 at 2:36 AM, Krzysztof Kozlowski wrote: > 2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas > : >> Many Exynos devices have devices attached to their display ports. >> This patch enables the needed Kconfig options to support different >

Re: [PATCH] MAINTAINERS: ARM64: EXYNOS: Extend entry for ARM64 DTS

2015-05-14 Thread Javier Martinez Canillas
gt; F: arch/arm/plat-samsung/ > F: arch/arm/mach-s3c24*/ > F: arch/arm/mach-s3c64xx/ > -- Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] rtc: Fix module autoload for max77xx RTC drivers

2015-05-13 Thread Javier Martinez Canillas
owing patches: Javier Martinez Canillas (2): rtc: max77686: Report platform modalias to fix module autoload rtc: max77802: Report platform modalias to fix module autoload drivers/rtc/rtc-max77686.c | 1 + drivers/rtc/rtc-max77802.c | 1 + 2 files changed, 2 insertions(+) Best regards, Javier

Re: [PATCH] ARM: exynos_defconfig: add options to make wifi usable

2015-05-11 Thread Javier Martinez Canillas
Hello Michal, On 05/11/2015 12:22 PM, Michal Suchanek wrote: > The Exynos defconfig includes mwifiex sdio support which is present on > some of the Exynos boards. > > For the WiFi to be usable two extra options are needed. Usermode Your subject line and the commit message are somehow misleading

[PATCH v2 06/10] mfd: cros_ec: add proto v3 skeleton

2015-05-09 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou --- Changes since v1: - Squash change https://chromium-review.googlesource.com/#/c/262870/ in the patch. Suggested by Gwendal Grignou - Add Reviewed-by and Tested

Re: [PATCH] ARM: dts: Add syscon property to the MIPI phy in exynos5420

2015-05-08 Thread Javier Martinez Canillas
<&pmu_system_controller>; > #phy-cells = <1>; > }; > > -- > 2.4.0 > With that change the patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field

2015-05-05 Thread Javier Martinez Canillas
in general and was not referring to this patch particular. >> Otherwise: >> >> Reviewed-by: Gwendal Grignou >> Tested-by: Gwendal Grignou >> >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas >> wrote: >> > From: Gwendal Grignou

Re: [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-04-17 Thread Javier Martinez Canillas
Hello Marek, On Fri, Apr 17, 2015 at 4:48 PM, Marek Szyprowski wrote: > Hello, > > > On 2015-04-17 16:33, Javier Martinez Canillas wrote: >> >> Hello Marek, >> >> On Wed, Feb 4, 2015 at 3:21 PM, Joerg Roedel wrote: >>> >>> Hi Marek, &

Re: [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-04-17 Thread Javier Martinez Canillas
chain loading using the verified u-boot that comes with the Chromebooks, I don't know if the RO boot-loader is leaving something enabled. In any case since HDMI with sysmmu is working correctly, that issue is orthogonal to your series and can be fixed as a followup so: Tested-by: Javier

Re: [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support

2015-04-16 Thread Javier Martinez Canillas
Hello Heiko, On 04/16/2015 11:49 AM, Heiko Stübner wrote: > Hi Javier, > > Am Donnerstag, 16. April 2015, 09:29:59 schrieb Javier Martinez Canillas: >> Hello, >> >> On 04/06/2015 06:14 PM, Javier Martinez Canillas wrote: >> > Newer Chromebooks have more than

Re: [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data

2015-04-16 Thread Javier Martinez Canillas
Hello Heiko, [snip] On 04/16/2015 11:45 AM, Heiko Stübner wrote: > >> /* Module initialization */ >> @@ -269,3 +301,4 @@ void ec_dev_sysfs_remove(struct cros_ec_device *ec) >> { >> sysfs_remove_group(&ec->vdev->kobj, &ec_attr_group); >> } >> + > > .git/rebase-apply/patch:893: new blank

Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420

2015-04-16 Thread Javier Martinez Canillas
Hello Kukjin, On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote: > Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > added a device node for the Exynos5420 DISP1 power domain but dit not > make the DP controller a consumer of that power domain.

Re: [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support

2015-04-16 Thread Javier Martinez Canillas
Hello, On 04/06/2015 06:14 PM, Javier Martinez Canillas wrote: > > Newer Chromebooks have more than one Embedded Controller (EC) in the > system. These additional ECs are connected through I2C with a host EC > which is the one that is connected to the Application Processor (AP) &

Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

2015-04-15 Thread Javier Martinez Canillas
Hello Kukjin, On 04/07/2015 05:09 PM, Doug Anderson wrote: > Javier, > > On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas > wrote: >> The Marvell mwifiex driver prevents the system to enter into a suspend >> state if the card power is not preserved durin

[PATCH 1/1] mmc: pwrseq: Fix error code propagation in mmc_pwrseq_simple_alloc()

2015-04-13 Thread Javier Martinez Canillas
uot;) Signed-off-by: Javier Martinez Canillas --- drivers/mmc/core/pwrseq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/pwrseq.c b/drivers/mmc/core/pwrseq.c index ab2129781161..4c1d1757dbf9 100644 --- a/drivers/mmc/core/pwrseq.c +++ b/drivers/mmc/core/p

[PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420

2015-04-12 Thread Javier Martinez Canillas
eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") Signed-off-by: Javier Martinez Canillas --- Hello, This latent bug was not exposed before since drivers for other devices marked as DISP1 power domain consumers were probed before exynos-dp so the PD was already on which made possi

Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Javier Martinez Canillas
Hello Sylwester, On 04/08/2015 11:06 AM, Sylwester Nawrocki wrote: >> >> diff --git a/drivers/clk/samsung/clk-exynos5420.c >> b/drivers/clk/samsung/clk-exynos5420.c >> index 07d666cc6a29..bea4a173eef5 100644 >> --- a/drivers/clk/samsung/clk-exynos5420.c >> +++ b/drivers/clk/samsung/clk-exynos542

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
Hello Tomasz, On 04/07/2015 11:28 PM, Tomasz Figa wrote: > > Looks good to me. You can consider this Acked-by, as long as Sylwester > is not opposed to this approach. > Thanks a lot, I've posted it as a proper patch now. > Best regards, > Tomasz > Best regards, Javier -- To unsubscribe from

[PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-07 Thread Javier Martinez Canillas
that this was the issue. Fixes: ae43b32 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12") Signed-off-by: Javier Martinez Canillas Tested-by: Kevin Hilman Tested-by: Abhilash Kesavan Acked-by: Tomasz Figa --- drivers/clk/samsung/clk-exynos5420.c | 1 + 1 file

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
Hello Abhilash, On 04/07/2015 04:38 PM, Abhilash Kesavan wrote: >> >> [0] >> From 78aa551ebcb9a4a7ae9d5581c33e0c0f19fe5ad6 Mon Sep 17 00:00:00 2001 >> From: Javier Martinez Canillas >> Date: Tue, 7 Apr 2015 15:53:27 +0200 >> Subject: [RFC PATCH] clk: exynos5

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
Hello Abhilash, On 04/07/2015 04:11 PM, Abhilash Kesavan wrote: > > Yes, though it increasingly looks like aclk266_g2d needs to stay ON > and we should use your patch that keeps it enabled prior to suspend. > Indeed, could you please give me some feedback on the latest RFC patch I shared [0] on

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
Hello Tomasz, On 04/07/2015 02:46 PM, Tomasz Figa wrote: > 2015-04-07 13:56 GMT+02:00 Javier Martinez Canillas > : >> So I disabled the sss clock before trying a S2R: >> >> # devmem 0x10018800 32 0xFFFB >> (CLK_SSS in CLK_GATE_IP_G2D is gated) >> >

[PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

2015-04-07 Thread Javier Martinez Canillas
Management property to the SDIO/MMC node so the mwifiex suspend handler doesn't fail and the system is able to enter into a suspend state. Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 + arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 + 2 files chang

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
On 04/07/2015 12:59 PM, Javier Martinez Canillas wrote: > > So IIUC the CG_STATUS0 bits were a red herring and the real problem > is that the aclk266_g2d needs to be enabled during suspend (although > we still don't know why). > > It seems were are at a dead end now. Wi

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-07 Thread Javier Martinez Canillas
Hello Abhilash, On 04/02/2015 02:22 PM, Abhilash Kesavan wrote: > Hi, > > On Thu, Apr 2, 2015 at 4:01 AM, Javier Martinez Canillas > wrote: >> Hello Sylwester, >> >> On 04/01/2015 07:31 PM, Sylwester Nawrocki wrote: >>> On 01/04/15 13:44, Javier Martinez C

Re: [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off

2015-04-07 Thread Javier Martinez Canillas
Drop "pclk" bindings entirely as suggested by Andrzej Hajda. >This was significant change so I did not add Javier's >reviewed/tested tags. Reviewed-by: Javier Martinez Canillas on an Exynos5420 Peach Pit Chromebook: Tested-by: Javier Martinez Canillas Best regards, Ja

[RESEND PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h

2015-04-06 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[RESEND PATCH 5/8] mfd: cros-ec: Support multiple EC in a system

2015-04-06 Thread Javier Martinez Canillas
Torokhov Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 7 ++- drivers/platform/chrome/cros_ec_dev.c | 4 ++-- include/linux/mfd/cros_ec.h | 2 ++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd

[RESEND PATCH 3/8] mfd: cros_ec: Instantiate sub-devices from device tree

2015-04-06 Thread Javier Martinez Canillas
From: Todd Broch If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 22 +++--- 1 file

[RESEND PATCH 1/8] mfd: cros ec: Remove parent field

2015-04-06 Thread Javier Martinez Canillas
From: Gwendal Grignou parent and dev were pointing to the same device structure. parent is unused, removed. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Barber Tested-by: Stephen Barber Reviewed-by: Puthikorn Voravootivat Signed-off-by: Javier Martinez Canillas --- drivers/mfd

[RESEND PATCH 7/8] mfd: cros_ec: add proto v3 skeleton

2015-04-06 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 363 +- drivers/mfd/cros_ec_i2c.c | 4 + drivers/mfd/cros_ec_spi.c | 7 +- drivers/platform/chrome/cros_ec_lpc.c | 4

<    1   2   3   4   5   6   7   8   9   10   >