On Mon, Jun 29, 2015 at 10:53:43AM +0200, Marek Szyprowski wrote:
On 2015-06-29 10:35, Joerg Roedel wrote:
The -ENODEV error just means that the device is not
translated by an IOMMU. We shouldn't bail out of iommu
driver initialization when that happens, as this is a common
scenario on ARM
could be of use for the iommu core in the future. Can you please try the
attached patch, which just ignores -ENODEV as a return value from
add_device?
From 3c9e7507e93ff6c6e05e6ee2cb123b5d35d8c412 Mon Sep 17 00:00:00 2001
From: Joerg Roedel jroe...@suse.de
Date: Mon, 29 Jun 2015 10:16:08 +0200
Subject
On Sat, May 23, 2015 at 07:23:34PM +0300, Laurent Pinchart wrote:
On Tuesday 19 May 2015 15:20:23 Marek Szyprowski wrote:
-arch_initcall(iommu_init);
+core_initcall(iommu_init);
I'll let Joerg comment on this, but this initcall ordering dance always makes
me feel that something isn't
On Tue, May 19, 2015 at 03:20:20PM +0200, Marek Szyprowski wrote:
Marek Szyprowski (25):
drm/exynos: iommu: detach from default dma-mapping domain on init
drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()
iommu: Init iommu-groups support earlier, in core_initcall
Hi Alex,
On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote:
For 1-5,16
Reviewed-by: Alex Williamson alex.william...@redhat.com
Thanks a lot for your review.
My only comment/question is whether you'd want to consider using
ERR_PTR() return values from domain_alloc(). It's an
Hi Will,
On Mon, Mar 30, 2015 at 06:43:15PM +0100, Will Deacon wrote:
Whilst I'm still a bit worried about the ability of the IOMMU driver to do
very much in the -domain_alloc callback (since we don't know which IOMMU
instance the domain is for), it doesn't leave us any worse off than we
On Thu, Mar 26, 2015 at 01:43:03PM +0100, Joerg Roedel wrote:
Changes v1-v2:
* Rebased to v4.0-rc5
* Converted domain-types to a bit-field
Applied this series to the core branch.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/shmobile-iommu.c | 39 +++
1 file changed, 23 insertions(+), 16
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/fsl_pamu_domain.c | 60 ++---
drivers/iommu/fsl_pamu_domain.h
From: Joerg Roedel jroe...@suse.de
All drivers have been converted to the new domain_alloc and
domain_free iommu-ops. So remove the old ones and get rid of
iommu_domain-priv too, as this is no longer needed when the
struct iommu_domain is embedded in the private structures of
the iommu drivers
for x86, ARM and PPC
and runtime tested on x86 (Intel VT-d and AMD IOMMU).
Please review.
Thanks,
Joerg
Joerg Roedel (15):
iommu: Introduce domain_alloc and domain_free iommu_ops
iommu: Introduce iommu domain types
iommu/amd: Make use of domain_alloc and domain_free
iommu/vt-d
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/exynos-iommu.c | 87
1 file changed, 47 insertions
From: Joerg Roedel jroe...@suse.de
This allows to handle domains differently based on their
type in the future. An IOMMU driver can implement certain
optimizations for DMA-API domains for example.
The domain types can be extended later and some of the
existing domain attributes can be migrated
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/rockchip-iommu.c | 40
1 file changed, 24 insertions(+), 16
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/ipmmu-vmsa.c | 41 +++--
1 file changed, 23 insertions(+), 18
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/tegra-gart.c | 67 +++---
1 file changed, 46 insertions
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/msm_iommu.c | 73 +++
1 file changed, 36 insertions
From: Joerg Roedel jroe...@suse.de
Check for the new __IOMMU_DOMAIN_PAGING flag before calling
into the iommu drivers -map and -unmap call-backs.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/iommu.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/iommu/iommu.c
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/arm-smmu.c | 46 +++---
1 file changed, 27 insertions(+), 19
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/tegra-smmu.c | 41 +++--
1 file changed, 23 insertions(+), 18
From: Joerg Roedel jroe...@suse.de
Get rid of domain_init and domain_destroy and implement
domain_alloc/domain_free instead.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/intel-iommu.c | 48 ++---
1 file changed, 28 insertions(+), 20
From: Joerg Roedel jroe...@suse.de
Implement the new iommu-ops function pointers and remove the
obsolete domain_init and domain_destroy functions.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/amd_iommu.c | 84 ++---
drivers/iommu
From: Joerg Roedel jroe...@suse.de
These new call-backs defer the allocation and destruction of
'struct iommu_domain' to the iommu driver. This allows
drivers to embed this struct into their private domain
structures and to get rid of the domain_init and
domain_destroy call-backs when all drivers
From: Joerg Roedel jroe...@suse.de
Implement the new domain_alloc and domain_free call-backs
and remove the old domain_init/destroy ones.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/omap-iommu.c | 49 +++---
1 file changed, 29 insertions
Hi Yingjoe,
On Fri, Mar 20, 2015 at 05:24:18PM +0800, Yingjoe Chen wrote:
What's the status of this patchset?
While porting MTK IOMMU driver[1], we need to use a global variable
because we need to do dma_alloc_coherent in our domain_init. I think we
can remove that global variable if we base
Hi Marek,
On Fri, Jan 23, 2015 at 04:51:10PM +0100, Marek Szyprowski wrote:
1. All iommu related patches (with 'iommu: exynos') can be merged to
iommu tree. They don't have any direct dependencies on the DTS, DRM and
power domain initialization change - without them the driver will simply
not
Hi Will,
On Wed, Jan 28, 2015 at 02:19:34PM +, Will Deacon wrote:
+/* This are the possible domain-types */
+enum iommu_domain_type {
+ IOMMU_DOMAIN_DMA, /* Domain used for DMA-API */
+ IOMMU_DOMAIN_IDENTITY, /* Identity mapped domain */
What happens if somebody calls
Hi Laurent,
On Mon, Jan 26, 2015 at 03:03:57PM +0200, Laurent Pinchart wrote:
On Monday 26 January 2015 12:00:59 Joerg Roedel wrote:
My plan is to make IOMMU groups mandatory. I am currently preparing and
RFC patch-set to introduce default-domains (which will be per group). So
when all
From: Joerg Roedel jroe...@suse.de
Implement the new iommu-ops function pointers and remove the
obsolete domain_init and domain_destroy functions.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/amd_iommu.c | 84 ++---
drivers/iommu
From: Joerg Roedel jroe...@suse.de
This allows to handle domains differently based on their
type in the future. An IOMMU driver can implement certain
optimizations for DMA-API domains for example.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/iommu.c | 5 +++--
include/linux
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/tegra-smmu.c | 41 +++--
1 file changed, 23 insertions(+), 18
From: Joerg Roedel jroe...@suse.de
Implement the new domain_alloc and domain_free call-backs
and remove the old domain_init/destroy ones.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/omap-iommu.c | 49 +++---
1 file changed, 29 insertions
Hi Laurent,
On Sun, Jan 25, 2015 at 05:38:22PM +0200, Laurent Pinchart wrote:
IOMMU groups still seem a bit unclear to me. Will Deacon has nicely explained
what they represent in
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310816.html.
The IOMMU core doesn't make
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/shmobile-iommu.c | 40
1 file changed, 24 insertions(+), 16
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/ipmmu-vmsa.c | 43 ---
1 file changed, 24 insertions(+), 19
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/fsl_pamu_domain.c | 60 ++---
drivers/iommu/fsl_pamu_domain.h
From: Joerg Roedel jroe...@suse.de
All drivers have been converted to the new domain_alloc and
domain_free iommu-ops. So remove the old ones and get rid of
iommu_domain-priv too, as this is no longer needed when the
struct iommu_domain is embedded in the private structures of
the iommu drivers
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/rockchip-iommu.c | 40
1 file changed, 24 insertions(+), 16
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/arm-smmu.c | 46 +++---
1 file changed, 27 insertions(+), 19
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/exynos-iommu.c | 87
1 file changed, 47 insertions
From: Joerg Roedel jroe...@suse.de
Get rid of domain_init and domain_destroy and implement
domain_alloc/domain_free instead.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/intel-iommu.c | 48 ++---
1 file changed, 28 insertions(+), 20
From: Joerg Roedel jroe...@suse.de
Implement domain_alloc and domain_free iommu-ops as a
replacement for domain_init/domain_destroy.
Signed-off-by: Joerg Roedel jroe...@suse.de
---
drivers/iommu/msm_iommu.c | 73 +++
1 file changed, 36 insertions
On Fri, Dec 05, 2014 at 02:47:37PM +0100, Krzysztof Kozlowski wrote:
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied to iommu/fixes, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
On Mon, Jan 05, 2015 at 12:09:03PM +0100, Krzysztof Kozlowski wrote:
Thanks, but... Few days after my patch Mark Brown posted something
similar:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310743.html
It was merged by Arnd Bergman and sent to Linus around 3.19-rc1. It
On Tue, Aug 05, 2014 at 12:47:32PM +0200, Marek Szyprowski wrote:
+ if (failed dev-bus)
+ blocking_notifier_call_chain(dev-bus-p-bus_notifier,
+ BUS_NOTIFY_DRVBIND_FAILED, dev);
+
Why can't you just use the notifier for
On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote:
.../devicetree/bindings/iommu/samsung,sysmmu.txt | 93 ++-
Documentation/power/notifiers.txt | 14 +
arch/arm/boot/dts/exynos4.dtsi | 118
arch/arm/boot/dts/exynos4210.dtsi
On Wed, May 14, 2014 at 11:23:33AM +0530, Shaik Ameer Basha wrote:
.../devicetree/bindings/iommu/samsung,sysmmu.txt |5 +
1 file changed, 5 insertions(+)
Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
On Mon, May 12, 2014 at 11:44:45AM +0530, Shaik Ameer Basha wrote:
Cho KyongHo (18):
iommu/exynos: fix build errors
iommu/exynos: change error handling when page table update is failed
iommu/exynos: allocate lv2 page table from own slab
iommu/exynos: fix L2TLB invalidation
On Wed, Apr 30, 2014 at 04:27:10PM +0530, Shaik Ameer Basha wrote:
This series is going on for quite a long time and most of the patches here
doesn't depend on dt bindings. As Exynos IOMMU h/w is introducing new versions
very frequently, maintaining and reviewing all these patches again and
On Mon, Oct 07, 2013 at 10:52:12AM +0900, Cho KyongHo wrote:
Patch summary:
[PATCH 01/20] iommu/exynos: do not include removed header
[PATCH 02/20] iommu/exynos: add missing cache flush for removed page table
entries
[PATCH 03/20] iommu/exynos: change error handling when page table update is
Hi Cho,
On Fri, Nov 01, 2013 at 09:37:45PM +0900, Cho KyongHo wrote:
I am preparing next patches to apply Alex Williamson's comment that
description of IOMMU's masters must be aligned with ARM SMMU.
It is delayed due to my jobs in the office.
I will post the next patche series in two
On Thu, Aug 08, 2013 at 11:28:44AM -0700, Grant Grundler wrote:
I can't speak to the previous BUG_ON(). I believe the EADDRESSINUSE
failures could be either WARN_ON or BUG_ON. This condition is
clearly a bug in the generic IOMMU allocator and I think that's why
KyongHo Cho used BUG_ON.
On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote:
Oh, this is a valid point, but it was more a nitpick about the coding
style. Single path error handling (with goto) is widely used in the kernel
in cases when more than one thing has to be undone and so I suggested this
method of
KyongHo,
On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote:
__sysmmu_enable() must return 1 if it is called with the same page table.
I have fixed it exynos_iommu_attach_device() to always return zero on success
in the next patchset which I will post today.
Thank you.
When you
Cho,
On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote:
On Tuesday, January 1, 2013, Sylwester Nawrocki sylvester.nawro...@gmail.com
Cc: devicetree-disc...@lists.ozlabs.org
Since patch 7 of this set is already merged, do you mind to re-post the
rest of this patch-set with the
On Wed, Nov 14, 2012 at 05:51:12PM +0900, Cho KyongHo wrote:
This commit enhances power management of System MMU and its client
devices with the following changes:
- Each System MMU device becomes the parent device of its client
device while probe(). Thus, exynos-iommu driver must be
To compile this patch,
you will need for-next branch of the linux-samsung.git:
git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
Other patches needed by this patch are merged to the above branch.
Cc: Joerg Roedel joerg.roe...@amd.com
Cc: Kukjin Kim kgene@samsung.com
Signed-off
On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote:
Anyway Joerg, how do you want to handle this? Do you want to pick up
1/2/3 all of them in your tree? If so, 2nd patch should be on top of
some samsung topic stuff.
Since patch 2 only applies to the Samsung tree, it is best to
On Thu, Mar 15, 2012 at 05:32:39PM +0900, Cho KyongHo wrote:
Handling System MMUs with an identifier is not flexible to manage
System MMU platform devices because of the following reasons:
1. A device driver which needs to handle System MMU must know the ID.
2. A System MMU may not present in
On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote:
+struct sysmmu_drvdata {
+ struct device *sysmmu;
+ char *dbgname;
+ int nsfrs;
+ void __iomem **sfrbases;
+ struct clk *clk[2];
+ int activations;
+ rwlock_t lock;
+ struct iommu_domain
On Wed, Jan 25, 2012 at 03:51:58PM +0900, KyongHo Cho wrote:
This isn't really a problem. We allow destroying a domain with devices
attached. So this WARN_ON is not necessary.
BTW, Isn't it a problem when a device driver does not know that its
iommu domain is destroyed?
Can we regards
Hi,
please also get and inclue Acks from the Exynos maintainer for the next
post.
Since I have a compiling config for exynos now I will merge the patches
when you have the Acks and addressed or explained the issues I pointed
out below.
On Thu, Dec 29, 2011 at 09:26:08PM +0900, KyongHo Cho wrote:
On Wed, Jan 04, 2012 at 09:26:20PM +, Russell King - ARM Linux wrote:
On Wed, Jan 04, 2012 at 04:01:01PM +0100, Joerg Roedel wrote:
On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote:
It comes through when I stick it in my tree because of a month of asking
On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote:
On Mon, Jan 02, 2012 at 04:58:20PM +0100, Joerg Roedel wrote:
On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote:
I still get
LD .tmp_vmlinux1
/data/cross/gcc-4.6.0-nolibc/arm-unknown-linux
Hi Marek,
On Tue, Jan 03, 2012 at 10:37:29AM +0100, Marek Szyprowski wrote:
Yes, there is something a bit wrong with your kernel configuration. You get
this error if
there is no board selected to be compiled-in. Please go to kernel
configuration and select
System Type - SAMSUNG EXYNOS
Hi,
On Thu, Dec 29, 2011 at 09:24:18PM +0900, KyongHo Cho wrote:
Changes since v7:
- Rebased with the recent commits of the following git branches
* git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/next
* git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git/for-next
-
On Mon, Dec 19, 2011 at 01:04:18AM +0900, Kukjin Kim wrote:
Hmm, I cannot find the iommu/exynos branch what you said in your iommu
tree yet. Maybe you missed or any problem?
Problems. I tried to apply the patches and there were conflicts. After
solving them I wasn't able to find a
On Tue, Dec 13, 2011 at 04:14:26PM +0900, KyongHo Cho wrote:
Since it is not guaranteed that an iommu driver initializes in its
domain_init() function, it must be initialized with NULL to prevent
calling a function in an arbitrary location when iommu fault occurred.
Signed-off-by: KyongHo
On Tue, Dec 06, 2011 at 09:13:18PM +0900, KyongHo Cho wrote:
BTW, how do you test it at mainline kernel?
I merged IOMMU mainline branch to our kernel branch and tested it with
our FIMC, MFC, JPEG, 2D.
This is not sufficient. Please do it the other way around, merge your
outstanding changes
On Mon, Dec 05, 2011 at 04:47:15PM +0100, Joerg Roedel wrote:
Okay, I merged it into arm/exynos, but it is not pushed yet. Actually
there were conflicts while merging, which I resolved. What I failed
to find is a config for Exynos that actually builds for upstream Linux.
Probably I havn't
On Fri, Dec 02, 2011 at 05:43:21PM +0900, Kukjin Kim wrote:
OK, I will merge iommu/exynos into Samsung tree after your creating that.
I can't look at iommu/exynos branch in your tree,
git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git.
That's because I havn't merged any exynos
On Thu, Dec 01, 2011 at 04:29:17PM +0900, Kukjin Kim wrote:
Anyway, that touches many Samsung stuff so it would be better if you could
create separate topic branch which can be merged into Samsung tree. And if
required, please add my ack on them.
Yes, I use topic-branches a lot :) This will
On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote:
Changes since v6:
- Totally rewrite exynos_iommu_map() and exynos_iommu_unmap() according
to the change in iommu_map() and iommu_unmap().
- Change special slab for Lv2 page table to kmalloc().
Okay, the driver looks good to me
() according to the
suggestion of Joerg Roedel.
This should be part of patch 3 already when the bus_set_iommu() change
is merged. Otherwise it breaks bisectability too.
Ok.
Should I include fault handling feature (patch 4) in the patch 3 also?
Yes, makes sense to include patch 4 too
74 matches
Mail list logo
