Re: [PATCH v2 1/3] iio: exyno-adc: use syscon for PMU register access

2014-11-05 Thread Jonathan Cameron
On 28/10/14 12:31, Vivek Gautam wrote: Hi all, CC'ing Naveen's gmail id, since the Samsung id is invalid now. On Tue, Sep 16, 2014 at 2:28 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and

Re: [PATCH v2 1/3] iio: exyno-adc: use syscon for PMU register access

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and use PMU registers instead of remapping the PMU registers in the driver. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com To:

Re: [PATCH v2 2/3] Documentation: dt-bindings: update exynos-adc.txt with syscon handle

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: This patch updates the DT bindings for ADC in exynos-adc.txt with the syscon phandle to the ADC nodes. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com To: devicet...@vger.kernel.org Applied to the togreg branch of iio.git -

Re: [PATCH v2 3/3] ARM: dts: exynos: Add sysreg phandle to ADC node

2014-11-05 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: Instead of using the ADC_PHY register base address, use sysreg phandle in ADC node to control ADC_PHY configuration register. This patch adds syscon node for Exynos3250, Exynos4x12, Exynos5250, and Exynos5420, Exynos5800. Signed-off-by:

Re: [PATCH v2 0/3] iio: exynos-adc: use syscon instead of ioremap

2014-10-25 Thread Jonathan Cameron
On 09/10/14 21:05, Jonathan Cameron wrote: On 21/09/14 13:17, Jonathan Cameron wrote: On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: Changes since v1: 1. Rebased on top of togreg branch of IIO git. This patch set does the following 1. Use the syscon and Regmap API instead

Re: [PATCH v2 0/3] iio: exynos-adc: use syscon instead of ioremap

2014-10-10 Thread Jonathan Cameron
On 21/09/14 13:17, Jonathan Cameron wrote: On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: Changes since v1: 1. Rebased on top of togreg branch of IIO git. This patch set does the following 1. Use the syscon and Regmap API instead of ioremappaing the ADC_PHY register from PMU. 2

Re: [PATCH v2 0/3] iio: exynos-adc: use syscon instead of ioremap

2014-09-21 Thread Jonathan Cameron
On 16/09/14 09:58, Naveen Krishna Chatradhi wrote: Changes since v1: 1. Rebased on top of togreg branch of IIO git. This patch set does the following 1. Use the syscon and Regmap API instead of ioremappaing the ADC_PHY register from PMU. 2. Updates the Documentation in exynos-adc.txt

Re: [PATCHv2 1/3] iio: adc: exynos_adc: add support for s3c64xx adc

2014-08-07 Thread Jonathan Cameron
On 28/07/14 13:44, Chanwoo Choi wrote: From: Arnd Bergmann a...@arndb.de The ADC in s3c64xx is almost the same as exynosv1, but has a different 'select' method. Adding this here will be helpful to move over the existing s3c64xx platform from the legacy plat-samsung/adc driver to the new

Re: [PATCHv2 2/3] iio: adc: exynos_adc: Add support for s3c24xx ADC

2014-08-07 Thread Jonathan Cameron
On 28/07/14 13:44, Chanwoo Choi wrote: This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx is alomost same as ADCv1. But, There are a little difference as following: - ADCMUX register address - ADCDAT mask (10 bit or 12 bit ADC resolution according to SoC version) -

Re: [PATCHv2 3/3] dt-bindings: samsung: exynos_adc: Remove un-necessary white-sapce

2014-08-07 Thread Jonathan Cameron
On 28/07/14 13:44, Chanwoo Choi wrote: This patch remove un-necessary white-sapce to code clean. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Applied to the togreg branch of iio.git. Obviously this didn't need to go through my tree, but as it is so trivial it might as well do so. J ---

Re: [PATCHv8 4/4] ARM: dts: Fix wrong compatible string for Exynos3250 ADC

2014-07-23 Thread Jonathan Cameron
On 22/07/14 03:04, Chanwoo Choi wrote: This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC need to control only special clock for ADC. Exynos SoC except for Exynos3250 has not included special clock for ADC. The exynos ADC driver can control special clock if compatible

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-20 Thread Jonathan Cameron
On 18/07/14 20:29, Arnd Bergmann wrote: This adds support for the touchscreen on Samsung s3c64xx. The driver is completely untested but shows roughly how it could be done, following the example of the at91 driver. Hi Arnd, Open questions include: - compared to the old plat-samsung/adc

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-20 Thread Jonathan Cameron
On 20/07/14 14:49, Jonathan Cameron wrote: On 18/07/14 20:29, Arnd Bergmann wrote: This adds support for the touchscreen on Samsung s3c64xx. The driver is completely untested but shows roughly how it could be done, following the example of the at91 driver. Hi Arnd, Cc'd linux-input

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

2014-07-20 Thread Jonathan Cameron
On 17/07/14 14:56, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday, July 17, 2014 05:41:16 PM Naveen Krishna Ch wrote: Hello Sachin, On 17 July 2014 17:24, Sachin Kamat spk.li...@gmail.com wrote: Hi Naveen, On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com

Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap

2014-07-15 Thread Jonathan Cameron
On 11/07/14 10:06, Naveen Krishna Chatradhi wrote: This patch does the following 1. Use the syscon and Regmap API instead of ioremappaing the ADC_PHY register from PMU. 2. Moves the exynos-adc.txt from bindings/arm/samsung/ to bindings/iio/adc/. 3. Updates the Documentation in

Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap

2014-07-15 Thread Jonathan Cameron
On 15/07/14 19:13, Jonathan Cameron wrote: On 11/07/14 10:06, Naveen Krishna Chatradhi wrote: This patch does the following 1. Use the syscon and Regmap API instead of ioremappaing the ADC_PHY register from PMU. 2. Moves the exynos-adc.txt from bindings/arm/samsung/ to bindings/iio/adc

Re: [PATCHv5 3/4] iio: devicetree: Add DT binding documentation for Exynos3250 ADC

2014-06-29 Thread Jonathan Cameron
On 27/06/14 05:30, Chanwoo Choi wrote: This patch add DT binding documentation for Exynos3250 ADC IP. Exynos3250 has special clock ('sclk_adc') for ADC which provide clock to internal ADC. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Jonathan Cameron
On 27/06/14 05:30, Chanwoo Choi wrote: Changes from v4: - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure and remove enum variable of ADC version - Fix wrong name of special clock (sclk_tsadc - sclk_adc) - Add reviewed message by Naveen Krishna Chatradhi - Add functions

Re: [PATCH 1/5 v3] iio: exynos_adc: use indio_dev-dev structure to handle child nodes

2014-04-30 Thread Jonathan Cameron
On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: From: Naveen Krishna Ch ch.nav...@samsung.com Using pdev-dev with device_for_each_child() would iterate over all of the children of the platform device and delete them. Thus, causing crashes during module unload. We should be using the

Re: [PATCH 2/5 v3] iio: exynos_adc: rearrange clk and regulator enable/disable calls

2014-04-30 Thread Jonathan Cameron
On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch maintains the following order in probe(), remove(), resume() and suspend() calls regulator enable, clk prepare enable ... clk disable unprepare, regulator disable While at it, 1. enable

Re: [PATCH 3/5 v3] iio: exynos_adc: reduce timeout and use wait_for_completion_timeout

2014-04-30 Thread Jonathan Cameron
On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: ADC module on Exynos5 SoCs runs at 600KSPS. At this conversion rate, waiting for 1000 msecs is wasteful (incase of h/w failure). Hence, reduce the time out to 100msecs and use wait_for_completion_timeout() instead of

Re: [PATCH 4/5 v3] iio: exynos_adc: do a soft reset in case of timeout

2014-04-30 Thread Jonathan Cameron
On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: Do a soft reset software if a timeout happens. This is applicable only for ADC_V2. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org Applied to the togreg branch of iio.git Thanks,

Re: [PATCH 5/5 v3] iio: exynos_adc: do a reinit_completion before the conversion

2014-04-30 Thread Jonathan Cameron
On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: Add reinit_completion() before the wait_for_completion_timeout in raw_read() call. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org Applied to the togreg branch of iio.git I wasn't

Re: [PATCH 5/5 v3] iio: exynos_adc: do a reinit_completion before the conversion

2014-04-30 Thread Jonathan Cameron
On May 1, 2014 12:23:27 AM GMT+01:00, Doug Anderson diand...@chromium.org wrote: Jonathan, On Wed, Apr 30, 2014 at 1:49 PM, Jonathan Cameron ji...@kernel.org wrote: On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: Add reinit_completion() before the wait_for_completion_timeout in raw_read

Re: [PATCH 1/5] iio: exynos_adc: use indio_dev-dev structure to handle child nodes

2014-04-26 Thread Jonathan Cameron
On 25/04/14 16:46, Doug Anderson wrote: Naveen, Thanks for sending this. Given that Jonathan Cameron was involved in the previous discussion, it probably would have been wise to include him on the CC list. In my case, don't worry too much as I have linux-iio coming into exactly the same place

Re: [PATCH 1/5 v2] iio: exynos_adc: use indio_dev-dev structure to handle child nodes

2014-04-26 Thread Jonathan Cameron
On 26/04/14 12:37, Naveen Krishna Chatradhi wrote: From: Naveen Krishna Ch ch.nav...@samsung.com Using pdev-dev with device_for_each_child() would iterate over all of the children of the platform device and delete them. Thus, causing crashes during module unload. We should be using the

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-16 Thread Jonathan Cameron
in FSYS_BLK. Cc: Jonathan Cameron ji...@kernel.org Cc: Kukjin Kim kgene@samsung.com Cc: Naveen Krishna Chatradhi Cc: linux-...@vger.kernel.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/iio/adc/exynos_adc.c | 54

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-16 Thread Jonathan Cameron
: Jonathan Cameron ji...@kernel.org Cc: Kukjin Kim kgene@samsung.com Cc: Naveen Krishna Chatradhi Cc: linux-...@vger.kernel.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/iio/adc/exynos_adc.c | 54

Re: [PATCH] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-12 Thread Jonathan Cameron
'sclk_tsadc' clock in FSYS_BLK. Cc: Jonathan Cameron ji...@kernel.org Cc: Kukjin Kim kgene@samsung.com Cc: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: linux-...@vger.kernel.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume

2013-05-22 Thread Jonathan Cameron
On 05/20/2013 06:09 PM, Doug Anderson wrote: Naveen, On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* - struct

Re: [PATCH 1/2] iio: adc: Kconfig: exynos_adc depends on CONFIG_OF

2013-03-17 Thread Jonathan Cameron
On 03/15/2013 06:09 PM, Doug Anderson wrote: Naveen, On Fri, Mar 15, 2013 at 9:23 AM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: As the exynos_adc driver only supports device tree registration. Making driver depend on CONFIG_OF solves possible errors during probe.

Re: [PATCH v7] iio: adc: add exynos adc driver under iio framwork

2013-03-03 Thread Jonathan Cameron
On 02/15/2013 01:35 PM, Naveen Krishna Ch wrote: On 15 February 2013 18:56, Lars-Peter Clausen l...@metafoo.de wrote: On 02/15/2013 02:17 PM, Naveen Krishna Ch wrote: On 15 February 2013 18:43, Lars-Peter Clausen l...@metafoo.de wrote: On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote:

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-26 Thread Jonathan Cameron
On 01/24/2013 04:58 AM, Naveen Krishna Chatradhi wrote: This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Just a quick general comment on patch