Re: [PATCH v3 5/7] drm/exynos: mixer: refactor layer setup

+Cc Boram Park, On 12/18/2015 12:54 AM, Marek Szyprowski wrote: > Hi Joonyoung, > > On 2015-12-17 05:19, Joonyoung Shim wrote: >> Hi Marek, >> >> On 12/16/2015 09:21 PM, Marek Szyprowski wrote: >>> Properly configure blending properties of given hardware l

Re: [PATCH v3 2/7] drm/exynos: make zpos property configurable

On 12/17/2015 10:05 PM, Marek Szyprowski wrote: > Hello, > > On 2015-12-17 03:55, Joonyoung Shim wrote: >> +Cc: Boram Park, >> >> Hi Marek, >> >> On 12/16/2015 09:21 PM, Marek Szyprowski wrote: >>> This patch adds all infrastructure to make zpo

Re: [PATCH v3 5/7] drm/exynos: mixer: refactor layer setup

Hi Marek, On 12/16/2015 09:21 PM, Marek Szyprowski wrote: > Properly configure blending properties of given hardware layer based on > the selected pixel format. Currently only per-pixel-based alpha is possible > when respective pixel format has been selected. Configuration of global, > per-plane

Re: [PATCH v3 2/7] drm/exynos: make zpos property configurable

+Cc: Boram Park, Hi Marek, On 12/16/2015 09:21 PM, Marek Szyprowski wrote: > This patch adds all infrastructure to make zpos plane property > configurable from userspace. > > Signed-off-by: Marek Szyprowski > --- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 ++- >

Re: drm/exynos: when to call dma_map_sg() on a GEM object?

On 10/31/2015 05:44 AM, Tobias Jakobi wrote: > Hey there, > > this question arose during some discussion with someone concerning the > Exynos mixer and G2D. > > The question is the following. Consider the Exynos mixer when run under > the IOMMU (that's sysmmu_tv IIRC). What exactly does setup

Re: [PATCH] drm/exynos/gem: remove DMA-mapping hacks used for constructing page array

Hi Marek, On 10/13/2015 07:22 PM, Marek Szyprowski wrote: > Exynos GEM objects contains an array of pointers to the pages, which the > allocated buffer consists of. Till now the code used some hacks (like > relying on DMA-mapping internal structures or using ARM-specific > dma_to_pfn helper) to

[PATCH] ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0. Signed-off-by: Joonyoung Shim <jy0922.s...@samsung.com> Cc: <sta...@vger.kernel.org> # v4.2 --- arch/arm/boot/dts/exynos5420.dtsi | 2 +- 1

[PATCH v2] ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

DMA mapping API on Odroid-XU3 board. Fixes: b70045167815 ("ARM: dts: add sysmmu nodes for exynos5420") Signed-off-by: Joonyoung Shim <jy0922.s...@samsung.com> Cc: <sta...@vger.kernel.org> # v4.2 Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes

[PATCH v2] rtc: s5m: fix to update ctrl register

-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org # v3.16 --- Changelog for v2: - update commit description and code to fix time keeping problem - update the stable tag with the kernel version drivers/rtc/rtc-s5m.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers

Re: [PATCH] rtc: s5m: fix to update ctrl register

On 08/21/2015 04:25 PM, Krzysztof Kozlowski wrote: On 21.08.2015 15:58, Joonyoung Shim wrote: On 08/21/2015 10:21 AM, Krzysztof Kozlowski wrote: On 21.08.2015 10:00, Joonyoung Shim wrote: On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: On 21.08.2015 08:15, Alexandre Belloni wrote: Hi

Re: [PATCH] rtc: s5m: fix to update ctrl register

On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: On 21.08.2015 08:15, Alexandre Belloni wrote: Hi, On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register

Re: drm/exynos: merge exynos_drm_buf.c to exynos_drm_gem.c

Hi, On 08/19/2015 05:35 PM, Dan Carpenter wrote: Hello Joonyoung Shim, The patch 2a8cb4894540: drm/exynos: merge exynos_drm_buf.c to exynos_drm_gem.c from Aug 16, 2015, leads to the following static checker warning: drivers/gpu/drm/exynos/exynos_drm_gem.c:610

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated. Hi, I cannot find this information in S2MPS14

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

On 08/13/2015 07:42 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 19:02, Krzysztof Kozlowski pisze: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: On 17.08.2015 10:47, Joonyoung Shim wrote: Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR

[PATCH] rtc: s5m: fix to update ctrl register

hour mode in Odroid-XU3 board. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org --- drivers/rtc/rtc-s5m.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 8c70d78..03828bb 100644 --- a/drivers/rtc/rtc

Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: On 11.08.2015 20:28, Joonyoung Shim wrote: The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so

[PATCH v2] rtc: s3c: fix disabled clocks for alarm

' argument having same value, so it needs to check whether clocks are enabled or not. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org # v4.1 --- This is v2 of prior patch [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm. Changelog for v2: - commit messages

[PATCH 1/4] rtc: s3c: add missing clk control

It's missed to call clk_unprepare() about info-rtc_src_clk in s3c_rtc_remove and to call clk_disable_unprepare about info-rtc_clk in error routine of s3c_rtc_probe. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

argument has same value, so it needs to check whether clocks is enabled or not. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c

[PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better to use them for consistency of code. Signed-off-by: Joonyoung Shim jy0922.s

[PATCH 2/4] rtc: s3c: remove unnecessary NULL assignment

It's unnecessary the code that assigns info-rtc_clk to NULL in s3c_rtc_remove. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index d1866a4..44b2921 100644

Re: [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

On 08/12/2015 09:28 AM, Krzysztof Kozlowski wrote: On 11.08.2015 20:28, Joonyoung Shim wrote: The clock enable/disable codes for alarm have removed from What do you mean in this paragraph? The clock code was removing something? 'commit 24e1455493da (drivers/rtc/rtc-s3c.c: delete duplicate

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

On 07/22/2015 05:22 PM, Inki Dae wrote: On 2015년 07월 22일 17:12, Joonyoung Shim wrote: On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux-next (next-20150721) encounters boot failures

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux-next (next-20150721) encounters boot failures on Exynos Octa (Exynos5422) based boards. The boards hangs. I bisected

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

d80167b85024982c5f18d0481a5c248100360118 Author: Joonyoung Shim jy0922.s...@samsung.com Date: Thu Jul 2 21:49:39 2015 +0900 drm/exynos: remove drm_iommu_attach_device_if_possible Already drm_iommu_attach_device checks whether support iommu internally. It should clear channels always regardless iommu

Re: [PATCH 0/7] drm/exynos/hdmi: refactoring/cleanup patches

changed, 245 insertions(+), 615 deletions(-) Looks good to me about this patchset, Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 00/23] drm/exynos: atomic improvements + exynos_encoder removal

and merged easier. 01-04 and 06-11 patches look good to me, about them, Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com v2: Fix comments by Joonyoung

Re: [PATCH v2 12/23] drm/exynos: don't track enabled state at exynos_crtc

On 07/10/2015 07:56 AM, Gustavo Padovan wrote: 2015-07-09 Joonyoung Shim jy0922.s...@samsung.com: +Cc Andrzej, On 07/07/2015 02:41 AM, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 11:20:13AM -0300, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct

Re: [PATCH v2 12/23] drm/exynos: don't track enabled state at exynos_crtc

+Cc Andrzej, On 07/07/2015 02:41 AM, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 11:20:13AM -0300, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct drm_crtc already stores the enabled state of the crtc thus we don't need to replicate enabled in

Re: [PATCH 19/23] drm/exynos: remove extra call to exynos_dp_commit()

Hi Hyungwon, On 07/02/2015 09:39 PM, Joonyoung Shim wrote: +Cc Hyungwon, On 06/24/2015 06:35 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk exynos_dp_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time

Re: [PATCH 02/23] drm/exynos: calculate vrefresh instead of use a fixed value

On 06/24/2015 06:35 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk When mode's vrefresh is zero we should ask DRM core to calculate vrefresh for us so we can get the correct value instead of relying on fixed value defined in a macro. But if vrefresh is still

Re: [PATCH 08/23] drm/exynos: pass struct exynos_drm_plane in update/enable

On 06/24/2015 06:35 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk We already have the plane pointer in before calling .update_plane() or disable_plane() so pass it directly to those calls avoiding a new conversion from zpos to struct exynos_drm_plane.

Re: [PATCH] drm/exynos: iommu: fix potential NULL pointer dereference

On 06/29/2015 03:35 PM, Hyungwon Hwang wrote: Dear Marek, On Thu, 25 Jun 2015 15:10:12 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Some drivers (like Exynos mixer) calls drm_iommu_attach_device_if_possible before registering crtc, so additional check for NULL crtc pointer is

Re: [PATCH 12/23] drm/exynos: don't track enabled state at exynos_crtc

On 06/24/2015 06:35 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct drm_crtc already stores the enabled state of the crtc thus we don't need to replicate enabled in exynos_drm_crtc. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[PATCH v2 3/3] drm/exynos: initialize VIDCON0 when fimd is disabled

is disabled, so it may continue display output of prior when clocks for fimd are enabled again. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH v2 2/3] drm/exynos: remove chained calls to enable

planes except to disable plane. Also it leads eliminable enabled and resume of struct exynos_drm_plane. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Marek Szyprowski m.szyprow...@samsung.com --- This patch

[PATCH v2 1/3] drm/exynos: remove to call mixer_wait_for_vblank

need to wait vblank anymore. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 6bab717..f93f038 100644

Re: [PATCH v10 00/17] drm/exynos: atomic modesetting support

On 06/11/2015 11:01 PM, Gustavo Padovan wrote: Hi Joonyoung, 2015-06-11 Joonyoung Shim jy0922.s...@samsung.com: On 06/10/2015 10:36 PM, Gustavo Padovan wrote: Hi Marek, 2015-06-10 Marek Szyprowski m.szyprow...@samsung.com: Hello, On 2015-06-01 17:04, Gustavo Padovan wrote: From

Re: [PATCH v10 00/17] drm/exynos: atomic modesetting support

On 06/10/2015 10:36 PM, Gustavo Padovan wrote: Hi Marek, 2015-06-10 Marek Szyprowski m.szyprow...@samsung.com: Hello, On 2015-06-01 17:04, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, Here goes the full support for atomic modesetting on exynos.

[PATCH] drm/exynos: remove chained calls to enable

touch planes except to disable plane. Also it leads eliminable enabled and resume of struct exynos_drm_plane. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- This patch was modified from original patch of Gustavo Padovan - http

Re: [PATCH 9/9] drm/exynos: unify exynos_drm_plane names with drm core

On 06/09/2015 11:27 PM, Gustavo Padovan wrote: Hi Inki and Joonyoung, Any comments on this series? I saw this series in brief and good mostly. I feel it can be better to split a atomic patch and cleanup patches, it can make to merge easier. It's problem to give late any feedback about

Re: [PATCH 2/9] drm/exynos: add atomic asynchronous commit

On 06/03/2015 11:30 PM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The atomic modesetting interfaces supports async commits that should be implemented by the drivers. If drm core requests an async commit exynos_atomic_commit() will schedule a work task to

Re: [PATCH v10 02/17] drm/exynos: use adjusted_mode of crtc_state instead of mode

-06-01 17:04, Gustavo Padovan wrote: From: Joonyoung Shim jy0922.s...@samsung.com Handle changes by removing copy from adjusted_mode to mode as using adjusted_mode of crtc_state. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4

Re: [PATCH v7 12/13] drm/exynos: atomic dpms support

On 05/30/2015 06:33 AM, Gustavo Padovan wrote: 2015-05-29 Joonyoung Shim jy0922.s...@samsung.com: On 05/29/2015 06:36 AM, Gustavo Padovan wrote: 2015-05-28 Joonyoung Shim jy0922.s...@samsung.com: On 05/28/2015 05:24 PM, Joonyoung Shim wrote: On 05/28/2015 02:39 PM, Inki Dae wrote: Hi

Re: [PATCH v9 16/18] drm/exynos: split exynos_crtc-dpms in enable() and disable()

On 05/29/2015 06:42 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk To follow more closely the new atomic API we split the dpms() helper into the enable() and disable() helper to get exactly the same semantics. Signed-off-by: Gustavo Padovan

Re: [PATCH v9 13/18] drm/exynos: add exynos specific .atomic_commit()

On 05/29/2015 06:42 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk exynos needs to update planes with the crtc enabled (mainly for the FIMD case) so this specific atomic commit changes the order of drm_atomic_helper_commit_modeset_enables() and

Re: [PATCH v7 12/13] drm/exynos: atomic dpms support

On 05/29/2015 06:36 AM, Gustavo Padovan wrote: 2015-05-28 Joonyoung Shim jy0922.s...@samsung.com: On 05/28/2015 05:24 PM, Joonyoung Shim wrote: On 05/28/2015 02:39 PM, Inki Dae wrote: Hi Gustavo, On 2015년 05월 28일 05:27, Gustavo Padovan wrote: Hi Inki, 2015-05-27 Inki Dae inki

Re: [PATCH v8 04/14] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

On 05/28/2015 05:24 PM, Joonyoung Shim wrote: On 05/28/2015 05:56 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The new atomic infrastructure needs the .mode_set_nofb() callback to update CRTC timings before setting any plane. Signed-off-by: Gustavo

Re: [PATCH v8 08/14] drm/exynos: atomic phase 3: use atomic .set_config helper

Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos

Re: [PATCH v8 02/14] drm/exynos: atomic phase 1: use drm_plane_helper_update()

planes. Update all users of exynos_update_plane() accordingly to call exynos_check_plane() before. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.dey --- drivers/gpu/drm

Re: [PATCH v7 12/13] drm/exynos: atomic dpms support

/disable v3: - Fix build failure after the hdmi change in v2 - Change dpms helper of ptn3460 bridge Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm

Re: [PATCH v7 12/13] drm/exynos: atomic dpms support

On 05/28/2015 05:24 PM, Joonyoung Shim wrote: On 05/28/2015 02:39 PM, Inki Dae wrote: Hi Gustavo, On 2015년 05월 28일 05:27, Gustavo Padovan wrote: Hi Inki, 2015-05-27 Inki Dae inki@samsung.com: Hi Gustavo, On 2015년 05월 23일 00:40, Gustavo Padovan wrote: From: Gustavo Padovan

Re: [PATCH v6 03/12] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

On 05/23/2015 12:33 AM, Gustavo Padovan wrote: Hi Joonyoung, 2015-05-22 Joonyoung Shim jy0922.s...@samsung.com: On 05/22/2015 05:02 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The new atomic infrastructure needs the .mode_set_nofb() callback

Re: [PATCH v7 02/13] drm/exynos: atomic phase 1: use drm_plane_helper_update()

planes. Update all users of exynos_update_plane() accordingly to call exynos_check_plane() before. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.dey --- drivers/gpu/drm

Re: [PATCH v7 12/13] drm/exynos: atomic dpms support

-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/bridge/ps8622.c | 2 +- drivers/gpu/drm/bridge/ptn3460.c| 2 +- drivers/gpu/drm

Re: [PATCH] ARM: dts: add exynos5422.dtsi to correct cpu order

Hi Chanho, On 05/28/2015 12:15 AM, Chanho Park wrote: The odroid-xu3 board which is based on exynos5422 not exynos5800 is booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are cortex-a15 cores. To correct

Re: [PATCH 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

On 05/06/2015 10:36 PM, Tobias Jakobi wrote: This analyses the current layer configuration (which layers are enabled, which have alpha-pixelformat, etc.) and setups blending accordingly. We currently disable all kinds of blending for the bottom-most layer, since configuration of the mixer

Re: [PATCH 1/5] drm/exynos: mixer: refactor layer setup

On 05/06/2015 10:36 PM, Tobias Jakobi wrote: First step in allowing a more generic way to setup complex blending for the different layers. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_mixer.c | 90 ++- 1

Re: [PATCH 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

On 05/06/2015 10:36 PM, Tobias Jakobi wrote: This updates the blending setup when the layer configuration changes (triggered by mixer_win_{commit,disable}). Extra care has to be taken for the layer that is currently being enabled/disabled. Signed-off-by: Tobias Jakobi

Re: [PATCH 0/5] drm/exynos: rework layer blending setup

Hi Tobias, On 05/22/2015 05:07 PM, Tobias Jakobi wrote: Hello Joonyoung, On 2015-05-22 06:04, Joonyoung Shim wrote: Hi Tobias, On 05/22/2015 05:44 AM, Tobias Jakobi wrote: Gentle reminder that I still haven't heard anything about the series by the Samsung guys ;) Sorry for late, i'm

Re: [PATCH v6 01/12] drm/exynos: atomic phase 1: use drm_plane_helper_update()

On 05/22/2015 05:02 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Rip out the check from exynos_update_plane() and create exynos_check_plane() for the check phase enabling use to use the atomic helpers to call our check and update phases when updating

Re: [PATCH 0/5] drm/exynos: rework layer blending setup

Hi Tobias, On 05/22/2015 05:44 AM, Tobias Jakobi wrote: Gentle reminder that I still haven't heard anything about the series by the Samsung guys ;) Sorry for late, i'm busy and i think whether it's possible any way for this blending from exynos drm framework after atomic feature of exynos

Re: [PATCH v6 00/12] drm/exynos: atomic modesetting support

(+), 264 deletions(-) I commented about some patches, looks good to me except them. Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v6 03/12] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

On 05/22/2015 05:02 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The new atomic infrastructure needs the .mode_set_nofb() callback to update CRTC timings before setting any plane. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

Re: [PATCH v6 09/12] drm/exynos: remove exported functions from exynos_drm_plane

On 05/22/2015 05:02 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that no one is using the functions exported by exynos_drm_plane due to the atomic conversion we can make remove some of the them or make them static. v2: remove unused exynos_drm_crtc

Re: [PATCH v6 04/12] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()

On 05/22/2015 05:02 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Set CRTC, planes and connectors to use the default implementations from the atomic helper library. The helpers will work to keep track of state for each DRM object. Signed-off-by: Gustavo

Re: drm/exynos: mixer blending and layer order

Hi Tobias, On 04/28/2015 09:58 PM, Tobias Jakobi wrote: Hello Joonyoung, On 2015-04-27 08:52, Joonyoung Shim wrote: Hi Tobias, On 04/24/2015 05:29 PM, Tobias Jakobi wrote: Hello Joonyoung, On 2015-04-24 04:13, Joonyoung Shim wrote: Hi Tobias, On 04/23/2015 09:28 PM, Tobias Jakobi

Re: [PATCH v2 1/4] drm/exynos: fb: use drm_format_num_planes to get buffer count

| 39 +- 1 file changed, 1 insertion(+), 38 deletions(-) Looks good to me about this series, Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 929cb03

Re: [PATCH v3] drm/exynos: mixer: cleanup pixelformat handling

because of compatibility reasons (suggested by Joonyoung Shim). Reviewed-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++-- 1 file changed, 23

Re: drm/exynos: mixer blending and layer order

Hi Tobias, On 04/24/2015 05:29 PM, Tobias Jakobi wrote: Hello Joonyoung, On 2015-04-24 04:13, Joonyoung Shim wrote: Hi Tobias, On 04/23/2015 09:28 PM, Tobias Jakobi wrote: Hello, I've noticed some inconsistency in what is currently exported as 'zpos' DRM propery to userspace

Re: [PATCH 1/2] drm/exynos: mixer: cleanup pixelformat handling

Hi Tobias, On 04/24/2015 05:10 PM, Tobias Jakobi wrote: On 2015-04-24 03:48, Joonyoung Shim wrote: Hi Tobias, On 04/23/2015 09:12 PM, Tobias Jakobi wrote: Move the defines for the pixelformats that the mixer supports out of mixer_graph_buffer() to the top of the source. Then select

Re: [PATCH 2/2] drm/exynos: mixer: remove buffer count handling in vp_video_buffer()

Hi Tobias, On 04/26/2015 05:31 AM, Tobias Jakobi wrote: The video processor (VP) supports four formats: NV12, NV21 and its tiled variants. All these formats are bi-planar, so the buffer count in vp_video_buffer() is always 2. While we're at it, also add support for NV21 and properly exit

Re: [PATCH v2 2/2] drm/exynos: cleanup exynos_drm_plane

local_path:1; - bool transparency:1; - bool activated:1; bool enabled:1; bool resume:1; }; Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 2/2] drm/exynos: cleanup exynos_drm_plane

:1; - bool local_path:1; - bool transparency:1; - bool activated:1; bool enabled:1; bool resume:1; }; Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 1/2] drm/exynos: mixer: cleanup pixelformat handling

Hi Tobias, On 04/23/2015 09:12 PM, Tobias Jakobi wrote: Move the defines for the pixelformats that the mixer supports out of mixer_graph_buffer() to the top of the source. Then select the mixer pixelformat (pf) in mixer_graph_buffer() based on the plane's pf (and not bpp). Also add handling

Re: drm/exynos: mixer blending and layer order

Hi Tobias, On 04/23/2015 09:28 PM, Tobias Jakobi wrote: Hello, I've noticed some inconsistency in what is currently exported as 'zpos' DRM propery to userspace. Currently we create three planes, where the zpos maps to the mixer 'win' (is this simply short for window?). But this is

Re: drm/exynos: getting the video processor to work

Hi Tobias, On 04/22/2015 11:56 PM, Tobias Jakobi wrote: Hello Inki, On 2015-04-22 16:26, Inki Dae wrote: Right. However, there is a case that we should consider for Exynos SoC. Exynos SoC has a Hardware video codec which is called MFC. This hardware can use a special function for

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

Hi Lukasz, On 04/17/2015 09:39 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 04/15/2015 08:05 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan

Re: drm/exynos: getting the video processor to work

Hi Tobias, On 04/21/2015 06:30 AM, Tobias Jakobi wrote: Hello, I've spend some time on figuring out how to use the VP on my Exynos4412. I noticed that currently it seems to be pretty broken (I've put a full crashlog with drm.debug=0xff at the end). As far as I can see, the problem stems

Re: [PATCH v2 2/2] drm/exynos: remove unused 'activated' field from exynos_drm_plane

Hi Tobias, On 04/16/2015 04:54 AM, Tobias Jakobi wrote: No component of Exynos DRM uses this field. Perhaps it was once meant to provide more fine-grained information in addition to the status stored in the 'enabled' field. Reviewed-by: Gustavo Padovan gustavo.pado...@collabora.co.uk

Re: [PATCH 3/3] drm/exynos: enable/disable blend based on pixel format

Hi Gustavo, On 03/19/2015 11:27 PM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Change the switch to use the pixel_format instead of bpp to figure out if we need to enable or disable the layer blending. The default concept is ok about enable or disable of

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

Hi Lukasz, On 04/15/2015 08:05 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote: Hi Lukasz, On Thu, Jan 22, 2015 at 2:31 PM, Lukasz Majewski

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote: Hi Lukasz, On Thu, Jan 22, 2015 at 2:31 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Abhilash, Hi Lukasz, On Mon, Jan 19, 2015 at

Re: [PATCH] drm/exynos: remove unnecessary calls to disable_plane()

Hi, On 04/11/2015 03:57 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The planes are already disabled by the drm_atomic_helper_commit() code so we don't need to disable the in these two places. Signed-off-by: Gustavo Padovan

Re: [PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

Hi, On 04/09/2015 12:14 AM, Inki Dae wrote: On 2015년 04월 08일 03:39, Gustavo Padovan wrote: Hi Inki, 2015-04-07 Inki Dae inki@samsung.com: On 2015년 04월 07일 00:44, Inki Dae wrote: 2015-04-06 19:46 GMT+09:00 Inki Dae inki@samsung.com: On 2015년 04월 04일 03:09, Gustavo Padovan wrote:

Re: [PATCH -v3 11/11] drm/exynos: atomic dpms support

to apply this patchset. Anyway, i just tested it from hdmi output part on odroid-xu3 board. Tested-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. Please, keep in mind that you should build it and at least have a basic test before posting. Sure, I think this happened because I've been

Re: [PATCH v2 2/3] drm/exynos: remove superfluous error messages

; - } } ret = drm_framebuffer_init(dev, exynos_fb-fb, exynos_drm_fb_funcs); Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 1/3] drm/exynos: fix typos in hdmi and mixer

(0 2) -#define MXR_CFG_SCAN_PROGRASSIVE (1 2) +#define MXR_CFG_SCAN_PROGRESSIVE (1 2) #define MXR_CFG_SCAN_NTSC(0 1) #define MXR_CFG_SCAN_PAL (1 1) #define MXR_CFG_SCAN_SD (0 0) Acked-by: Joonyoung Shim jy0922.s...@samsung.com

Re: [PATCH v2 3/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer

got errors when crtc gets out bound of actual screen area. I sent patch to fix it and to calculate ratio from exynos_drm plane codes. Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 10/10] drm/exynos: atomic dpms support

Hi, diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index e71e331..e0b085b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -275,9 +275,6 @@ int exynos_drm_fbdev_init(struct

Re: [PATCH 10/10] drm/exynos: atomic dpms support

Hi, On 03/31/2015 04:11 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Run dpms operations through the atomic intefaces. This basically removes the .dpms() callback from econders and crtcs and use .disable() and .enable() to turn the crtc on and off.

Re: [PATCH 09/10] drm/exynos: remove exported functions from exynos_drm_plane

Hi, On 03/28/2015 12:58 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that no one is using the functions exported by exynos_drm_plane due to the atomic conversion we can make remove some of the them or make them static. Signed-off-by: Gustavo

Re: [PATCH -v2 0/8] drm/exynos: clean up patches (preparing for atomic)

Hi, On 03/26/2015 11:10 PM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, Here goes some clean ups to the exynos drivers. The main clean ups is the presetting and zpos making the property immutable and the removal of *_win_data structures. v2

Re: [PATCH -v2 3/8] drm/exynos: remove struct *_win_data abstraction on planes

Hi, On 03/26/2015 11:10 PM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct {fimd,mixer,vidi}_win_data was just keeping the same data as struct exynos_drm_plane thus get ride of it and use exynos_drm_plane directly. It changes how planes are created

Re: [PATCH 04/15] tests/exynos: disable the G2D userptr/blend test

Hi, On 02/11/2015 10:39 AM, Tobias Jakobi wrote: Hello Joonyoung! Joonyoung Shim wrote: Hi, On 02/03/2015 10:53 PM, Tobias Jakobi wrote: The blend test uses the userptr functionality of exynos-drm, which is currently not safe to use. If the kernel hasn't been build with exynos-iommu

Re: [libdrm] improvements to userspace exynos component

-by: Joonyoung Shim jy0922.s...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/15] tests/exynos: disable the G2D userptr/blend test

Hi, On 02/03/2015 10:53 PM, Tobias Jakobi wrote: The blend test uses the userptr functionality of exynos-drm, which is currently not safe to use. If the kernel hasn't been build with exynos-iommu support, then the blend test is going to produce (kernel) memory corruption, eventually leading

Re: [PATCH 4/4] drm/exynos: remove checks for zpos == -1 on primary planes

Hi, On 02/06/2015 02:59 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk The primary plane default zpos is now 0, so remove checks for zpos == -1. We don't need to set win to 0 anymore it is already zero. Could you also remove DEFAULT_ZPOS define? And zpos

Re: [PATCH 2/4] drm/exynos: preset zpos value for overlay planes

Hi, On 02/06/2015 02:59 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Usually userspace don't want to have two overlay planes on the same zpos so this change assign a different zpos for each plane. Before this change a zpos of value zero was created for

  1   2   3   >