Re: [PATCH v6 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-12 Thread Kishon Vijay Abraham I
Hi, On Saturday 10 October 2015 09:25 PM, Yakir Yang wrote: > This phy driver would control the Rockchip DisplayPort module > phy clock and phy power, it is relate to analogix_dp-rockchip > dp driver. If you want DP works rightly on rockchip platform, > then you should select both of them. Add

Re: [PATCH v6 11/17] Documentation: phy: add document for rockchip dp phy

2015-10-12 Thread Kishon Vijay Abraham I
Hi, On Saturday 10 October 2015 09:28 PM, Yakir Yang wrote: > This phy driver is binded with the Rockchip DisplayPort > driver, here are the brief properties: > edp_phy: edp-phy@ff770274 { > compatible = "rockchip,rk3288-dp-phy"; > rockchip,grf = <>; >

Re: [PATCH RESEND] phy: exynos-usb2: add vbus regulator support

2015-10-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 06 October 2015 07:39 PM, Marek Szyprowski wrote: > Hello, > > On 2015-10-06 15:47, Krzysztof Kozlowski wrote: >> 2015-10-06 22:41 GMT+09:00 Marek Szyprowski : >>> Exynos USB2 PHY has separate power supply, which is usually provided by >>> VBUS regulator.

Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support

2015-08-27 Thread Kishon Vijay Abraham I
Hi, On Tuesday 25 August 2015 11:42 AM, Krzysztof Kozlowski wrote: On 25.08.2015 14:47, Marek Szyprowski wrote: Hello, On 2015-08-21 14:44, Kishon Vijay Abraham I wrote: On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote: Exynos USB2 PHY has separate power supply, which is usually

Re: [PATCH v3 08/14] phy: Add driver for rockchip Display Port PHY

2015-08-19 Thread Kishon Vijay Abraham I
Hi, On Wednesday 19 August 2015 08:21 PM, Yakir Yang wrote: Signed-off-by: Yakir Yang y...@rock-chips.com where's the commit message? --- Changes in v3: - Take Heiko suggest, add rockchip dp phy driver, collect the phy clocks and power control. Changes in v2: None

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-06-01 Thread Kishon Vijay Abraham I
Hi, On Friday 29 May 2015 08:34 PM, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote: Hi Felipe, On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: Hi On 15-05-26 07:19 AM

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Kishon Vijay Abraham I
Hi Felipe, On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: Hi On 15-05-26 07:19 AM, Felipe Balbi wrote: HI, On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote: On 15-05-14 05:52 PM, Felipe Balbi wrote:

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Kishon Vijay Abraham I
Tejun, Maxime, Sylwester, Kyungmin On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: Most of the phy providers use select to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GENERIC_PHY is changed an invisible option. To maintain consistency, all phy

Re: [PATCH RESEND] phy: exynos5-usbdrd: Add to support for Exynos5433 SoC

2015-03-30 Thread Kishon Vijay Abraham I
On Tuesday 31 March 2015 10:36 AM, Jaewon Kim wrote: Hi Kishon. Could you check my patch?? sure.. patch looks fine. will queue it. -Kishon On 26/03/2015 14:16, Vivek Gautam wrote: On Thu, Mar 26, 2015 at 7:48 AM, Jaewon Kim jaewon02@samsung.com wrote: This patch adds driver data to

Re: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

2015-03-11 Thread Kishon Vijay Abraham I
On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote: Remove the second lock on non-regmap path. Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations) Reported-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Axel Lin axel@ingics.com

Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations

2015-03-04 Thread Kishon Vijay Abraham I
Hi, On Friday 27 February 2015 06:57 PM, Sylwester Nawrocki wrote: On 27/02/15 04:50, Axel Lin wrote: he state-regmap is initialized by devm_regmap_init_mmio(). So it's fine to use spin_lock rather than mutex to protct state-regmap rmw operations. Signed-off-by: Axel Lin axel@ingics.com

Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations

2015-03-04 Thread Kishon Vijay Abraham I
On Wednesday 04 March 2015 06:17 PM, Sylwester Nawrocki wrote: Hi, On 04/03/15 13:24, Kishon Vijay Abraham I wrote: This patch doesn't apply on 4.0-rc1. Can to refresh it to mainline latest? It depends on Axel's previous patch: phy: exynos-mipi-video: Fixup the test for state-regmap

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-22 Thread Kishon Vijay Abraham I
On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: The series has dependency on a) [PATCH v7 0/7] Enable support for Samsung Exynos7 SoC http://www.spinics.net/lists/linux-samsung-soc/msg38734.html b) [GIT PULL] Samsung

Re: [PATCH v2 2/4] phy: exynos5-usbdrd: Add pipe-clk and utmi-clk support

2014-10-22 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 October 2014 03:49 PM, Vivek Gautam wrote: Exynos7 SoC has now separate gate control for 125MHz pipe3 phy clock, as well as 60MHz utmi phy clock. So get the same and control in the phy-exynos5-usbdrd driver. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com ---

Re: [PATCH 4/5] Phy: Remove .owner field for driver

2014-09-24 Thread Kishon Vijay Abraham I
Hi, On Wednesday 24 September 2014 03:19 PM, Kiran Padwal wrote: There is no need to init .owner field. Based on the patch from Peter Griffin peter.grif...@linaro.org mmc: remove .owner field for drivers using module_platform_driver he has sent a patch for phy too and it's already been

Re: [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver

2014-09-17 Thread Kishon Vijay Abraham I
Hi, On Friday 15 August 2014 06:10 PM, Peter Griffin wrote: This patch removes the superflous .owner field for drivers which use the module_platform_driver or platform_driver_register api, as this is overriden in __platform_driver_register. Signed-off-by: Peter Griffin

Re: [PATCH v3 1/3] phy: exynos-dp-video: Use syscon support to control pmu register

2014-09-17 Thread Kishon Vijay Abraham I
@samsung.com Cc: Kishon Vijay Abraham I kis...@ti.com Taking this in linux-phy tree. If someone has already taken this patch, please let me know. Thanks Kishon --- Changes since v2: - Using 'EXYNOS5_PHY_ENABLE' macro instead of 'EXYNOS_DPTX_PHY_ENABLE' since that's available with us

Re: [PATCH 7/9] phy: remove .owner field for drivers using module_platform_driver

2014-09-17 Thread Kishon Vijay Abraham I
On Thursday 18 September 2014 12:34 AM, Peter Griffin wrote: Hi Kishon, On Wed, 17 Sep 2014, Kishon Vijay Abraham I wrote: Hi, On Friday 15 August 2014 06:10 PM, Peter Griffin wrote: This patch removes the superflous .owner field for drivers which use the module_platform_driver

Re: [PATCH v3 1/3] phy: exynos-dp-video: Use syscon support to control pmu register

2014-09-17 Thread Kishon Vijay Abraham I
On Thursday 18 September 2014 08:55 AM, Vivek Gautam wrote: Hi Kishon, On Wed, Sep 17, 2014 at 10:24 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Tuesday 16 September 2014 10:32 AM, Vivek Gautam wrote: Currently the DP_PHY_ENABLE register is mapped in the driver, and accessed

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 September 2014 01:26 PM, Vivek Gautam wrote: On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam gautam.vi...@samsung.com wrote: On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi ba...@ti.com wrote: On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: On Wed, Sep 10,

Re: [PATCH 0/9] phy: various misc cleanups to phy drivers

2014-08-20 Thread Kishon Vijay Abraham I
Hi, On Friday 15 August 2014 06:10 PM, Peter Griffin wrote: Hi, This series some a few misc cleanups to the PHY drivers: - 1) Use module_platform_driver to register spear PHY drivers. This gets rid of a lof of boiler plate code. 2) Remove .owner field from drivers using

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-20 Thread Kishon Vijay Abraham I
Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Kishon Vijay Abraham I kis...@ti.com One suggestion though would be to use git format-patch -D while deleting the file :-) Thanks Kishon --- drivers/usb/phy/Kconfig| 8 - drivers

Re: [PATCH 4/5] usb: phy: samsung: remove old USB 3.0 PHY driver

2014-08-20 Thread Kishon Vijay Abraham I
Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/phy/Kconfig| 8 - drivers/usb/phy/Makefile | 1 - drivers/usb/phy/phy-samsung-usb3.c | 350

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and USB gadget controller supported by the DWC2 gadget driver, make it depend on them and default to ARCH_EXYNOS as they are meant for Exynos platforms. Also, make the

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Kishon Vijay Abraham I
On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: Hi, On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and USB gadget controller

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Kishon Vijay Abraham I
On Monday 14 July 2014 02:36 PM, Sachin Kamat wrote: On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: Hi, On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09

[RFC PATCH 1/2] phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node

2014-07-04 Thread Kishon Vijay Abraham I
Fixed of_phy_provider_lookup to return 'phy_provider' if _of_phy_get passes the node pointer of the sub-node of phy provider node. This is needed when phy provider implements multiple PHYs and each PHY is modelled as the sub-node of PHY provider device node. Signed-off-by: Kishon Vijay Abraham I

[RFC PATCH 2/2] phy: core: the node pointer of PHY need not be the same as that of PHY provider

2014-07-04 Thread Kishon Vijay Abraham I
-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/phy.txt | 10 ++ drivers/phy/phy-bcm-kona-usb2.c |2 +- drivers/phy/phy-core.c | 25 ++--- drivers/phy/phy-exynos-dp-video.c |2 +- drivers/phy/phy-exynos-mipi-video.c

[RFC PATCH 0/2] phy: core: better support for multi-phy in phy-core

2014-07-04 Thread Kishon Vijay Abraham I
-dev.of_node*. (note that now phy-dev.of_node will have the node pointer of the sub-node). Kishon Vijay Abraham I (2): phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node phy: core: the node pointer of PHY need not be the same as that of PHY provider

Re: [PATCH] drivers: phy: exynos4x12-phy: Add missing MODULE_DEVICE_TABLE

2014-07-02 Thread Kishon Vijay Abraham I
Hi, On Wednesday 02 July 2014 01:18 PM, Sjoerd Simons wrote: Please add a commit log here describing what your patch does and why you need it. Cheers Kishon Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk --- drivers/phy/phy-samsung-usb2.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

2014-07-01 Thread Kishon Vijay Abraham I
Hi Kamil, On Tuesday 24 June 2014 06:24 PM, Kamil Debski wrote: The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-26 Thread Kishon Vijay Abraham I
configs to make things easier for the end user. While at it enable 5250 phy for Exynos 5420 SoC too. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Kishon Vijay Abraham I kis...@ti.com --- drivers/phy/Kconfig | 37 +++-- drivers/usb/host/Kconfig

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Kishon Vijay Abraham I
On Thursday 15 May 2014 07:05 PM, Rahul Sharma wrote: Hi, On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com Add exynos-simple-phy driver to

Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-13 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 May 2014 11:37 AM, Vivek Gautam wrote: Hi Kishon, On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Gautam, On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver

Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-12 Thread Kishon Vijay Abraham I
Hi Gautam, On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Also, created a new header file in

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-06 Thread Kishon Vijay Abraham I
On Wednesday 30 April 2014 08:54 AM, Vivek Gautam wrote: Hi Kishon, Tomasz, On Mon, Apr 28, 2014 at 11:47 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-05-05 Thread Kishon Vijay Abraham I
Hi, On Wednesday 09 April 2014 03:31 PM, Sylwester Nawrocki wrote: Hi, On 09/04/14 11:12, Rahul Sharma wrote: Idea looks good. How about keeping compatible which is independent of SoC, something like samsung,exynos-simple-phy and provide Reg and Bit through phy provider node. This way we

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-15 Thread Kishon Vijay Abraham I
Hi, On Monday 14 April 2014 07:19 PM, Tomasz Figa wrote: On 14.04.2014 15:40, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I kis

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-samsung-usb3 driver and

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: Hi, On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote

Re: [PATCH v10 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-07 Thread Kishon Vijay Abraham I
Tobias, On Saturday 08 March 2014 01:04 AM, Tobias Jakobi wrote: Kamil Debski wrote: Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kishon Vijay Abraham I
On Thursday 06 March 2014 01:56 PM, Anton Tikhomirov wrote: Hi Kamil, ... +| 3. Supporting SoCs ++ + +To support a new SoC a new file should be added to the drivers/phy +directory. Each SoC's configuration is stored in an instance of the +struct samsung_usb2_phy_config.

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 March 2014 02:22 PM, Anton Tikhomirov wrote: Hello, Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver On Thursday 06 March 2014 01:56 PM, Anton Tikhomirov wrote: Hi Kamil, ... +| 3. Supporting SoCs ++ + +To support a new SoC a new

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 March 2014 02:49 PM, Anton Tikhomirov wrote: Hi, Subject: RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver Hi, Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver Hi, On Thursday 06 March 2014 02:22 PM, Anton Tikhomirov wrote: Hello, Subject:

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 March 2014 03:54 PM, Kamil Debski wrote: Hi Anton, Kishon, From: Anton Tikhomirov [mailto:av.tikhomi...@samsung.com] Sent: Thursday, March 06, 2014 9:26 AM Hi Kamil, ... +| 3. Supporting SoCs ++ + +To support a new SoC a new file should be added to

Re: [PATCH v7 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 March 2014 08:53 PM, Kamil Debski wrote: Hi, This is the seventh version of this patchset. First and most significant change is that this patchset includes only patches touching the Generic PHY Framework. Patches to the USB controllers were stripped as they require additional

Re: [PATCH v8 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kishon Vijay Abraham I
Kamil, On Wednesday 05 March 2014 07:48 PM, Kamil Debski wrote: Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Pls fix these errors which I get while applying your patch.

Re: [PATCH v6 5/8] phy: Add new Exynos USB PHY driver

2014-03-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 29 January 2014 10:59 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Can the PHY part of this series be merged independently of the

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-10 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 February 2014 07:37 PM, Tomasz Figa wrote: Hi Vivek, This patch is just adding the PHY driver. I would also like to look at some users of it, to see how this works when put together. For now, please see my comments inline. On 20.01.2014 14:42, Vivek Gautam wrote:

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Kishon Vijay Abraham I
Hi, On Thursday 30 January 2014 09:49 AM, Vivek Gautam wrote: Hi Kishon, On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, Thanks for review. Please find my answers inline below. On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: Add a new driver

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-27 Thread Kishon Vijay Abraham I
Hi, On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-samsung-usb3 driver and

Re: [PATCH 2/5] phy: add support for indexed lookup

2014-01-15 Thread Kishon Vijay Abraham I
Hi Heikki, On Tuesday 14 January 2014 07:53 PM, Heikki Krogerus wrote: Hi Kishon, And happy new year.. Happy new year :-) On Tue, Jan 07, 2014 at 07:10:36PM +0530, Kishon Vijay Abraham I wrote: /** - * phy_get() - lookup and obtain a reference to a phy. + * phy_get_index() - obtain

Re: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy

2014-01-15 Thread Kishon Vijay Abraham I
Hi, On Tuesday 14 January 2014 08:08 PM, Heikki Krogerus wrote: On Tue, Jan 07, 2014 at 06:31:52PM +0530, Kishon Vijay Abraham I wrote: In any case, having two device names to deal with does not add any more risk. These associations should always be made in the place where the phy device

Re: [PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-08 Thread Kishon Vijay Abraham I
Hi, On Wednesday 08 January 2014 11:26 PM, Kamil Debski wrote: Hi, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Monday, January 06, 2014 11:12 AM Hi, On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Add a new driver for the Exynos USB 2.0 PHY. The new driver uses

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-07 Thread Kishon Vijay Abraham I
Hi, On Monday 30 December 2013 03:13 PM, Vivek Gautam wrote: Hi Kishon, On Tue, Dec 24, 2013 at 11:15 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Thursday 05 December 2013 01:44 PM, Vivek Gautam wrote: Hi Kishon, On Wed, Dec 4, 2013 at 7:58 PM, Kishon Vijay Abraham I

Re: [PATCH 4/5] arm: omap3: twl: use the new lookup method with usb phy

2014-01-07 Thread Kishon Vijay Abraham I
Hi, On Monday 16 December 2013 08:13 PM, Heikki Krogerus wrote: Hi, On Mon, Dec 16, 2013 at 04:34:35PM +0530, Kishon Vijay Abraham I wrote: On Monday 09 December 2013 08:38 PM, Heikki Krogerus wrote: Provide a complete association for the phy and it's user (musb) with the new

Re: [PATCH 2/5] phy: add support for indexed lookup

2014-01-07 Thread Kishon Vijay Abraham I
Hi, On Monday 16 December 2013 08:02 PM, Heikki Krogerus wrote: Hi Kishon, On Mon, Dec 16, 2013 at 04:32:58PM +0530, Kishon Vijay Abraham I wrote: On Monday 09 December 2013 08:38 PM, Heikki Krogerus wrote: Removes the need for the consumer drivers requesting the phys to provide name

Re: [PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-06 Thread Kishon Vijay Abraham I
Hi, On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by:

Re: [PATCH RFC alternative ver 1] phy: Exynos 421x USB 2.0 PHY support

2014-01-06 Thread Kishon Vijay Abraham I
Hi, On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: This the alternative version of the support for Exynos 421x USB 2.0 PHY in the Generic PHY framework. In this version the support for Exynos 4210 and 4212 was joined into one file. Signed-off-by: Kamil Debski k.deb...@samsung.com ---

Re: [PATCH v4 1/9] phy: core: Add an exported of_phy_get function

2014-01-05 Thread Kishon Vijay Abraham I
Hi, On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to

Re: [PATCH v4 2/9] phy: core: Add devm_of_phy_get to phy-core

2014-01-05 Thread Kishon Vijay Abraham I
On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++

Re: [PATCH v5 0/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-02 Thread Kishon Vijay Abraham I
Hi Kamil, On Thursday 02 January 2014 09:50 PM, Kamil Debski wrote: Hi Kishon, I wanted to ask about your comments to this patchset. As I mentioned there are two alternative version where the Exynos 4210 and 4212 support is merged in one file. I would be grateful if you had some time to look

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-24 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 01:44 PM, Vivek Gautam wrote: Hi Kishon, On Wed, Dec 4, 2013 at 7:58 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Vivek, On Wednesday 20 November 2013 09:14 PM, Kishon Vijay Abraham I wrote: Hi, On Wednesday 20 November 2013 03:02 PM, Vivek Gautam

Re: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kishon Vijay Abraham I
On Friday 13 December 2013 08:56 PM, Kamil Debski wrote: Hi Kishon, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 13, 2013 3:45 PM Hi, On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device

Re: [PATCH 2/5] phy: add support for indexed lookup

2013-12-16 Thread Kishon Vijay Abraham I
Hi, On Monday 09 December 2013 08:38 PM, Heikki Krogerus wrote: Removes the need for the consumer drivers requesting the phys to provide name for the phy. This should ease the use of the framework considerable when using only one phy, which is usually the case when except with USB, but it can

Re: [PATCH v3 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-16 Thread Kishon Vijay Abraham I
On Monday 16 December 2013 06:22 PM, Kamil Debski wrote: Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++

Re: [PATCH] phy: Add exynos-phy driver

2013-12-13 Thread Kishon Vijay Abraham I
Hi, On Wednesday 11 December 2013 03:46 PM, Sylwester Nawrocki wrote: On 11/12/13 10:54, Kishon Vijay Abraham I wrote: On Wednesday 27 November 2013 06:56 PM, Tomasz Stanislawski wrote: Hello everyone, The Samsung SoCs from Exynos family are enhanced with a bunch of switches dedicated for IP

Re: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kishon Vijay Abraham I
Hi, On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: Some PHY controllers may need to tune

Re: [PATCH] phy: Add exynos-phy driver

2013-12-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 27 November 2013 06:56 PM, Tomasz Stanislawski wrote: Hello everyone, The Samsung SoCs from Exynos family are enhanced with a bunch of switches dedicated for IP blocks. Those switches are called PHYs in Exynos specification. They are usually controlled by a single bit in a

Re: [PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-08 Thread Kishon Vijay Abraham I
On Friday 06 December 2013 04:22 PM, Kamil Debski wrote: Hi, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 06, 2013 6:31 AM Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared

Re: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-08 Thread Kishon Vijay Abraham I
Hi, On Friday 06 December 2013 09:58 PM, Kamil Debski wrote: Hi Kishon, Thank you for the review. From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 06, 2013 11:59 AM Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Add a new driver for the Exynos USB

Re: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by:

Re: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Change the used phy driver to the new Exynos USB phy driver that uses the generic phy framework. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v4 6/9] phy: Add support for S5PV210 to the Exynos USB PHY driver

2013-12-06 Thread Kishon Vijay Abraham I
Hi, On Friday 06 December 2013 04:01 PM, Kamil Debski wrote: From: Mateusz Krawczuk mat.krawc...@gmail.com Add support for the Samsung's S5PV210 SoC to the Exynos USB PHY driver. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com [k.deb...@samsung.com: cleanup and commit

Re: [PATCH v4 7/9] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2013-12-06 Thread Kishon Vijay Abraham I
On Friday 06 December 2013 04:02 PM, Kamil Debski wrote: Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v4 0/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-05 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Hi, This is the fourth version of the patchset adding the new Exynos USB 2.0 PHY driver. The driver uses the Generic PHY Framework. A month has passed since the last version. I have addressed numerous comments that appeared

Re: [PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-05 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined It was never intended to be called from other

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-04 Thread Kishon Vijay Abraham I
Hi Vivek, On Wednesday 20 November 2013 09:14 PM, Kishon Vijay Abraham I wrote: Hi, On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote: On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: Hi

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Kishon Vijay Abraham I
On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, sorry for the delayed response. On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: On Wednesday, November 06, 2013 2:58 AM

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote: On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I kis...@ti.com wrote

Re: [PATCH 2/3] Phy: Exynos: Add Exynos5250 sata phy driver

2013-11-19 Thread Kishon Vijay Abraham I
On Friday 15 November 2013 11:17 AM, Yuvaraj Kumar wrote: On Thu, Nov 14, 2013 at 11:18 AM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 07 October 2013 07:35 PM, Yuvaraj Cd wrote: On Tue, Oct 1, 2013 at 6:21 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Tuesday 01

Re: [PATCH 2/3] Phy: Exynos: Add Exynos5250 sata phy driver

2013-11-19 Thread Kishon Vijay Abraham I
On Tuesday 19 November 2013 03:42 PM, Yuvaraj Kumar wrote: On Tue, Nov 19, 2013 at 3:22 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Friday 15 November 2013 11:17 AM, Yuvaraj Kumar wrote: On Thu, Nov 14, 2013 at 11:18 AM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 07

Re: [PATCH 2/3] Phy: Exynos: Add Exynos5250 sata phy driver

2013-11-13 Thread Kishon Vijay Abraham I
Hi, On Monday 07 October 2013 07:35 PM, Yuvaraj Cd wrote: On Tue, Oct 1, 2013 at 6:21 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Tuesday 01 October 2013 12:03 PM, Yuvaraj Kumar C D wrote: This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: On Wednesday, November 06, 2013 2:58 AM, Vivek Gautam wrote: On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han jg1@samsung.com wrote: [.] USB3.0 PHY consists of two blocks such as 3.0 block and 2.0 block. This USB3.0 PHY can

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Kishon Vijay Abraham I
On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote: Hi Kishon, On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Kishon Vijay Abraham I
Hi, On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: Hi Kishon, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Monday, November 04, 2013 7:55 AM Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-03 Thread Kishon Vijay Abraham I
Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. In Exynos, you have a single IP that

Re: [RFC 04/12] phy: Add simple-phy driver

2013-11-03 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 01:21 PM, Tomasz Stanislawski wrote: Hi, Please refer to the comments below. On 10/24/2013 05:52 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 21 October 2013 07:48 PM, Tomasz Stanislawski wrote: Add simple-phy driver to support a single register PHY

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-29 Thread Kishon Vijay Abraham I
Hi, On Monday 28 October 2013 07:22 PM, Kamil Debski wrote: Hi Kishon, Thank you for your review! I will answer your comments below. From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, October 25, 2013 5:40 PM Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote

Re: [RFC PATCH 2/5] phy: Add WIP Exynos 5250 support to the Exynos USB PHY driver

2013-10-29 Thread Kishon Vijay Abraham I
Hi, On Monday 28 October 2013 08:11 PM, Vivek Gautam wrote: Hi Kishon, On Fri, Oct 25, 2013 at 9:13 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: Add support for Exynos 5250. This is work-in-progress commit. Not for merging

Re: [RFC PATCH 2/5] phy: Add WIP Exynos 5250 support to the Exynos USB PHY driver

2013-10-29 Thread Kishon Vijay Abraham I
Hi, On Tuesday 29 October 2013 03:44 PM, Kamil Debski wrote: Hi, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Tuesday, October 29, 2013 10:55 AM Hi, On Monday 28 October 2013 08:11 PM, Vivek Gautam wrote: Hi Kishon, On Fri, Oct 25, 2013 at 9:13 PM, Kishon Vijay Abraham I

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-25 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by:

Re: [RFC PATCH 2/5] phy: Add WIP Exynos 5250 support to the Exynos USB PHY driver

2013-10-25 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: Add support for Exynos 5250. This is work-in-progress commit. Not for merging. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/phy/Kconfig |7 +

Re: [PATCH 3/5] phy: Add support for S5PV210 to the Exynos USB PHY driver

2013-10-25 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: From: Mateusz Krawczuk m.krawc...@partner.samsung.com Add support for the Samsung's S5PV210 SoC to the Exynos USB PHY driver. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com [k.deb...@samsung.com: whitespace

Re: [PATCH 4/5] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-10-25 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. looks good :-) Thanks Kishon Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park

  1   2   3   >