Re: [PATCH 4/5] thermal: exynos: Remove unneeded semicolon

2015-11-04 Thread Lukasz Majewski
u_probe(struct > platform_device *pdev) break; > default: > break; > - }; > + } > > /* >* data->tzd must be registered before calling > exynos_tmu_initialize(), Acked-by: Lukasz Majewski <l.majew...@samsung.com> Tested-by: Lukasz M

Re: [PATCH 1/5] thermal: exynos: Fix unbalanced regulator disable on probe failure

2015-11-04 Thread Lukasz Majewski
; >>> } > >>> + > >>> + /* > >>> +* Try enabling the regulator if found > >>> + * TODO: Add regulator as an SOC feature, so that > >>> regulator enable > >>> + * is a compulsory call. >

Re: [PATCH 5/5] thermal: exynos: Directly return 0 instead of using local ret variable

2015-11-04 Thread Lukasz Majewski
static int exynos7_tmu_initialize(struct platform_device *pdev) > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-samsung-soc" in the body of a message to > > majord...@vger.kernel.org More majordomo i

Re: [PATCH 3/5] thermal: exynos: Use IS_ERR() because regulator cannot be NULL

2015-11-04 Thread Lukasz Majewski
tor); > > > > return ret; > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-samsung-soc" in the body of a message to > > majord...@vger.kernel.org More majordomo info at >

Re: [PATCH 2/5] thermal: exynos: Fix first temperature read after registering sensor

2015-11-04 Thread Lukasz Majewski
dev_err(>dev, "Failed to request irq: %d\n", > > data->irq); > > - goto err_sclk; > > + goto err_thermal; > > } > > > > exynos_tmu_control(pdev, true); > > return 0; > > + > > +err_the

Re: [PATCH] thermal: exynos: fix register read in TMU

2015-10-09 Thread Lukasz Majewski
YNOS_EMUL_CON. > >> > >> Indeed! > >> > >> Fixes: 488c7455d74c ("thermal: exynos: Add the support for > >> Exynos5433 TMU") > >> > >> Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > > > > Hi Krzy

[PATCH RESEND v6 1/3] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-08-11 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- .../devicetree/bindings/hwmon/pwm-fan.txt | 29

[PATCH RESEND v6 0/3] dts: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-08-11 Thread Lukasz Majewski
: 366c21fdd7b1e71a47a6fa969f2e9a014c981aff Kamil Debski (1): ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski (2): Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

[PATCH RESEND v6 2/3] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-08-11 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Lukasz Majewski l.majew

[PATCH RESEND v6 3/3] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-08-11 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 33 ++- 1 file

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Lukasz Majewski
-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] thermal: exynos: Disable the regulator on probe failure

2015-07-06 Thread Lukasz Majewski
Hi Krzysztof, 2015-06-09 1:14 GMT+09:00 Lukasz Majewski l.majew...@samsung.com: Hi Krzysztof, During probe the regulator (if present) was enabled but not disabled in case of failure. So an unsuccessful probe lead to enabling the regulator which was actually not needed because

Re: [PATCH 0/2] thermal: exynos: Fix minor issue

2015-07-06 Thread Lukasz Majewski
to platform_data on probe() drivers/thermal/samsung/Kconfig | 2 +- drivers/thermal/samsung/exynos_tmu.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) Thanks for your work. Applied to my tree: linux-samusng-thermal/fixes -- Best regards, Lukasz Majewski Samsung RD

Re: [PATCH] thermal: exynos: Disable the regulator on probe failure

2015-07-06 Thread Lukasz Majewski
Hi Krzysztof, 2015-06-09 1:14 GMT+09:00 Lukasz Majewski l.majew...@samsung.com: Hi Krzysztof, During probe the regulator (if present) was enabled but not disabled in case of failure. So an unsuccessful probe lead to enabling the regulator which was actually not needed because

Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match.

2015-06-09 Thread Lukasz Majewski
Hi Rafael, On Monday, June 08, 2015 10:31:00 AM Lukasz Majewski wrote: Hi Viresh, On 25-05-15, 07:39, Shailendra Verma wrote: During probe free the memory allocated to exynos_info in case of unknown SOC type. Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com

Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match.

2015-06-08 Thread Lukasz Majewski
platform_driver exynos_cpufreq_platdrv = { Acked-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3

2015-06-08 Thread Lukasz Majewski
+CONFIG_LEDS_PWM=m +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_TIMER=m +CONFIG_LEDS_TRIGGER_HEARTBEAT=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_MAX77802=y Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL

Re: [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3

2015-06-08 Thread Lukasz Majewski
=y CONFIG_SND_SOC_SNOW=y +CONFIG_SND_SOC_ODROIDX2=y +CONFIG_SND_SIMPLE_CARD=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_XHCI_HCD=y Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform

Re: [PATCH] thermal: exynos: Disable the regulator on probe failure

2015-06-08 Thread Lukasz Majewski
: if (!IS_ERR(data-clk_sec)) clk_unprepare(data-clk_sec); err_sensor: + if (!IS_ERR_OR_NULL(data-regulator)) + regulator_disable(data-regulator); thermal_zone_of_sensor_unregister(pdev-dev, data-tzd); return ret; Acked-by: Lukasz Majewski l.majew

Re: [PATCH v2] thermal: exynos: Add the support for Exynos5433 TMU

2015-04-28 Thread Lukasz Majewski
Hi Chanwoo, Hi Eduardo and Lukasz, I checked this patch merged on linux-next.git. But, this patch is not merged on Linux 4.1-rc1. This is indeed strange. Eduardo do you have any idea why this patch is missing? Thanks, Chanwoo Choi On 03/18/2015 04:39 PM, Lukasz Majewski wrote: Hi

Re: [PATCH 1/8] cpufreq: arm_big_little: add cluster regulator support

2015-04-22 Thread Lukasz Majewski
()) per_cpu(cpu_last_req_freq, policy-cpu) = clk_get_cpu_rate(policy-cpu); Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 2/8] ARM: dts: add cluster regulator supply properties for exynos5422-odroidxu3

2015-04-22 Thread Lukasz Majewski
-cluster.0-supply = buck2_reg; +}; + +cpu4 { + cpu-cluster.1-supply = buck6_reg; +}; + i2c_0 { status = okay; Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from

Re: [PATCH 5/8] ARM: Exynos: use generic cpufreq driver for Exynos5420

2015-04-22 Thread Lukasz Majewski
stress testing (observed on ODROID-XU3 board). + */ +#ifndef CONFIG_BL_SWITCHER + { .compatible = samsung,exynos5420, .data = arm-bL-cpufreq-dt }, +#endif { /* sentinel */ } }; Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD

Re: [PATCH 6/8] clk: samsung: exynos5800: fix cpu clock configuration data

2015-04-22 Thread Lukasz Majewski
, exynos5420_kfcclk_d, ARRAY_SIZE(exynos5420_kfcclk_d), 0); Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 4/8] ARM: dts: Exynos5420: add CPU OPP and regulator supply property

2015-04-22 Thread Lukasz Majewski
; }; }; Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/8] clk: samsung: exynos5420: add cpu clock configuration data and instantiate cpu clock

2015-04-22 Thread Lukasz Majewski
/* gate for special clocks (sclk) */ #define CLK_SCLK_UART0 128 Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

2015-04-22 Thread Lukasz Majewski
Hi Joonyoung, Hi Lukasz, On 04/17/2015 09:39 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 04/15/2015 08:05 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

2015-04-17 Thread Lukasz Majewski
Hi Joonyoung, Hi Lukasz, On 04/15/2015 08:05 PM, Lukasz Majewski wrote: Hi Joonyoung, Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote: Hi Lukasz, On Thu, Jan 22, 2015 at 2

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

2015-04-15 Thread Lukasz Majewski
Hi Joonyoung, Hi Lukasz, On 01/30/2015 05:14 PM, Lukasz Majewski wrote: Hi Eduardo, Abhilash, On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote: Hi Lukasz, On Thu, Jan 22, 2015 at 2:31 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Abhilash, Hi Lukasz

Re: [PATCH 4/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base.

2015-04-08 Thread Lukasz Majewski
. However please consider my comment to the previous patch. Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH 5/6] pwm: samsung: Fix output race on disabling

2015-04-08 Thread Lukasz Majewski
); + pwm_samsung_manual_update(our_chip, pwm); + } + chan-period_ns = period_ns; chan-tin_ns = tin_ns; chan-duty_ns = duty_ns; Despite the above, Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group

Re: [PATCH 2/6] ARM: dts exynos5420 update the cooling cells for core cpu0

2015-04-08 Thread Lukasz Majewski
by max */ }; cpu1: cpu@1 { Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0

2015-04-08 Thread Lukasz Majewski
temperatures (both exynos5 and exynos4). I will try to check those thresholds on my XU3. Have anybody else experienced overheating at XU3? Sjoerd? Kukjin? Please share your thoughts. -Anand Moon On 8 April 2015 at 13:32, Lukasz Majewski l.majew...@samsung.com wrote: Hi Anand, Move

Re: [PATCH 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board.

2015-04-08 Thread Lukasz Majewski
-resistor = 1; }; }; + +pwm { + pinctrl-0 = pwm0_out; + pinctrl-names = default; + samsung,pwm-outputs = 0; + status = okay; +}; Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Lukasz Majewski
) goto exit_set_pwm_err; } -exit_set_pwm: ctx-pwm_value = pwm; exit_set_pwm_err: mutex_unlock(ctx-lock); Reviewed-by: Lukasz Majewski l.majew...@samsung.com BTW: I've added Guenter to CC. -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux

Re: [PATCH v2 Resend] pwm: samsung: Fix output race on disabling

2015-03-27 Thread Lukasz Majewski
== (u32) -1) { + dev_dbg(our_chip-chip.dev, Forcing manual update); + pwm_samsung_manual_update(our_chip, pwm); + } + chan-period_ns = period_ns; chan-tin_ns = tin_ns; chan-duty_ns = duty_ns; Acked-by: Lukasz Majewski l.majew...@samsung.com -- Best

Re: [PATCH v2] thermal: exynos: Add the support for Exynos5433 TMU

2015-03-20 Thread Lukasz Majewski
or 2-point) and sensor id from TRIMINFO register - Use a little different register address Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- Changes from v1: (https

Re: [PATCH v2 Resend] pwm: samsung: Fix output race on disabling

2015-03-18 Thread Lukasz Majewski
== (u32) -1) { + dev_dbg(our_chip-chip.dev, Forcing manual update); + pwm_samsung_manual_update(our_chip, pwm); + } + chan-period_ns = period_ns; chan-tin_ns = tin_ns; chan-duty_ns = duty_ns; -- Best regards, Lukasz Majewski Samsung RD

Re: [PATCH v2] thermal: exynos: Add the support for Exynos5433 TMU

2015-03-18 Thread Lukasz Majewski
address Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- Changes from v1: (https://lkml.org/lkml/2015/2/26/234) - Add exynos5433_tmu_control() instead of using

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-09 Thread Lukasz Majewski
Hi Kukjin, Lukasz Majewski wrote: Hi Eduardo, On Fri, Mar 06, 2015 at 07:16:53PM +0900, Kukjin Kim wrote: Arnd Bergmann wrote: + Eduardo Hi Arnd, On Tuesday 03 March 2015 04:00:14 Kukjin Kim wrote: Please pull Samsung tmu and hdmi regression fixes

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-09 Thread Lukasz Majewski
to make a clear branch for pull-request but in that case, I couldn't find a solution. Sorry for the inconvenience. I hope v4.0 can support them properly. Thanks, Kukjin -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe

[PATCH RESEND RESEND v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-03-04 Thread Lukasz Majewski
): ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski (5): Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 hwmon: pwm-fan: Extract __set_pwm() function

Re: [PATCH 2/3] arm64: dts: exynos: Add TMU sensor dt node for Exynos5433 SoC

2015-03-04 Thread Lukasz Majewski
-conf.dtsi + status = disabled; + }; + pmu_system_controller: system-controller@105c { compatible = samsung,exynos5433-pmu, syscon; reg = 0x105c 0x5008; Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards

[PATCH RESEND v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-03-04 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Replace pwm_fan_cooling_states

[PATCH RESEND v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-03-04 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

[PATCH RESEND v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-03-04 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove

Re: [PATCH 1/3] thermal: exynos: Add the support for Exynos5433 TMU

2015-03-04 Thread Lukasz Majewski
, SOC_ARCH_EXYNOS5440, SOC_ARCH_EXYNOS7, }; -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/3] arm64: dts: exynos: Add thermal-zones dt node for Exynos5433 SoC

2015-03-04 Thread Lukasz Majewski
/boot/dts/exynos/exynos5433.dtsi index b44ddcc..fbce27d 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -964,3 +964,4 @@ }; #include exynos5433-pinctrl.dtsi +#include exynos5433-tmu.dtsi Reviewed-by: Lukasz Majewski l.majew

[PATCH RESEND v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-03-04 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3

[PATCH RESEND v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-03-04 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Lukasz Majewski l.majew

[PATCH RESEND v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-03-04 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2

[PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Replace pwm_fan_cooling_states

[PATCH v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-26 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Lukasz Majewski l.majew

[PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-26 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3

Re: [PATCH v6 00/18] thermal: exynos: Thermal code rework to use device tree

2015-02-26 Thread Lukasz Majewski
Hi Kukjin, Lukasz Majewski wrote: Hi Kukjin, Eduardo Hi, On 01/25/15 06:49, Eduardo Valentin wrote: On Fri, Jan 23, 2015 at 01:09:53PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal

[PATCH v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-26 Thread Lukasz Majewski
): ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski (5): Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 hwmon: pwm-fan: Extract __set_pwm() function

[PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove

[PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-26 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2

[PATCH v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-26 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

Re: [PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
Hi Guenter, On 02/26/2015 05:59 AM, Lukasz Majewski wrote: The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Lukasz Majewski
viresh.ku...@linaro.org Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Viresh Kumar viresh.ku...@linaro.org This patch is also missing from linux-thermal-soc tree. I will add it to samsung thermal tree, since Viresh has ACK'ed it. --- Changes for v2: - Remove superfluous *np

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Lukasz Majewski
Hi Eduardo, On Thu, Feb 26, 2015 at 11:36:24AM +0100, Lukasz Majewski wrote: Hi Eduardo, Commit: e725d26c4857e5e41975b5e74e64ce6ab09a7121 provided possibility to use device tree to asses if cpu can be used as cooling device. Since the code was somewhat awkward, simpler approach

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, Hi Lukasz, On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Abhilash, This patch fixes the wrong control of PD_DET_EN (power down detection mode) for Exynos7 because exynos7_tmu_control() always enables the power down detection mode

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values

Re: [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-25 Thread Lukasz Majewski
Hi Eduardo, On Wed, Feb 18, 2015 at 11:07:29AM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL_OF disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore

[PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-25 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Replace pwm_fan_cooling_states with pwm_fan_cooling_levels - Update ctx-pwm_fan_state when correct

[PATCH v5 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-25 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

[PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-25 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2

[PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove default-pulse-width property and stick to default

[PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Lukasz Majewski
): ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski (5): Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 hwmon: pwm-fan: Extract __set_pwm() function

[PATCH v5 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-25 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Lukasz Majewski l.majew

[PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3: - Change patch's topic to ARM dts - Reduce maximal

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Lukasz Majewski
); Could you test this patch if it isn't introducing any regression on your HW? -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v6 00/18] thermal: exynos: Thermal code rework to use device tree

2015-02-23 Thread Lukasz Majewski
Hi Kukjin, Eduardo On 01/25/15 06:49, Eduardo Valentin wrote: On Fri, Jan 23, 2015 at 01:09:53PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal framework on Exynos devices. The main goal was to use a generic

Re: [PATCH v6 00/18] thermal: exynos: Thermal code rework to use device tree

2015-02-23 Thread Lukasz Majewski
Hi Kukjin, Lukasz Majewski wrote: Hi Kukjin, Eduardo Hi, On 01/25/15 06:49, Eduardo Valentin wrote: On Fri, Jan 23, 2015 at 01:09:53PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Lukasz Majewski
Hi Guenter, On 02/18/2015 02:07 AM, Lukasz Majewski wrote: This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found

Re: [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-23 Thread Lukasz Majewski
Hi Guenter, On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote: Hi Guenter, [ ... ] If devicetree is not configured, of_property_count_elems_of_size returns -ENOSYS, which is returned, causing the driver to fail loading. Has of_property_count_elems_of_size

[PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-18 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3: - Change patch's topic to ARM dts - Reduce maximal

[PATCH v4 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-18 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com [Rebased on the newest mainline by

[PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-18 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2

[PATCH v4 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-18 Thread Lukasz Majewski
- Odroid U3 board. Patches were applied on: linux-soc-thermal/next branch (Linux 3.19-rc5) SHA1: 252454f5cbda2c6b40c5d36f58cac2938437b85d Kamil Debski (1): ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski (7): thermal: Provide stub for thermal_of_cooling_device_register

[PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-18 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

[PATCH v4 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-18 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Replace pwm_fan_cooling_states with pwm_fan_cooling_levels - Update ctx-pwm_fan_state when correct

[PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-18 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove default-pulse-width property and stick to default

[PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-02-18 Thread Lukasz Majewski
-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - New patch Changes for v3: - thermal_cdev_update() now depends on CONFIG_THERMAL flag Changes for v4: - None --- include/linux/thermal.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/thermal.h b

[PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-18 Thread Lukasz Majewski
. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - None Changes for v3: - Provide stub declaration when CONFIG_THERMAL is not set Changes for v4: - None --- include/linux/thermal.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/include

Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Lukasz Majewski
Hi Chanwoo, Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Chanwoo, This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read

Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Lukasz Majewski
ERROR\n, data-tzd); return PTR_ERR(data-tzd); } - ret = exynos_map_dt_data(pdev); - if (ret) - goto err_sensor; - - pdata = data-pdata; INIT_WORK(data-irq_work, exynos_tmu_work); -- Best regards, Lukasz Majewski Samsung RD

Re: [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table

2015-02-16 Thread Lukasz Majewski
, }, + { .compatible = samsung,exynos7-tmu, }, + { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, exynos_tmu_match); Acked-by: Lukasz Majewski l.majew...@samsung.com Thanks for clean up! -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group

Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2015-02-16 Thread Lukasz Majewski
regards, Krzysztof -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] thermal: exynos: fix: Check if data-tmu_read callback is present before read

2015-02-16 Thread Lukasz Majewski
Hi Eduardo, The exynos_tmu_data() function should on entrance test not only for valid data pointer, but also for data-tmu_read one. It is important, since afterwards it is dereferenced to get temperature code. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal

Re: [PATCH 2/3] exynos: config: Enable thermal emulation for Exynos TMU (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:39PM +0100, Lukasz Majewski wrote: Enabling thermal emulation on Exynos SoCs. New sysfs attribute - emul_temp is created. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked-by: Eduardo Valentin

Re: [PATCH 1/3] exynos: config: Remove CONFIG_EXYNOS_THERMAL_CORE define (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:38PM +0100, Lukasz Majewski wrote: After Exynos TMU rework to use device tree for configuration this flag can be removed. It is not used anymore. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez

Re: [PATCH 3/3] exynos: config: Enable support for cpufreq on Exynos SoCs (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:40PM +0100, Lukasz Majewski wrote: This commit enables the cpufreq subsystem. Moreover, support for using CPU as a cooling device is provided. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked

Re: [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-08 Thread Lukasz Majewski
On Fri, 6 Feb 2015 10:27:25 -0800 Guenter Roeck li...@roeck-us.net wrote: On Fri, Feb 06, 2015 at 05:59:06PM +0100, Lukasz Majewski wrote: It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method

Re: [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-08 Thread Lukasz Majewski
On Fri, 6 Feb 2015 10:36:57 -0800 Guenter Roeck li...@roeck-us.net wrote: On Fri, Feb 06, 2015 at 05:59:07PM +0100, Lukasz Majewski wrote: This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration

[PATCH] thermal: exynos: fix: Check if data-tmu_read callback is present before read

2015-02-06 Thread Lukasz Majewski
The exynos_tmu_data() function should on entrance test not only for valid data pointer, but also for data-tmu_read one. It is important, since afterwards it is dereferenced to get temperature code. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 2

[PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-06 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

[PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-06 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2

[PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-06 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove default-pulse-width property and stick to default

  1   2   3   4   5   >