On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote:
> @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ
> config SPI_S3C64XX
> tristate "Samsung S3C64XX series type SPI"
> depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS)
> - select S3C64XX_DMA if ARCH_S3C
On Sun, Aug 11, 2013 at 02:33:28AM +0200, Tomasz Figa wrote:
> Not all fields of dma_slave_config struct are being initialized by
> prepare_dma() function, leaving those which are not in undefined state,
> which can confuse DMA drivers using them.
Applied all, thanks.
signature.asc
Description:
From: Mark Brown
These symbols are not used outside the files they are defined in so do
not need to be in the global namespace and they aren't declared so sparse
warns.
Signed-off-by: Mark Brown
---
drivers/clk/samsung/clk-exynos4.c| 2 +-
drivers/clk/samsung/clk-exynos5250.
On Thu, Aug 08, 2013 at 01:13:02PM +0530, Padma Venkat wrote:
> If legacy platforms not required to change then I need to introduce a
> new samsung_i2s_dai_data structure which holds only dai_type for
> non-dt platforms. If I change legacy platforms it breaks the older
> platforms now. Is it okay
On Wed, Aug 07, 2013 at 05:18:10PM +0200, Tomasz Figa wrote:
> I don't think this patch is needed at all. You can use generic fixed rate
> clock bindings[1] to define a fixed rate clock using device tree.
OK, good - that's what I'd have expected but I wasn't sure if that
hadn't been defined for
On Wed, Aug 07, 2013 at 02:20:41PM +0530, Padmavathi Venna wrote:
> This patch registers the 16MHz oscillator clock as fixed clk.
This appears to be the same as one of the patches in another series you
sent?
signature.asc
Description: Digital signature
On Wed, Aug 07, 2013 at 02:15:20PM +0530, Padmavathi Venna wrote:
> This patch increases the platform name size from 20 to 30 as one of
> i2s platform_device name in this patchset crosses the limit.
What is the name concerned?
signature.asc
Description: Digital signature
On Wed, Aug 07, 2013 at 02:40:10PM +0530, Padmavathi Venna wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names.
This needs to go along with the driver change otherwise we break
bisection.
signature.asc
Description: Digital signature
On Wed, Aug 07, 2013 at 02:40:15PM +0530, Padmavathi Venna wrote:
> This patch registers the 16MHz oscillator clock as fixed clk.
> +/* 16.9MHz fixed oscillator clock */
> +static void init_osc_clock(void)
> +{
> + struct device_node *np;
> +
> + np = of_find_compatible_node(NULL, NULL, "o
On Fri, Aug 02, 2013 at 04:15:28PM +0530, Padma Venkat wrote:
> Sorry for giving some what wrong info here. I verified the schemata.
> There is a switch on the board which can be used to select the input
> clock of codec MCLK1. We can either select oscillator clock which is
> 16.9MHz which is on t
From: Mark Brown
More for neatness than for any great utility. Really we shouldn't be
creating the child device at all, refactoring will follow.
Signed-off-by: Mark Brown
---
sound/soc/samsung/i2s.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/samsung/i2s.c b/soun
On Mon, Jul 29, 2013 at 05:31:16PM +0530, Padma Venkat wrote:
> On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat wrote:
> >>> + vdd: fixed-regulator@0 {
> >>> + compatible = "regulator-fixed";
> >>> + regulator-name = "vdd-supply";
> >> These names look wrong - they shou
On Sun, Jul 28, 2013 at 10:52:38PM +0200, Linus Walleij wrote:
> Someone moaned about oneline commit messages in
> the last LWN...
I saw that (and even followed up). To be honest for this sort of patch
I'm not that concerned about it - it's fairly clear what's going on and
why it might be a good
On Sun, Jul 28, 2013 at 10:51:31PM +0200, Linus Walleij wrote:
> On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown wrote:
> > + * @auto_runtime_pm: the core should ensure a runtime PM reference is held
> > + * while the hardware is prepared
> I'd mention her
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-bcm63xx.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 9fd7a39..4ac028d 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers
From: Mark Brown
Most SPI drivers that implement runtime PM support use identical code to
do so: they acquire a runtime PM lock in prepare_transfer_hardware() and
then they release it in unprepare_transfer_hardware(). The variations in
this are mostly missing error checking and the choice to use
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-tegra114.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e7d48a1..2e208dc 100644
--- a/drivers/spi/spi-tegra114.c
+++ b
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-pxa2xx.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index e0fd6f6..2eb06ee 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-omap2-mcspi.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 5994039..973c1cb 100644
--- a/drivers/spi/spi-omap2-mcspi.c
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-coldfire-qspi.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
index 0631b9d..e4265ea 100644
--- a/drivers/spi/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-pl022.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index abef061..07e6db6 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-sh-hspi.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
index daf2bf2..0b68cb5 100644
--- a/drivers/spi/spi-sh-hspi.c
+++ b/drivers/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-tegra20-sflash.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index f871c4e..1d814dc 100644
--- a/drivers/spi/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index c9d0b12..62f32c4 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-tegra20-slink.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index b2fb115..c703536 100644
--- a/drivers/spi/spi
On Tue, Jul 23, 2013 at 01:49:22AM +0200, Tomasz Figa wrote:
> This patch modifies s3c64xx DMA driver to prepare and unprepare clocks
> in addition to enableind and disabling, since it is required by common
> clock framework.
Tested-by: Mark Brown
signature.asc
Description: Digital signature
On Wed, Jul 24, 2013 at 01:52:19AM +0200, Tomasz Figa wrote:
> Changes since v2:
> - Reworked to use new PLL registration method introduced by Yadwinder
>Singh Brar's patch series:
>( http://thread.gmane.org/gmane.linux.kernel.samsung-soc/20041 )
I'm not able to test this series since th
On Sat, Jul 20, 2013 at 02:04:12AM +0200, Tomasz Figa wrote:
> [Also not sure on what boards, but still]
> Tested-by: Mark Brown
Just retested this (on Cragganmore), still works fine.
signature.asc
Description: Digital signature
From: Mark Brown
Avoid collisions with other SMDK audio by using the CODEC name.
Signed-off-by: Mark Brown
---
sound/soc/samsung/smdk_wm8994.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
index
From: Mark Brown
Make the code more generally applicable by refactoring so that the MCLK1
rate can be selected based on the compatible string provided by the device
tree, allowing use on other boards which have different rates or use other
information sources.
Signed-off-by: Mark Brown
From: Mark Brown
Initialise the DAI format from the data link, saving code and repeated
work.
Signed-off-by: Mark Brown
---
sound/soc/samsung/smdk_wm8994.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc
On Sat, Jul 27, 2013 at 06:38:02AM +0530, Padma Venkat wrote:
> On Fri, Jul 26, 2013 at 8:23 PM, Mark Brown wrote:
> > As Russell indicated you should really keep the old name around, though
> > marking them as deprecated is OK. However I'm not sure anyone will have
> >
On Fri, Jul 26, 2013 at 05:02:46PM +0200, Tomasz Figa wrote:
> IMHO this SoC-based identification looks much better, especially considering
> the fact that IP version isn't something easily determinable, as even the
> documentation can sometimes be not really clear about that.
Yeah, it's not te
On Fri, Jul 26, 2013 at 07:06:51PM +0530, Padmavathi Venna wrote:
> This patch adds wm8994 codec node on i2c bus1 and the required
> regulator supplies and properties on smdk5420 board.
This isn't a device tree patch for WM8994, it's a patch for the
SMDK5420.
> + vdd: fixed-regulator@0 {
> +
On Fri, Jul 26, 2013 at 07:06:48PM +0530, Padmavathi Venna wrote:
> This patch modifies the i2s driver to give flexibility towards register
> handling. This is a pre requirement for enabling i2s support on Exynos5420.
> This patch modifies only the required registers as a pre-requirement to
> suppo
On Fri, Jul 26, 2013 at 07:06:46PM +0530, Padmavathi Venna wrote:
> Samsung has different versions of I2S introduced in different
> platforms. Each version has some new support added for multichannel,
> secondary fifo, s/w reset control and internal mux for rclk src clk.
> Each newly added change h
On Fri, Jul 26, 2013 at 02:19:39PM +0200, Sylwester Nawrocki wrote:
> On 07/26/2013 11:56 AM, Tushar Behera wrote:
> >On 07/25/2013 08:21 PM, Mark Brown wrote:
> >>I appear to be missing something in the clock driver for the exynos5250.
> >>I'm looking at the Arnd
On Fri, Jul 26, 2013 at 03:26:06PM +0530, Tushar Behera wrote:
> Information as per Exynos5250 user manual:
> "XCLKOUT is an output pin for debugging clocks. Exynos5250 has a CLKOUT
> logic which can select one of the clocks (within its clock domains) and
> output that through XCLKOUT pin."
Yeah,
I appear to be missing something in the clock driver for the exynos5250.
I'm looking at the Arndale schematic and I see that the audio master
clock is connected to XCLKOUT on the SoC. However I can't see any
reference to XCLKOUT or anything similar in the clock driver or any of
the DTS files - whe
On Thu, Jul 25, 2013 at 01:00:49PM +0200, Arnd Bergmann wrote:
> I'm not saying that we can't support legacy board files with the common
> PHY framework, but I'd expect things to be much easier if we focus on those
> platforms that are actively being worked on for now, to bring an end to the
> poi
On Wed, Jul 24, 2013 at 08:32:03PM +0200, Arnd Bergmann wrote:
> Sorry for jumping in to the middle of the discussion, but why does a *new*
> framework even bother defining an interface for board files?
> Can't we just drop any interfaces for platform data passing in the phy
> framework and put t
On Tue, Jul 23, 2013 at 12:44:23PM -0700, Greg KH wrote:
> On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote:
> > statement. In any case this is why the APIs doing lookups do the
> > lookups in the context of the requesting device - devices ask for
> > whatever
On Tue, Jul 23, 2013 at 09:38:00AM +0530, Padma Venkat wrote:
> On Fri, Jul 12, 2013 at 2:19 PM, Mark Brown wrote:
> > Yes, this is good but the quirk should just be found by software based
> > on the compatible string rather than in the DT.
> You mean I just need to initia
On Tue, Jul 23, 2013 at 11:01:10AM -0700, Greg KH wrote:
> On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote:
> > What are the problems you are seeing with doing things with lookups?
> You don't "know" the id of the device you are looking up, due to
>
On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote:
> On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote:
> > I fully agree that a simple, single string will not scale even in some, not
> > so uncommon cases, but there is already a lot of existing lookup solutions
> > over the kern
On Tue, Jul 23, 2013 at 10:37:05AM -0400, Alan Stern wrote:
> On Tue, 23 Jul 2013, Tomasz Figa wrote:
> > > > Okay. Are PHYs _always_ platform devices?
> > > They can be i2c, spi or any other device types as well.
> In those other cases, presumably there is no platform data associated
> with th
On Mon, Jul 22, 2013 at 07:09:27PM +0200, Tomasz Figa wrote:
> On Wednesday 17 of July 2013 11:08:16 Mark Brown wrote:
> > Applied, though only the cast to unsigned long should actually be needed
> > - casting to void * should be good for any pointer so changing to the
>
From: Mark Brown
As part of this add nodes for the main wall supply as well as bucks 7
and 8 which are used to drop that down for several of the LDOs.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 35
1 file changed, 35 insertions
From: Mark Brown
The default audio module for the Arndale has a WM1811A on it. Add this to
the device tree bindings.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts
From: Mark Brown
Fixed voltage regulators (and other similar free standing things) are
supposed to go on a simple-bus for DT correctness reasons.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 28 +---
1 file changed, 17 insertions(+), 11
From: Mark Brown
The out of tree code configures a pullup on the line indicating that it
is an active low interrupt.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch
From: Mark Brown
This avoids polluting the global namespace and silences lots of sparse
warnings. The change pushes us over 80 columns a lot but I couldn't see
a tasteful place to break the lines as-is.
Signed-off-by: Mark Brown
---
drivers/clk/samsung/clk-exynos-audss.c | 2 +-
driver
From: Mark Brown
As the comment says exynos4_clk_register_fixed_ext() was only used by
non-DT platforms. Since Exynos is now DT only it is no longer referenced
and can be removed.
Signed-off-by: Mark Brown
---
drivers/clk/samsung/clk-exynos4.c | 14 --
1 file changed, 14 deletions
On Wed, Jul 17, 2013 at 05:54:11PM +0900, Jingoo Han wrote:
> sdd->ops->request is unsigned int, not unsigned long.
> Also, sdd->rx_dma.ch is a 'struct dma_chan *'.
> Thus, (void *) is converted to (struct dma_chan *)(unsigned long),
> in order to fix possible sparse warnings.
Applied, though only
On Tue, Jul 16, 2013 at 08:53:33AM +0900, Jingoo Han wrote:
> Fix the following build warnings when LPAE is enabled:
>
> drivers/spi/spi-s3c64xx.c:1466:2: warning: format '%x' expects argument of
> type 'unsigned int', but argument 4 has type
> 'resource_size_t' [-Wformat]
> drivers/spi/spi-s3c64
On Tue, Jul 16, 2013 at 08:54:39AM +0900, Jingoo Han wrote:
> Fix the following checkpatch error and warnings:
>
> ERROR: "(foo*)" should be "(foo *)"
> WARNING: line over 80 characters
> WARNING: quoted string split across lines
>
> Also, it converts (void *) to (unsigned long *)(unsigned
From: Mark Brown
Platform using OF and some others don't have any dependencies on arch/arm
so can be built on any platform. Enable that for better compile coverage
when COMPILE_TEST is enabled.
Signed-off-by: Mark Brown
---
sound/soc/samsung/Kconfig | 14 +++---
1 file chang
On Mon, Jul 15, 2013 at 03:11:57PM +0900, Jingoo Han wrote:
> Fix the following checkpatch error and warnings:
>
> ERROR: "(foo*)" should be "(foo *)"
> WARNING: line over 80 characters
> WARNING: quoted string split across lines
Applied, thanks.
signature.asc
Description: Digital signatu
On Mon, Jul 15, 2013 at 03:11:11PM +0900, Jingoo Han wrote:
> Fix the following build warnings when LPAE is enabled:
>
> drivers/spi/spi-s3c64xx.c:1466:2: warning: format '%x' expects argument of
> type 'unsigned int', but argument 4 has type
> 'resource_size_t' [-Wformat]
> drivers/spi/spi-s3c64
On Sun, Jul 14, 2013 at 03:18:16PM +0200, Paul Bolle wrote:
> On Sun, 2013-07-14 at 13:45 +0100, Mark Brown wrote:
> > Simply removing the dependencies is not going to give the clearly
> > intended effect here. The dependency on the DT only machine needs to be
> > replace
On Sun, Jul 14, 2013 at 02:26:52PM +0200, Paul Bolle wrote:
> Commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT for EXYNOS
> SoCs") removed the Kconfig symbols MACH_SMDKV310 and MACH_SMDKC210.
> Now remove the references to both of these symbols from the Kconfig
> entry for SND_SOC_SAMSUNG_SM
On Fri, Jul 12, 2013 at 12:13:17PM +0200, Tomasz Figa wrote:
> On Thursday 11 of July 2013 14:01:39 Mark Brown wrote:
> > Well, it *should* be samsung,i2s-vN where N is the version number of the
> > IP but documentation on the versioning has been patchy hence this whole
> &g
On Fri, Jul 12, 2013 at 10:07:22AM +0530, Padma Venkat wrote:
> A new version number is added when a there was some change in the IP
> like adding a internal mux to the IP, adding multi channel support,
> adding reset control bit. This was done in the older code with
> platform device.
> Same thin
On Thu, Jul 11, 2013 at 01:41:40PM +0200, Tomasz Figa wrote:
> On Thursday 11 of July 2013 12:20:23 Mark Brown wrote:
> > This is a bit of a larger project sadly, there was resistance to doing
> > the DT bindings based on compatible strings using the IP version :(
> I'm n
On Thu, Jul 11, 2013 at 12:43:22PM +0200, Tomasz Figa wrote:
> On Thursday 11 of July 2013 12:38:24 Padmavathi Venna wrote:
> > +- samsung,supports-tdm: If the I2S controller supports TDM, then this flag
> > + must be enabled.
> I think this should be rather handled by a different compatible val
On Thu, Jul 11, 2013 at 12:38:25PM +0530, Padmavathi Venna wrote:
> As per the User Manual, the RFS and BFS should be set in slave mode
> for correct operation.
Applied, thanks. Since this is a fix it should have been the first
patch in the series - this allows fixes to be sent to
> Reviewed-on
On Thu, Jul 11, 2013 at 12:38:24PM +0530, Padmavathi Venna wrote:
> -#define MOD_LR_LLOW (0 << 7)
> -#define MOD_LR_RLOW (1 << 7)
> -#define MOD_SDF_IIS (0 << 5)
> -#define MOD_SDF_MSB (1 << 5)
> -#define MOD_SDF_LSB (2 << 5)
> -#define MOD_SDF_MASK
On Sat, Jul 06, 2013 at 01:36:57AM +0200, Tomasz Figa wrote:
> On Monday 01 of July 2013 22:36:37 Mark Brown wrote:
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = &
On Wed, Jun 19, 2013 at 01:48:15PM +0900, Inki Dae wrote:
> > Related to HDMI sound support in Alsa, I have posted a working RFC
> > "exynos-hdmi to CDF complaint display driver". It registers a separate
> > sound card by registering hdmi audio codec dai and cpu-dai, as you
> > mentioned. But ther
From: Mark Brown
Since the driver has been converted to use the core message pump code
the only use of the messsage queue in the driver is a check to see if
it is empty which will always succeed since nothing ever adds to the
queue. Just remove the queue.
Signed-off-by: Mark Brown
---
drivers
From: Mark Brown
The performance of regmap-irq is improved if the interrupt mask registers
can be cached since it does read/modify/update cycles so start using the
register cache infrastructure for those registers. We should use this more
widely but I don't have a datasheet and this is a
On Tue, Jul 02, 2013 at 09:30:31PM +0900, Inki Dae wrote:
> > Ensure that the definitions of functions match the prototypes used by
> > other modules by including the header with the prototypes in the files
> > with the definitions.
> Is there some functions being used by other modules? And what
On Tue, Jul 02, 2013 at 09:21:32PM +0900, Inki Dae wrote:
> > Ensure that all externally accessed functions are correctly prototyped
> > when defined in each file by making sure the headers with the protoypes
> > are included in the file with the definition.
> I don't see why this patch is needed
From: Mark Brown
Since the Samsung platforms have moved to pinctrl for pin muxing and that
is handled in the core the old GPIO based muxing code can just be removed.
Something similar had been submitted by Thomas Abraham back in March but
a resubmission following review never happened.
Signed
From: Mark Brown
Ensure that the definitions of functions match the prototypes used by
other modules by including the header with the prototypes in the files
with the definitions.
Signed-off-by: Mark Brown
---
drivers/video/exynos/exynos_mipi_dsi_lowlevel.c | 1 +
1 file changed, 1 insertion
On Tue, Jul 02, 2013 at 10:51:36AM +0530, Tushar Behera wrote:
> Arndale board also comes with two other audio codec boards - ALC5631Q
> and AK4678. Different audio codec boards came with different shipments.
This is the default though and since they didn't bother providing any
way of identifying
On Mon, Jul 01, 2013 at 06:47:00PM -0300, Fabio Estevam wrote:
> On Mon, Jul 1, 2013 at 6:36 PM, Mark Brown wrote:
> > i2c@12C9 {
> > - status = "disabled";
> > + wm1811a@11 {
> > +
From: Mark Brown
As part of this add nodes for the main wall supply as well as bucks 7
and 8 which are used to drop that down for several of the LDOs.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 35
1 file changed, 35 insertions
From: Mark Brown
The default audio module for the Arndale has a WM811A on it. Add this to
the device tree bindings.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts
From: Mark Brown
Fixed voltage regulators (and other similar free standing things) are
supposed to go on a simple-bus for DT correctness reasons.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-arndale.dts | 28 +---
1 file changed, 17 insertions(+), 11
From: Mark Brown
Ensure that all externally accessed functions are correctly prototyped
when defined in each file by making sure the headers with the protoypes
are included in the file with the definition.
Signed-off-by: Mark Brown
---
drivers/gpu/drm/exynos/exynos_drm_connector.c | 1
From: Mark Brown
These were all used by the open coded I/O and IRQ implementations and are
no longer referenced now that the regmap core variants are used instead.
Signed-off-by: Mark Brown
---
include/linux/mfd/samsung/core.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/include
From: Mark Brown
This should work with modern compilers, isn't that much of an issue if
it goes wrong and it ensures that the DT-only hardware variants don't
leave unreferenced parameters structures lying around.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 2 --
1 fi
On Wed, Jun 26, 2013 at 12:10:15PM +0200, Tomasz Figa wrote:
> By the way, Mark, does this driver work for you? I have tried it on both
> mini6410 and smdk6410 (configured to use the onboard AC97 codec), with both
> old and new DMA drivers and I couldn't get it to play a single sound.
I've no a
Reviewed-by: Jingoo Han
Signed-off-by: Mark Brown
---
sound/soc/samsung/ac97.c | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
index 1c85999..04d7fd4 100644
--- a/sound/soc/samsung/ac97.c
+++ b
Signed-off-by: Mark Brown
---
sound/soc/samsung/ac97.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
index cb88ead..1c85999 100644
--- a/sound/soc/samsung/ac97.c
+++ b/sound/soc/samsung/ac97.c
@@ -440,7 +440,7 @@ static
Signed-off-by: Mark Brown
---
sound/soc/samsung/ac97.c | 22 +++---
1 file changed, 3 insertions(+), 19 deletions(-)
diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
index 1c85999..3e6a1d2 100644
--- a/sound/soc/samsung/ac97.c
+++ b/sound/soc/samsung/ac97.c
On Tue, Jun 25, 2013 at 01:22:20PM +0200, Tomasz Figa wrote:
> On Tuesday 25 of June 2013 11:28:18 Mark Brown wrote:
> > On my non-DT s3c64xx system I get this when trying to use SPI for the
> > first time:
> Could you clarify first time? Does it work on further retries?
No,
On Tue, Jun 25, 2013 at 01:19:54PM +0200, Tomasz Figa wrote:
> Kukjin, can you amend the comment I mentioned to this patch above the line
> with DEFINE_SPINLOCK or I should send fixed version?
If you're amending stuff please feel free to also add
Tested-by: Mark Brown
(for the w
On Sat, Jun 22, 2013 at 10:42:32PM +0200, Tomasz Figa wrote:
> This is another version of my patches extending support of amba-pl08x
> DMA engine driver to PL080S DMA engine (PL080 modified by Samsung) found
> in Samsung S3C64xx SoCs.
On my non-DT s3c64xx system I get this when trying to use SPI f
On Mon, Jun 24, 2013 at 02:39:54PM +0200, Tomasz Figa wrote:
> This patch adds Device Tree support to max8998 driver.
Acked-by: Mark Brown
If applying please also apply the second patch, I'll drop it from the
regulator tree.
signature.asc
Description: Digital signature
On Mon, Jun 24, 2013 at 02:39:53PM +0200, Tomasz Figa wrote:
> This patch modifies the platform data of max8998 to use arrays for
> specifying predefined voltages of buck1 and buck2 instead of separate
> field for each voltage.
Applied, thanks.
signature.asc
Description: Digital signature
On Fri, Jun 21, 2013 at 02:33:37PM +0200, Tomasz Figa wrote:
> + - EN32KHz AP: 32KHz clock output for application processor
> + - EN32KHz CP: 32KHz clock output for call processor
The clocks should be supported using the clock API not the regulator
API, they shouldn't be present in the DT
On Fri, Jun 21, 2013 at 02:33:36PM +0200, Tomasz Figa wrote:
> This patch modifies the platform data of max8998 to use arrays for
> specifying predefined voltages of buck1 and buck2 instead of separate
> field for each voltage.
>
> This allows to simplify the code a bit and will help in adding sup
On Fri, Jun 21, 2013 at 02:33:35PM +0200, Tomasz Figa wrote:
> The reverse mapping method used is linear mapping since the sub-drivers
> of max8998 such as regulator and charger drivers can use the max8998
> irq_domain to get the virtual irq number for max8998 interrupts.
> All uses of irq_base i
On Thu, Jun 20, 2013 at 02:14:53PM +0300, Phil Carmody wrote:
> With my language-lawyer hat on, I'd suggest ``(get_signal)'' to prevent the
> macro expansion:
Right, which the patch I posted in the mail was doing IIRC.
> However, it's more tempting (i.e. sensible) to just rename the
> one with
On Thu, Jun 20, 2013 at 12:24:47PM +0300, Phil Carmody wrote:
> Can you just make that minimal change, and diff the objdump of the two .o's?
> It would be worth a bug-report against the toolchain if different code was
> being generated. If objdump spews huge numbers of diffs (due to one address
>
On Wed, Jun 19, 2013 at 09:32:44PM +0200, Tomasz Figa wrote:
> On Wednesday 19 of June 2013 20:22:11 Mark Brown wrote:
> > No, I didn't - that's most likely it, I didn't really investigate. I
> > didn't test the watchdog stuff as the clocks didn't get se
On Wed, Jun 19, 2013 at 09:01:33PM +0200, Arnd Bergmann wrote:
> On Wednesday 19 June 2013, Tomasz Figa wrote:
> > > if (plchan->mux_use++ == 0 && pd->get_signal) {
> > > - ret = pd->get_signal(plchan->cd);
> > > + ret = (pd->get_signal)(plchan->cd);
> > Hmm, that's
On Wed, Jun 19, 2013 at 08:26:12PM +0200, Tomasz Figa wrote:
> On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote:
> > - ret = pd->get_signal(plchan->cd);
> > + ret = (pd->get_signal)(plchan->cd);
> Hmm, that's strange. The former is a c
601 - 700 of 1261 matches
Mail list logo
