Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 11:10:14AM +0200, Heiko Stübner wrote: > Similar to the adc and rtc driver, all Samsung platforms reuse a common > platform-device definition for the s3c64xx-spi and simply will set the > correct > name when the machine type is determined during boot. Right, that doesn'

Re: [PATCH 10/10] spi: s3c64xx: add device tree support

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote: > +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no > + particular order). The format of the gpio specifier depends on the gpio > + controller. This seems odd... This isn't a bitbanging controller, and s

Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote: > + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1); Shouldn't we just set the name in the struct platform_device rather than requiring the machine to pass it through by hand? -- To unsubscribe from this list: send the line

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote: > With the addition of platform specific driver data in the spi-s3c64xx > driver, the device name of spi controllers are changed. Accordingly, > update the device name of spi clocks instances. This should've been squashed into the pat

Re: [PATCH 26/33] ARM: S3C64XX: mach-crag6410: Use common macro to define resources

2012-04-25 Thread Mark Brown
On Wed, Apr 25, 2012 at 09:42:36AM +0530, Tushar Behera wrote: > CC: Mark Brown > CC: Ben Dooks > CC: Kukjin Kim > Signed-off-by: Tushar Behera Acked-by: Mark Brown signature.asc Description: Digital signature

Re: [PATCH v5 1/2] mfd: add irq domain support for max8997 interrupts

2012-04-18 Thread Mark Brown
On Wed, Apr 18, 2012 at 03:01:02PM +0530, Thomas Abraham wrote: > struct max8997_platform_data { > /* IRQ */ > - int irq_base; > int ono; > int wakeup; This will *still* break the build. signature.asc Description: Digital signature

Re: [PATCH v4 2/2] regulator: add device tree support for max8997

2012-04-17 Thread Mark Brown
On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote: > On 28 March 2012 22:33, Karol Lewandowski wrote: > >> +    For BUCK's: No 's here, BTW. > >  - EN32KHz_AP > >  - EN32KHz_CP > >  - ENVICHG > >  - ESAFEOUT1 > >  - ESAFEOUT2 > >  - CHARGER > >  - CHARGER_CV > >  - CHARGER_TOPOFF

Re: [PATCH v4 2/2] regulator: add device tree support for max8997

2012-04-16 Thread Mark Brown
On Sat, Mar 24, 2012 at 03:19:50PM +0530, Thomas Abraham wrote: > Add device tree based discovery support for max8997. I tried to apply this but it's collided with some other changes in the driver which have arrived in the meantime and the rejects were too large to fix up. I suspect it's mostly j

Re: [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts

2012-04-16 Thread Mark Brown
On Sat, Mar 24, 2012 at 03:19:49PM +0530, Thomas Abraham wrote: > Add irq domain support for max8997 interrupts. The reverse mapping method > used is linear mapping since the sub-drivers of max8997 such as regulator > and charger drivers can use the max8997 irq_domain to get the linux irq > number

Re: [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts

2012-04-04 Thread Mark Brown
On Sat, Mar 24, 2012 at 03:19:49PM +0530, Thomas Abraham wrote: > Add irq domain support for max8997 interrupts. The reverse mapping method > used is linear mapping since the sub-drivers of max8997 such as regulator > and charger drivers can use the max8997 irq_domain to get the linux irq > number

Re: [PATCH] ARM: S3C64XX: Hook up new style regulator-regulator supplies on Cragganmore

2012-04-02 Thread Mark Brown
On Mon, Apr 02, 2012 at 12:05:53PM -0700, Kukjin Kim wrote: > Mark, is this needed for v3.4? No. signature.asc Description: Digital signature

[PATCH] ARM: S3C64XX: Hook up new style regulator-regulator supplies on Cragganmore

2012-04-02 Thread Mark Brown
The regulator API now allows supplies used by regulators to be specified as normal supplies - provide the hookup for that mechanism on Cragganmore. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-crag6410.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-04-01 Thread Mark Brown
On Fri, Mar 30, 2012 at 06:45:07PM +, Arnd Bergmann wrote: > On Friday 30 March 2012, Stephen Warren wrote: > > > +- cd-inverted: when present, polarity on the wp gpio line is inverted > > > +- wp-inverted: when present, polarity on the wp gpio line is inverted > > I'm not sure about those tw

Re: [PATCH] ARM: S3C64XX: Add basic cpuidle driver

2012-03-30 Thread Mark Brown
On Fri, Mar 30, 2012 at 10:32:54AM +0200, Heiko Stübner wrote: > Am Donnerstag, 22. Dezember 2011, 19:13:59 schrieb Mark Brown: > > My plan there for the s3c64xx was to use pm_domain to figure out if the > > system is idle enough to drop down, I've been adding some pm_ru

Re: [PATCH] ARM: Samsung: Make PM_GENERIC_DOMAINS config depend on CONFIG_PM

2012-03-28 Thread Mark Brown
On Wed, Mar 28, 2012 at 05:07:03PM +0530, Thomas Abraham wrote: > On 28 March 2012 17:04, Mark Brown > wrote: > > Right, this does seem like something which it'd be better to handle > > more gracefully in the PM core. > Ok. Selecting PM_GENERIC_DOMAINS without che

Re: [PATCH] ARM: Samsung: Make PM_GENERIC_DOMAINS config depend on CONFIG_PM

2012-03-28 Thread Mark Brown
On Wed, Mar 28, 2012 at 04:51:32PM +0530, Thomas Abraham wrote: > On 28 March 2012 16:21, Mark Brown > wrote: > > What's the underlying issue here?  This seems like something the PM core > > should be dealing with gracefully... > The PM_GENERIC_DOMAINS config option h

Re: [PATCH] ARM: Samsung: Make PM_GENERIC_DOMAINS config depend on CONFIG_PM

2012-03-28 Thread Mark Brown
On Tue, Mar 27, 2012 at 03:46:43PM +0530, Thomas Abraham wrote: > For s3c64xx and exynos platforms, make the selection of PM_GENERIC_DOMAINS > depend on the CONFIG_PM. What's the underlying issue here? This seems like something the PM core should be dealing with gracefully... signature.asc Desc

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-03-28 Thread Mark Brown
On Tue, Mar 27, 2012 at 11:50:24AM -0400, Chris Ball wrote: > On Tue, Feb 21 2012, Chris Ball wrote: > > On Tue, Feb 21 2012, Kukjin Kim wrote: > >> I created topic branch for this we talked. You can pull that following: > >> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-21 Thread Mark Brown
24xx_i2c_type enum with unsigned int that holds >bitmask with revision-specific quirks Reviewed-by: Mark Brown signature.asc Description: Digital signature

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-21 Thread Mark Brown
On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote: > What do you think about following changes, then? That looks reasonable. signature.asc Description: Digital signature

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-19 Thread Mark Brown
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote: > If you consider code to be inherently less readable because of this > approach I'll rework it. If it's not a such big deal for you I would > prefer to keep it as is. The thing that was causing me to think the code was funny was

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-15 Thread Mark Brown
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote: > Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original > attempt to solve this issue. However, this required adding explicit > checks to driver code all over the place (if (type == S3C2400 || > type == S3c2440_HD

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-03-14 Thread Mark Brown
On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote: > - replace s3c24xx_i2c_type enum with plain unsigned int that can >hold not only device type but also hw revision-specific quirks Would it not be clearer to just have explicit flags for the quirks (eg, as a set of bitfield f

[PATCH] spi: s3c64xx: Fix build

2012-03-14 Thread Mark Brown
Commit 054ebc (spi: Compatibility with direction which is used in samsung DMA operation) does not build as one hunk adds a brace to the first branch of an if statement without adding at least the correspoding close. Remove the unwanted brace. Signed-off-by: Mark Brown --- drivers/spi/spi

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-12 Thread Mark Brown
On Mon, Mar 12, 2012 at 08:01:34PM +0530, Thomas Abraham wrote: > Yes, I agree with your comment. I did refer to manuals of s3c24xx to > Exynos to ensure that the samsung pinctrl driver is generic and > reusable on all samsung soc's. I hope I have not missed out something > important that would re

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-12 Thread Mark Brown
On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote: > The platform specific callback to setup the sdhci pin mux and pin config > is removed and the pinctrl subsystem interface is used to setup the > mux and config. You've only added pinctrl support for Exynos but this driver is also us

Re: [PATCH 2/2] mmc: sdhci-s3c: Enable runtime power management

2012-03-09 Thread Mark Brown
On Fri, Mar 09, 2012 at 12:08:58AM -0500, Chris Ball wrote: > The reworked patch is below, please let me know if it looks incorrect: That looks about right, I'll find out soon enough if it doesn't work in -next as my main development system has the rootfs on this device :) signature.asc Descrip

Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

2012-03-09 Thread Mark Brown
On Fri, Mar 09, 2012 at 10:53:26AM +0900, Jaehoon Chung wrote: > On 03/08/2012 08:01 PM, Mark Brown wrote: > > It should be fine, like I say I didn't really read the patches in enough > > detail as the diffstat set off alarm bells. > If you have any opinions, let me know.

Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

2012-03-08 Thread Mark Brown
On Thu, Mar 08, 2012 at 02:35:53PM +0900, Jaehoon Chung wrote: > So i think no problem that removed "#include ". is it > wrong? > Just touching the setup-gpio- files is problem? It should be fine, like I say I didn't really read the patches in enough detail as the diffstat set off alarm bells.

Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

2012-03-07 Thread Mark Brown
On Wed, Mar 07, 2012 at 12:03:31PM +0900, Jaehoon Chung wrote: > On 03/07/2012 01:30 AM, Mark Brown wrote: > > The same IP is present and used with the same driver on other Samsung > > SoCs. > I know that used with the same driver on other > Samsung-SoCs(S3C64XX/S3C24XX..et

Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

2012-03-06 Thread Mark Brown
On Tue, Mar 06, 2012 at 11:40:08PM +0900, Jae hoon Chung wrote: > 2012/3/6 Heiko Stübner : > > Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown: > >> This series will break S3C64xx, you've not touched it at all in the > >> update but it uses the same SDHCI co

Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

2012-03-06 Thread Mark Brown
On Tue, Mar 06, 2012 at 03:17:20PM +0900, Jaehoon Chung wrote: > This patchset is the purpose for using sdhci-pltfm.c and > removing the arch dependency. > The sdhci-s3c has too heavy arch dependency. > For example, if work for sdhci-s3c.c at mmc-tree, sometime need to change > sdhci.h for Samsun

Re: [PATCH 2/2] mmc: sdhci-s3c: Enable runtime power management

2012-03-05 Thread Mark Brown
On Mon, Mar 05, 2012 at 07:48:42PM +0900, Jaehoon Chung wrote: > On 03/03/2012 09:46 AM, Mark Brown wrote: > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 50); > Could you explain why use 50ms? It's essentially a random number, some other devices use the same o

Re: [PATCH 0/3] video: s3c-fb: Rearrange the elements in platform data

2012-03-03 Thread Mark Brown
On Sat, Mar 03, 2012 at 10:15:32PM +0530, Thomas Abraham wrote: > The third patch in this series includes platform data updates for the > Exynos4210 based Origen board. If the first two patches in this series > are acceptable, I will submit another version of this patchset which > would include up

Re: [linux-pm] [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory

2012-03-03 Thread Mark Brown
On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote: > This movement is needed because the hwmon entries and corresponding > sysfs interface is a duplicate of utilities already provided by > driver/thermal/thermal_sys.c. The goal is to place it in mfd folder > and add necessary call

Re: [PATCH 0/3] video: s3c-fb: Rearrange the elements in platform data

2012-03-03 Thread Mark Brown
On Sat, Mar 03, 2012 at 09:20:05PM +0530, Thomas Abraham wrote: > This patchset rearranges the elements in the platform data of the s3c-fb > driver with the intent of adding device tree support to the driver in > subsequent patches. It seems somewhat surprising that none of these updates touch any

[PATCH 2/2] mmc: sdhci-s3c: Enable runtime power management

2012-03-02 Thread Mark Brown
Since most of the work is already done by the core we just need to add runtime suspend methods and tell the PM core that runtime PM is enabled for this device. Signed-off-by: Mark Brown --- drivers/mmc/host/sdhci-s3c.c | 28 1 files changed, 28 insertions(+), 0

[PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend

2012-03-02 Thread Mark Brown
This matches current best practice as one can have runtime PM enabled without system sleep and CONFIG_PM is defined for both. Signed-off-by: Mark Brown --- drivers/mmc/host/sdhci-s3c.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-02-22 Thread Mark Brown
On Tue, Feb 21, 2012 at 08:17:41AM -0500, Chris Ball wrote: > Pushed to mmc-next, thanks. (I'm expecting that you'll do the merge > to Linus.) I've been sending patches adding runtime PM support to this driver for a while with no response - are there any issues with those? -- To unsubscribe from

[PATCH] ARM: S3C64XX: Supply platform data for SPI on Cragganmore

2012-02-15 Thread Mark Brown
Having to specify the platform data explicitly like this even though it is provided as a default doesn't feel entirely elegant but there we are. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-crag6410.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arc

[PATCH] spi/s3c64xx: Convert to using core message queue

2012-02-15 Thread Mark Brown
Convert the s3c64xx driver to using the new message queue factored out of the pl022 driver by Linus Walleij, saving us a nice block of code and getting the benefits of improvements implemented in the core. Signed-off-by: Mark Brown --- Only lightly tested thus far. Linus, it'd be really

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Mark Brown
On Mon, Feb 13, 2012 at 11:31:39PM +, Ben Dooks wrote: > On Sun, Jan 22, 2012 at 09:39:53PM +0000, Mark Brown wrote: > > TBH I think most of the devices for which people are running these days > > will be able to get some win from the system wide stuff - the WFI modes > &g

[PATCH 2/3] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Mark Brown
Signed-off-by: Mark Brown Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-s3c2410.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index e6f982b..1cb06c58 100644 --- a/drivers/i2c/busses/i2c

[PATCH 3/3] i2c-s3c2410: Refactor ifdefs for PM_SLEEP

2012-02-13 Thread Mark Brown
Use the PM_SLEEP ifdef for system suspend and resume. This is partly in preparation for adding runtime operations and partly because a user may in theory choose to enable runtime suspend but not system suspend. Signed-off-by: Mark Brown --- drivers/i2c/busses/i2c-s3c2410.c |6 +- 1

[PATCH 1/3] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-13 Thread Mark Brown
Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.4 using the newly added devm_request_and_ioremap(). Signed-off-by: Mark Brown Reviewed-by: Barry Song --- drivers/i2c/busses/i2c-s3c2410.c |4 +--- 1 files changed, 1 inser

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-12 Thread Mark Brown
On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: > From: Kisoo Yu > need to set flag after finishing its work > - i2c->suspended = 0; > clk_enable(i2c->clk); > s3c24xx_i2c_init(i2c); > clk_disable(i2c->clk); > + i2c->suspended = 0; Why is this needed - giv

Re: [PATCH v2 03/11] ARM: EXYNOS: add clock part for EXYNOS5250 SoC

2012-02-11 Thread Mark Brown
On Sat, Feb 11, 2012 at 08:07:08PM +, Arnd Bergmann wrote: > what the risk is in changing exynos4 at the same time. It would > be great if we can have all exynos use the common struct clk in 3.4, > but I'm also happy if we just get exynos5 to do it that way from the > beginning and move exynos

Re: [PATCH 1/6] ARM: S3C64XX: Add usb otg phy control

2012-02-10 Thread Mark Brown
On Fri, Feb 10, 2012 at 11:35:41AM +0100, Lukasz Majewski wrote: > From: Joonyoung Shim > > This patch supports to control usb otg phy of S3C64XX. Currently, the > driver for usb otg controls usb otg phy but it can be removed by this > patch. Acked-by: Mark Brown -- To unsubs

Re: [PATCH 2/2] misc: c2c: Add C2C(Chip to Chip) device driver for EXYNOS

2012-02-06 Thread Mark Brown
On Sat, Feb 04, 2012 at 05:15:03PM +0900, Kisang Lee wrote: > Cc: Arnd Bergmann arndb.de> > Cc: Greg Kroah-Hartman kroah.com> > > Signed-off-by: Kisang Lee What is a chip to chip driver? It looks like there is some overlap with the remoteproc work that Ohad Ben-Cohen has been doing, or I thin

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-29 Thread Mark Brown
On Sat, Jan 28, 2012 at 10:30:36PM +0530, Shubhrajyoti Datta wrote: Please delete irrelevant context from your replies. > > + ret = request_irq(irq, s3c64xx_spi_irq, 0, "spi-s3c64xx", sdd); > Could we have a threaded irq instead and there are prints and that may get > executed in interrupt con

Re: [PATCH 0/4] Pending S3C64xx updates

2012-01-27 Thread Mark Brown
On Fri, Jan 27, 2012 at 10:33:24AM +0900, Kukjin Kim wrote: > Mark Brown wrote: > > ARM: S3C64XX: Define some additional always off clocks > Hmm, I know there were discussions about this with Tomasz Figa and I was > waiting for his submitting. But now this looks ok to me so

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-27 Thread Mark Brown
On Fri, Jan 27, 2012 at 10:58:08AM +0100, Karol Lewandowski wrote: > >>On 25.01.2012 12:22, Mark Brown wrote: > >I'm sorry, this makes no sense. Setting a value in the constraints is > >not going to have any impact on the value reported by the driver, it > >neve

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-26 Thread Mark Brown
On Thu, Jan 26, 2012 at 04:28:00PM +0100, Karol Lewandowski wrote: > On 25.01.2012 14:32, Mark Brown wrote: > >Well, they're different things. Device tree isn't Linux specific at > >all. > There is no official platform-agnostic regulator API, nor DT-bindings >

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-25 Thread Mark Brown
On Wed, Jan 25, 2012 at 01:02:29PM +0100, Karol Lewandowski wrote: > On 25.01.2012 12:26, Mark Brown wrote: > However, I still find it little problematic that dt and non-dt > versions behave differently when given the same set of parameters > (previously apply_uV wasn't the def

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-25 Thread Mark Brown
On Wed, Jan 25, 2012 at 10:55:49AM +0100, Karol Lewandowski wrote: > On 12.01.2012 08:35, Thomas Abraham wrote: > >Add device tree based discovery support for max8997. > > >+pdata->regulators = rdata; > >+for_each_child_of_node(regulators_np, reg_np) { > >+for (i = 0; i< ARRAY

[PATCH 4/4] ARM: S3C64XX: Add hookup for Tomatin module on Cragganmore

2012-01-24 Thread Mark Brown
The Tomatin module carries a WM0010 audio DSP. Provide basic hookup for this, though additional platform data will be needed to fully integrate with the driver. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-crag6410-module.c | 27 +- arch/arm/mach-s3c64xx

[PATCH 2/4] ARM: S3C64XX: Define some additional always off clocks

2012-01-24 Thread Mark Brown
that use them, but that can be done incrementally. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/clock.c | 101 + 1 files changed, 101 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c index

[PATCH 3/4] ARM: S3C6410: Use device names for both I2C clocks

2012-01-24 Thread Mark Brown
ror in the request for controller 1. Improve things by registering a device name for controller 0 as well. Due to the fact that we change the numbering for controller 0 depending on if we've registered controller 1 this requires an ifdef to choose the name. Signed-off-by: Mark Brown --- arch/a

[PATCH 1/4] ARM: S3C64XX: Make s3c64xx_init_uarts() static

2012-01-24 Thread Mark Brown
Now that it's in common.c it's not used in multiple source files. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c index 4a7394d..bee7

[PATCH 0/4] Pending S3C64xx updates

2012-01-24 Thread Mark Brown
This patch series is a collection of s3c64xx updates I've had hanging round in my tree for varying lengths of time that it'd be good to get merged. There's no particularly relationship between them except that they're all for s3c64xx. Mark Brown (4): ARM: S3C64XX: Mak

[PATCH] ARM: S3C64XX: Use IN4 DC measurement mode on Tobermory

2012-01-24 Thread Mark Brown
The WM8962 on Tobermory has one of the IN4 inputs connected for DC measurement. Tell the driver it can optimise for this mode. Signed-off-by: Mark Brown --- This feature is going to be merged via ASoC in 3.4 - is it OK if I apply this patch to the ASoC tree too? It's a one liner, I

Re: [PATCH] max8997: Avoid spaces in regulator names

2012-01-24 Thread Mark Brown
On Tue, Jan 24, 2012 at 12:31:11PM +0100, Karol Lewandowski wrote: > max8997-pmic instantiated from device tree uses names, not numerical > ids to distinguish between outputs. > > Replace spaces with underscores in said names to make it possible to > describe these outputs as regulators in DTS. I

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-23 Thread Mark Brown
On Mon, Jan 23, 2012 at 08:21:48PM +0100, Karol Lewandowski wrote: > On 01/23/2012 07:20 PM, Mark Brown wrote: > >Documentation/SubmittingPatches please... > I should have stated explicitly that purpose of this patch (I should > have called it sniplet) was to show my point onl

Re: [PATCH v2 2/2] regulator: add device tree support for max8997

2012-01-23 Thread Mark Brown
On Mon, Jan 23, 2012 at 06:50:22PM +0100, Karol Lewandowski wrote: > Aren't these fixed? i.e. - is it really needed to configure these > either by platform data or DT at all? > > > [1] > > From 5cfba526210bc596c7d14e33fea93648baa0a227 Mon Sep 17 00:00:00 2001 > From: Karol Lewandowski Documen

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-01-22 Thread Mark Brown
On Sun, Jan 22, 2012 at 06:48:36PM +0100, Sylwester Nawrocki wrote: > On 01/22/2012 06:27 PM, Bill Gatliff wrote: > > I for one would rather see in-kernel drivers that require it, and then > In fact we have to deal with the opposite now, as some existing drivers > have been used for multiple gene

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-01-22 Thread Mark Brown
On Sun, Jan 22, 2012 at 01:59:25PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 07:46 PM, Mark Brown wrote: > > + pm_runtime_get_sync(&adap->dev); > IMHO it's more appropriate to use i2c->dev here instead, i.e. to reference > the platform device we'

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 11:49:27PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 10:57 PM, Mark Brown wrote: > > It's just a Kconfig switch, the only issue is that users might not turn > > it on and for platforms where there's not much driver support they're >

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 10:33:44PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 10:23 PM, Heiko Stübner wrote: > > At least S3C2416/S3C2450 and S3C2412 (i.e. the ARMv5 SoCs) might profit from > > it, as they also support the idle modes (stop modes) that Mark is targetting > > with his patches

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 10:25:20PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 07:46 PM, Mark Brown wrote: > > Add stub runtime_pm calls which go through the flow of enabling and > > disabling but don't actually do anything with the device itself as > > there's

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 09:38:13PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 07:31 PM, Mark Brown wrote: > > Yeah, me too but it seemed idiomatic. Frankly I don't really understand > > why there's a synchronous version of put. > The synchronous put callbacks

[PATCH] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
Signed-off-by: Mark Brown Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-s3c2410.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index e6f982b..3d80bab 100644 --- a/drivers/i2c/busses/i2c

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 07:27:32PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 06:57 PM, Mark Brown wrote: > > TBH I'd rather not change the coding style as well as presumably Ben > > likes that the way it is. > If that's Ben's will then let it stay as it

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 04:52:58PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 02:28 PM, Mark Brown wrote: > > + pm_runtime_get_sync(&adap->dev); > > clk_enable(i2c->clk); > It looks a bit strange to have pm_runtime* and manual clock control side >

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: > > - i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL); > > + i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL); > Just in case you are resending the patch for any other reason, it might be > worth >

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 02:24 PM, Mark Brown wrote: > > - int ret; > > + int ret, irq; > > + char clk_name[16]; > clk_name seems to be unused, otherwise looks good. That's git cherry-pick being to

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote: > Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge. > I'll ask Linus to pull in a couple of days after it has hit > linux-next. Thanks. Obviously it'd be nice to get it into 3.3 but I don't see a huge rush and it did m

Re: [PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 02:41:59PM +0100, Bill Gatliff wrote: > What about using autosuspend instead? If a client is doing a lot of > closely-spaced SPI transactions on a relatively flat device tree, > might the resulting runtime suspend/resume overhead between each > transaction become noticeabl

[PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Mark Brown
Signed-off-by: Mark Brown Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-s3c2410.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index e6f982b..737f721 100644 --- a/drivers/i2c/busses/i2c

[PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Mark Brown
Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap(). Signed-off-by: Mark Brown --- drivers/i2c/busses/i2c-s3c2410.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)

[PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown Acked-by: Linus Walleij Acked-by: Heiko Stuebner --- drivers/spi/spi-s3c64xx.c

[PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops

2012-01-21 Thread Mark Brown
In preparation for the addition of runtime PM ops. Signed-off-by: Mark Brown --- drivers/spi/spi-s3c64xx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index d56066b..56dbdf1 100644 --- a

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
at present and this code is much simpler. Signed-off-by: Mark Brown Acked-by: Linus Walleij --- drivers/spi/spi-s3c64xx.c | 57 +++- 1 files changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c in

[PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
have got dropped on the floor somewhere along the line. Mark Brown (3): spi/s3c64xx: Log error interrupts spi/s3c64xx: Convert to dev_pm_ops spi/s3c64xx: Implement runtime PM support drivers/spi/spi-s3c64xx.c | 115 1 files changed

Re: [GIT PULL] Samsung devel for v3.3

2012-01-17 Thread Mark Brown
On Mon, Jan 16, 2012 at 10:40:17PM -0800, Olof Johansson wrote: > The above two don't seem to have been in the branch that was sent by > Kukjin, it had: > ARM: EXYNOS: Invert VCLK polarity for framebuffer on ORIGEN > ARM: S3C64XX: Fix interrupt configuration for PCA935x on Cragganmore

Re: [PATCH v2 1/2] backlight: lcd: add driver for raster-type lcd's with gpio controlled panel reset

2012-01-16 Thread Mark Brown
On Thu, Jan 12, 2012 at 01:13:30PM +0530, Thomas Abraham wrote: > + /* set regulator voltage if specified */ > + if (pd->min_uV || pd->max_uV) > + if (regulator_set_voltage(lp->regulator, > +

Re: [PATCH] backlight: lcd: add driver for raster-type lcd's with gpio controlled panel reset

2012-01-11 Thread Mark Brown
On Wed, Jan 11, 2012 at 04:21:57PM +0530, Thomas Abraham wrote: > In the case of Exynos4 based Origen board, buck7 of max8997 supplies > power to the lcd panel. buck7 is capable of supplying power at > different voltage levels but for Origen board, it is required to > supply only 3.3V. The constra

Re: [PATCH] video: s3c-fb: Add device tree support

2012-01-11 Thread Mark Brown
On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote: > On 10 January 2012 10:22, Mark Brown > > This isn't terribly informative for the user - which GPIOs and in what > > order are they specified?  Looking at the code it looks like pin mux > > configuration s

Re: [GIT PULL] Samsung devel for v3.3

2012-01-11 Thread Mark Brown
On Wed, Jan 11, 2012 at 08:50:54AM -0800, Olof Johansson wrote: > On Wed, Jan 11, 2012 at 8:19 AM, Arnd Bergmann wrote: > > I would also prefer if people stopped having their own trees included > > in next, but I know that I'm sometimes slow to pick up patches that > I also have to admit, as teg

Re: [GIT PULL] Samsung devel for v3.3

2012-01-10 Thread Mark Brown
On Tue, Jan 10, 2012 at 08:13:54PM +, Arnd Bergmann wrote: > On Tuesday 10 January 2012, Mark Brown wrote: > > That sounds like it'd be helpful overall but it's something that has to > > be sorted out at the maintainer level. I'm guessing there's not reall

Re: [GIT PULL] Samsung devel for v3.3

2012-01-10 Thread Mark Brown
On Tue, Jan 10, 2012 at 01:44:54PM -0500, Nicolas Pitre wrote: > On Tue, 10 Jan 2012, Mark Brown wrote: > > So, is there anything that people like me who are contributing to rather > > than maintaining things can do to help here beyond chasing maintainers? > Maybe the Sa

Re: [GIT PULL] Samsung devel for v3.3

2012-01-10 Thread Mark Brown
On Tue, Jan 10, 2012 at 09:06:35AM +, Russell King - ARM Linux wrote: > On Mon, Jan 09, 2012 at 08:11:54AM -0800, Mark Brown wrote: > > This really is very disappointing. > No it isn't. I think we're talking at cross purposes here - I'm saying that this whole situ

Re: [PATCH] video: s3c-fb: Add device tree support

2012-01-09 Thread Mark Brown
On Tue, Jan 10, 2012 at 01:31:47AM +0530, Thomas Abraham wrote: > +Required properties: > +- gpios: The gpios used to interface with the external LCD panel. This isn't terribly informative for the user - which GPIOs and in what order are they specified? Looking at the code it looks like pin mux

Re: [GIT PULL] Samsung devel for v3.3

2012-01-09 Thread Mark Brown
On Mon, Jan 09, 2012 at 09:58:39AM +, Russell King - ARM Linux wrote: > On Sun, Jan 08, 2012 at 08:49:53PM +0000, Mark Brown wrote: > > That'd be extremely disappointing, especially given that there's some > > bug fixes in there for updates going in this m

Re: [GIT PULL] Samsung devel for v3.3

2012-01-09 Thread Mark Brown
On Mon, Jan 09, 2012 at 03:56:34PM +, Arnd Bergmann wrote: > Of course we will take all bug fixes. Just rebase the rest on top of 3.3-rc1 > and we can take it right away for 3.4. I've sent a pull request earlier in the thread for the main ones I'm aware of (which are mostly fixes for things i

Re: [GIT PULL] Samsung devel for v3.3

2012-01-09 Thread Mark Brown
that have been in -next in. The following changes since commit 5f0a6e2d503896062f641639dacfe5055c2f593b: Linux 3.2-rc7 (2011-12-23 21:51:06 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git fixes/samsung Mark Brown (5): ARM:

Re: [GIT PULL] Samsung devel for v3.3

2012-01-08 Thread Mark Brown
On Fri, Jan 06, 2012 at 01:58:29PM -0800, Olof Johansson wrote: > > Please pull Samsung devel for v3.3 from: > > ?git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > next-samsung-devel-samsung > Thanks. I've pulled this into late/devel, based on earlier email from > Arnd we

Re: [PATCH] backlight: lcd: add driver for raster-type lcd's with gpio controlled panel reset

2012-01-07 Thread Mark Brown
On Sat, Jan 07, 2012 at 04:34:34PM +0530, Thomas Abraham wrote: > On 6 January 2012 12:19, Mark Brown > wrote: > > In principle it should be specified in both places to account for shared > > supplies though for all practical purposes for an LCD panel I can't see > &g

Re: [PATCH] backlight: lcd: add driver for raster-type lcd's with gpio controlled panel reset

2012-01-05 Thread Mark Brown
On Thu, Jan 05, 2012 at 08:07:53PM +0100, Lars-Peter Clausen wrote: > > +- lcd,pwrctrl-min-uV: If a regulator controls the Vcc voltage of the lcd > > panel, > > + this property specifies the minimum voltage the regulator should supply. > > + The value of this property should in in micro-volts.

Re: [RFC][PATCH 1/4] lcd: platform-lcd: Eliminate need for platform data

2012-01-02 Thread Mark Brown
On Mon, Jan 02, 2012 at 11:21:46PM +0530, Thomas Abraham wrote: > Your point on maintaining support for both old and new formats is > helpful. But I am not sure if maintaining support for both formats is > the right thing to do. As most of the ARM platforms will switch to > using dt, maybe convert

Re: [PATCH 12/12] ARM: restart: S3C24XX: use new restart hook

2012-01-02 Thread Mark Brown
On Mon, Jan 02, 2012 at 02:33:57PM +0100, Heiko Stübner wrote: > Am Montag, 2. Januar 2012, 14:26:31 schrieb Mark Brown: > > On Mon, Jan 02, 2012 at 02:14:16PM +0100, Heiko St?bner wrote: > > > Therefore I'm introducing a new s3c2443-pm-common.c. Question now is, > >

<    5   6   7   8   9   10   11   12   13   >