[PATCH v7 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-07-08 Thread Pankaj Dubey
(). Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-exynos/pmu.c | 185 +- 2 files changed, 146 insertions(+), 40 deletions(-) diff --git a/arch/arm/mach

[PATCH v6 0/6] Cleanup patches for mach-exynos

2014-07-06 Thread Pankaj Dubey
/map.h inclusion from regs-pmu.h to platsmp.c Pankaj Dubey (6): ARM: EXYNOS: Make exynos machine_ops as static ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine ARM: EXYNOS: Move SYSREG definition into sys-reg specific file ARM: EXYNOS: Remove file path from comment

[PATCH v6 1/6] ARM: EXYNOS: Make exynos machine_ops as static

2014-07-06 Thread Pankaj Dubey
As machine function ops are used only in this file let's make them static. Also remove unused and unwanted declarations from common.h. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.h |8 arch/arm/mach

[PATCH v6 4/6] ARM: EXYNOS: Remove file path from comment section

2014-07-06 Thread Pankaj Dubey
Many files under arm/mach-exynos are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/headsmp.S

[PATCH v6 5/6] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-07-06 Thread Pankaj Dubey
this definition in pm_domain.c file itself and thus it will help in removing header file inclusion from pm_domain.c. Also removing S5P_ prefix from macro. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pm_domains.c |8

[PATCH v6 6/6] ARM: EXYNOS: Remove linux/bug.h from pmu.c

2014-07-06 Thread Pankaj Dubey
This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos

[PATCH v6 3/6] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file

2014-07-06 Thread Pankaj Dubey
While making PMU implementation to be device tree based, there are few register offsets related with SYSREG present in regs-pmu.h, so let's make a new header file regs-sys.h to keep all such SYSREG related register offsets and remove them from regs-pmu.h Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v6 2/6] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-07-06 Thread Pankaj Dubey
it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/exynos.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/arch/arm/mach

[PATCH v6 4/4] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-07-06 Thread Pankaj Dubey
This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in reducing dependency of common.h in pmu.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h | 17 - arch/arm/mach-exynos/exynos-pmu.h | 24

[PATCH v6 2/4] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-07-06 Thread Pankaj Dubey
this and till now it got included indirectly. So lets move header inclusion of mach/map.h from regs-pmu.h to platsmp.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h|4 +- arch/arm/mach-exynos/exynos.c| 12 +- arch/arm/mach

[PATCH v6 1/4] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-07-06 Thread Pankaj Dubey
Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/exynos.c | 37 + 2 files changed, 38 insertions

[PATCH v6 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-07-06 Thread Pankaj Dubey
(). Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-exynos/pmu.c | 188 +- 2 files changed, 149 insertions(+), 40 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig

RE: [PATCH v5 1/5] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: Hi Pankaj, In general the patch seems quite nice, but please see few comments inline. On 25.06.2014 16:03, Pankaj Dubey wrote: Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. Signed

RE: [PATCH v5 2/5] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: Hi Pankaj, This looks much better now, but please see my comments inline. On 25.06.2014 16:03, Pankaj Dubey wrote: Under arm/mach-exynos many files are using PMU register offsets. Since we have added support for accessing PMU base

RE: [PATCH v5 3/5] ARM: EXYNOS: Move mach/map.h inclusion from regs-pmu.h to platsmp.c

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: Hi Pankaj, On 25.06.2014 16:03, Pankaj Dubey wrote: As we have removed static mappings from regs-pmu.h it does not need map.h anymore. But platsmp.c needed this and till now it got included indirectly. So lets move header inclusion

RE: [PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: Hi Pankaj, Please see my comments inline. On 25.06.2014 16:03, Pankaj Dubey wrote: This patch modifies Exynos Power Management Unit (PMU) initialization implementation in following way: - Added platform driver support

RE: [PATCH v5 5/5] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: Hi Pankaj, On 25.06.2014 16:03, Pankaj Dubey wrote: This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in reducing dependency of common.h in pmu.c. Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v5 0/6] Cleanup patches for mach-exynos

2014-06-25 Thread Pankaj Dubey
this here. If I have missed something please point to any existing such patch. - Added patch: Remove linux/bug.h from pmu.c. - Added patch: Move mach/map.h inclusion from regs-pmu.h to platsmp.c Pankaj Dubey (6): ARM: EXYNOS: Make exynos machine_ops as static ARM: EXYNOS: Move cpufreq

[PATCH v5 2/6] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-06-25 Thread Pankaj Dubey
it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/exynos.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach

[PATCH v5 1/6] ARM: EXYNOS: Make exynos machine_ops as static

2014-06-25 Thread Pankaj Dubey
As machine function ops are used only in this file let's make them static. Also remove unused and unwanted declarations from common.h. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.h |8 arch/arm/mach

[PATCH v5 3/6] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file

2014-06-25 Thread Pankaj Dubey
While making PMU implementation to be device tree based, there are few register offsets related with SYSREG present in regs-pmu.h, so let's make a new header file regs-sys.h to keep all such SYSREG related register offsets and remove them from regs-pmu.h Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v5 5/6] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-06-25 Thread Pankaj Dubey
this definition in pm_domain.c file itself and thus it will help in removing header file inclusion from pm_domain.c. Also removing S5P_ prefix from macro. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pm_domains.c |8

[PATCH v5 4/6] ARM: EXYNOS: Remove file path from comment section

2014-06-25 Thread Pankaj Dubey
Many files under arm/mach-exynos are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/headsmp.S

[PATCH v5 6/6] ARM: EXYNOS: Remove linux/bug.h from pmu.c

2014-06-25 Thread Pankaj Dubey
This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos

[PATCH v5 0/5] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-06-25 Thread Pankaj Dubey
initialization code to scan DT and match against supported compatiblity string in driver code, and once we get matching node use that for accessing PMU regmap handle using syscon_early_regmap_lookup_by_phandle. If there is any better solution please suggest. Pankaj

[PATCH v5 1/5] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-06-25 Thread Pankaj Dubey
Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/exynos.c | 45 + 2 files changed, 46

[PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-06-25 Thread Pankaj Dubey
(). Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-exynos/pmu.c | 201 +- 2 files changed, 161 insertions(+), 41 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig

[PATCH v5 2/5] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-06-25 Thread Pankaj Dubey
address as well as help in reducing dependency over machine header files. Thus helping for migration of PMU implementation from machine to driver folder which can be reused for ARM64 bsed SoC. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h|4

[PATCH v5 3/5] ARM: EXYNOS: Move mach/map.h inclusion from regs-pmu.h to platsmp.c

2014-06-25 Thread Pankaj Dubey
As we have removed static mappings from regs-pmu.h it does not need map.h anymore. But platsmp.c needed this and till now it got included indirectly. So lets move header inclusion of mach/map.h from regs-pmu.h to platsmp.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz

[PATCH v5 5/5] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-06-25 Thread Pankaj Dubey
This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in reducing dependency of common.h in pmu.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h | 17 - arch/arm/mach-exynos/exynos-pmu.h | 31

RE: [PATCH RFC] mfd: syscon: Decouple syscon interface from syscon devices

2014-06-24 Thread Pankaj Dubey
reply. I tested this patch after changing exynos PMU to be a syscon provider and it's working well. So if we can address Arnd's comments, this patch will be helpful in making exynos PMU a complete platform driver. Thanks, Pankaj Dubey Signed-off-by: Tomasz Figa t.f...@samsung.com Hi

RE: [PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-06-24 Thread Pankaj Dubey
Hi, On Wednesday, June 25 2014 Tomasz Figa write: On 24.06.2014 13:28, Pankaj Dubey wrote: On Tuesday, June 17 2014, Tomasz Figa wrote: On 10.05.2014 08:56, Pankaj Dubey wrote: [snip] + + ret = platform_driver_register(exynos_pmu_driver); + if (ret 0) + goto out

RE: [PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-06-17 Thread Pankaj Dubey
Hi Tomasz, Hi, On 10.05.2014 08:56, Pankaj Dubey wrote: From: Young-Gun Jang yg1004.j...@samsung.com Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. This patch also adds helper function as get_exynos_pmuregmap. This function can be used

RE: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-06-16 Thread Pankaj Dubey
Hi Tomasz, -Original Message- Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines of code for registering platform devices. We can move these lines to exynos_dt_machine_init and delete

RE: [PATCH v3 4/6] ARM: EXYNOS: Remove unused header inclusion from hotplug.c

2014-06-16 Thread Pankaj Dubey
Hi Tomasz, -Original Message- Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: This patch removed plat/cpu.h inclusion from hotplug.c as it is not required. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/hotplug.c |2 -- 1 file

RE: [PATCH v3 1/6] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-06-16 Thread Pankaj Dubey
Hi Tomasz, Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: Let's handle i2c interrupt re-configuration in i2c driver. This will help us in removing some soc specific checks from machine files. Since only Exynos5250, and Exynos5420 need to do this, added syscon based phandle

Re: [PATCH v3 0/6] Introducing Exynos ChipId driver

2014-05-11 Thread Pankaj Dubey
On 05/11/2014 04:12 PM, Olof Johansson wrote: Hi, On Sat, May 10, 2014 at 12:18 AM, y...@samsung.com wrote: From: Pankaj Dubey pankaj.du...@samsung.com This patch series attempts to get rid of soc_is_exynos macros and eventually with the help of this series we can probably get rid

Re: [PATCH v3 6/6] ARM: EXYNOS: Refactoring to remove soc_is_exynos macros from exynos

2014-05-11 Thread Pankaj Dubey
On 05/11/2014 04:10 PM, Olof Johansson wrote: On Sat, May 10, 2014 at 12:18 AM, y...@samsung.com wrote: From: Pankaj Dubey pankaj.du...@samsung.com This patch enables chipid driver for ARCH_EXYNOS and refactors machine code as well as exynos cpufreq driver code for using chipid driver

Re: [PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c

2014-05-11 Thread Pankaj Dubey
On 05/11/2014 03:52 PM, Olof Johansson wrote: On Sat, May 10, 2014 at 12:18 AM, y...@samsung.com wrote: From: Pankaj Dubey pankaj.du...@samsung.com This patch removes usage of soc_is_exynos4/5 from exynos.c. For this we need to separate machine descriptors for exynos4 and exynos5. While doing

[PATCH v3 1/3] ARM: dts: Add PMU node to exynos4210

2014-05-10 Thread Pankaj Dubey
This patch adds pmu regnode to exynos4210 dtsi to handle PMU register access via DT. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts

[PATCH v3 2/3] ARM: dts: Add PMU node to exynos4212 and exynos4412

2014-05-10 Thread Pankaj Dubey
This patch adds pmu regnode to exynos4212 and exynos4412 dtsi to handle PMU register access via DT. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/boot/dts/exynos4212.dtsi |5 + arch/arm/boot/dts/exynos4412.dtsi |5 + 2 files changed, 10 insertions(+) diff

[PATCH v3 0/3] Add PMU node for Exynos4 SoCs

2014-05-10 Thread Pankaj Dubey
branch. [1]: Allow NULL property in syscon_early_regmap_lookup_by_phandle https://lkml.org/lkml/2014/5/10/10 and https://lkml.org/lkml/2014/4/29/661 [2]: https://lkml.org/lkml/2014/4/25/762 Pankaj Dubey (3): ARM: dts: Add PMU node to exynos4210 ARM: dts: Add PMU node to exynos4212

[PATCH v3 3/3] Documentation: update samsung pmu binding information

2014-05-10 Thread Pankaj Dubey
This patch updates samsung pmu (power management unit) binding information. CC: Leela Krishna Amudala l.kris...@samsung.com CC: Tomasz Figa t.f...@samsung.com CC: Guenter Roeck li...@roeck-us.net CC: Rob Landley r...@landley.net Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com

[PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-05-10 Thread Pankaj Dubey
it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c

[PATCH v4 00/11] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-05-10 Thread Pankaj Dubey
. For testing on Arndale (Exynos5250) board: Tested-by: Pankaj Dubey pankaj.du...@samsung.com Changes Since v3: - Addressed build fail issue in exynos.c as reported by Sachin Kamat. - Optimized exynos_pmu_probe function by removing exynos_pmu_data_init as suggested by Vikas Sajjan. - Rebased on top

[PATCH v4 11/11] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-05-10 Thread Pankaj Dubey
From: Young-Gun Jang yg1004.j...@samsung.com This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in making PMU implementation independent of common.h header. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v4 03/11] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file.

2014-05-10 Thread Pankaj Dubey
-pmu.h Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/exynos.c |1 + arch/arm/mach-exynos/pm.c |1 + arch/arm/mach-exynos/regs-pmu.h |3 --- arch/arm

[PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-05-10 Thread Pankaj Dubey
that we can reduce dependency over machine header files. - Separate each SoC's PMU initialization function and make it as part of platform data. - It also removes uses of soc_is_exynosXYZ() thus making PMU implementation independent of plat/cpu.h. Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v4 04/11] ARM: EXYNOS: Remove file path from comment section

2014-05-10 Thread Pankaj Dubey
Many files under arm/mach-exynos are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/headsmp.S

[PATCH v4 08/11] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-05-10 Thread Pankaj Dubey
static mapping of PMU base address as well as help in reducing dependency over machine header files. Thus helping for migration of PMU implementation from machine to driver folder which can be reused for ARM64 bsed SoC. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos

[PATCH v4 09/11] ARM: EXYNOS: Move mach/map.h inclusion from regs-pmu.h to platsmp.c

2014-05-10 Thread Pankaj Dubey
As we have removed static mappings from regs-pmu.h it does not need map.h anymore. But platsmp.c needed this and till now it got included indirectly. So lets move header inclusion of mach/map.h from regs-pmu.h to platsmp.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach

[PATCH v4 07/11] ARM: EXYNOS: Remove linux/bug.h from pmu.c

2014-05-10 Thread Pankaj Dubey
This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c

[PATCH v4 05/11] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-05-10 Thread Pankaj Dubey
from pm_domain.c it's better we define this definition in pm_domain.c file itself and thus it will help in removing header file inclusion from pm_domain.c. Also removing S5P_ prefix from macro. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com

[PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-05-10 Thread Pankaj Dubey
handle. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/Kconfig |1 + arch/arm/mach-exynos/common.h |2 ++ arch/arm/mach-exynos/exynos.c | 39 +++ 3 files changed, 42

[PATCH v3 0/6] Introducing Exynos ChipId driver

2014-05-10 Thread Pankaj Dubey
provided infrastructure to make SoC specific information avaible to user space via sysfs entry, as suggested by Arnd. Pankaj Dubey (6): i2c: s3c2410: Handle i2c sys_cfg register in i2c driver ARM: EXYNOS: Remove i2c sys configuration related code ARM: EXYNOS: Remove soc_is_exynos4/5 from

[PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c

2014-05-10 Thread Pankaj Dubey
This patch removes usage of soc_is_exynos4/5 from exynos.c. For this we need to separate machine descriptors for exynos4 and exynos5. While doing this patch does some consolidation also. CC: Russell King li...@arm.linux.org.uk CC: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Pankaj

[PATCH v3 4/6] ARM: EXYNOS: Remove unused header inclusion from hotplug.c

2014-05-10 Thread Pankaj Dubey
This patch removed plat/cpu.h inclusion from hotplug.c as it is not required. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/hotplug.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index

[PATCH v3 6/6] ARM: EXYNOS: Refactoring to remove soc_is_exynos macros from exynos

2014-05-10 Thread Pankaj Dubey
-mask we need separate compatible string for exynos4 and exynos5. Hoping this will be helpful in future as bit-mask and bit-shift bit may differ. Added binding information as well. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- .../bindings/arm/samsung/exynos-chipid.txt | 21

[PATCH v3 2/6] ARM: EXYNOS: Remove i2c sys configuration related code

2014-05-10 Thread Pankaj Dubey
Since all these code has been moved into i2c driver, now we can safely remove them from machine files. CC: Russell King li...@arm.linux.org.uk Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 38 +-- arch/arm/mach

[PATCH v3 1/6] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-05-10 Thread Pankaj Dubey
...@vger.kernel.org CC: linux-...@vger.kernel.org CC: linux-...@vger.kernel.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- .../devicetree/bindings/arm/samsung/sysreg.txt |1 + arch/arm/boot/dts/exynos5.dtsi |5 +++ arch/arm/boot/dts/exynos5250.dtsi

[PATCH v3 5/6] soc: samsung: exynos-chipid: Add Exynos Chipid driver support

2014-05-10 Thread Pankaj Dubey
support is getting added. So this driver intends to provide initialization code all these functionalites and thus helping in removing macros. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- drivers/soc/Kconfig |1 + drivers/soc/Makefile|1 + drivers/soc

Re: [PATCH 0/4] Add framework to support clkout

2014-05-09 Thread Pankaj Dubey
, Pankaj Dubey -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-09 Thread Pankaj Dubey
, + struct samsung_out_clock *out_clk_list, unsigned int nr_out_clk); extern unsigned long _get_rate(const char *clk_name); -- Best Regards, Pankaj Dubey -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH V3 2/3] ARM: EXYNOS5: Add Suspend-to-RAM support for 5420

2014-05-09 Thread Pankaj Dubey
://lkml.org/lkml/2014/4/30/8 #define EXYNOS5_AUTO_WDTRESET_DISABLE (0x0408) #define EXYNOS5_MASK_WDTRESET_REQUEST (0x040C) -- Best Regards, Pankaj Dubey -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH V3 1/3] ARM: EXYNOS5: PMU support for 5420

2014-05-09 Thread Pankaj Dubey
EXYNOS5420_KFC_USE_STANDBY_WFE2BIT(22) +#define EXYNOS5420_KFC_USE_STANDBY_WFE3BIT(23) + +#define DUR_WAIT_RESET 0xF + + #endif /* __ASM_ARCH_REGS_PMU_H */ -- Best Regards, Pankaj Dubey -- To unsubscribe from this list: send

[PATCH v4 0/4] Introduce new Kconfig for Samsung common clock

2014-05-07 Thread Pankaj Dubey
after each commit. V2: 1) Adding new Kconfig file for Samsung common clock. 2) Make COMMON_CLK_SAMSUNG option invisible. (as suggested by Tomasz Figa) 3) Let COMMON_CLK_SAMSUNG select COMMON_CLK. (as suggested by Tomasz Figa) 4) Move S3C24XX clock config option in new Kconfig file. Pankaj Dubey (4

[PATCH v4 1/4] clk: samsung: add new Kconfig for Samsung common clock option

2014-05-07 Thread Pankaj Dubey
This patch adds new Kconfig file for adding new COMMON_CLK_SAMSUNG option. Samsung platforms can select this for using common clock infrastructure. CC: Mike Turquette mturque...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- drivers/clk/Kconfig |2 ++ drivers/clk

[PATCH v4 3/4] ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock Kconfig file

2014-05-07 Thread Pankaj Dubey
...@arm.linux.org.uk Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-s3c24xx/Kconfig | 14 -- drivers/clk/samsung/Kconfig |9 + 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig

[PATCH v4 2/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX

2014-05-07 Thread Pankaj Dubey
This patch selects COMMON_CLK_SAMSUNG for EXYNOS and S3C64XX SoC and removes COMMON_CLK selection as COMMON_CLK_SAMSUNG selects it's dependency. CC: Russell King li...@arm.linux.org.uk Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/Kconfig |4 ++-- 1 file changed, 2

[PATCH v4 4/4] drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support

2014-05-07 Thread Pankaj Dubey
This patch replaces PLAT_SAMSUNG with COMMON_CLK_SAMSUNG for Samsung common clock support. Any Samsung SoC want to use Samsung common clock infrastructure can simply select COMMON_CLK_SAMSUNG. CC: Mike Turquette mturque...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com

Re: [PATCH 0/4] Introducing Exynos ChipId driver

2014-05-06 Thread Pankaj Dubey
On 05/05/2014 11:58 PM, Arnd Bergmann wrote: On Monday 05 May 2014 18:23:55 Pankaj Dubey wrote: On 05/04/2014 12:02 AM, Arnd Bergmann wrote: Ideally this should be done by slightly restructuring the DT source to make all on-chip devices appear below the soc node. Currently I can't see soc

[PATCH v2 4/6] ARM: EXYNOS: remove unused header inclusion from hotplug.c

2014-05-06 Thread Pankaj Dubey
This patch removed plat/cpu.h inclusion from hotplug.c as it is not required. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/hotplug.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index

[PATCH v2 5/6] soc: samsung: exynos-chipid: Add Exynos Chipid driver support

2014-05-06 Thread Pankaj Dubey
support is getting added. So this driver intends to provide initialization code all these functionalites and thus helping in removing macros. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- drivers/soc/Kconfig |1 + drivers/soc/Makefile|1 + drivers/soc

[PATCH v2 2/6] ARM: EXYNOS: Move SYS_I2C_CFG register save/restore to i2c driver

2014-05-06 Thread Pankaj Dubey
...@arm.linux.org.uk CC: linux-...@vger.kernel.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 12 +--- arch/arm/mach-exynos/include/mach/map.h |3 --- arch/arm/mach-exynos/pm.c | 10 -- arch/arm/mach-exynos

Re: [PATCH v2 1/6] i2c: s3c2410: Moving I2C interrupt re-configuration code into i2c driver

2014-05-06 Thread Pankaj Dubey
Hi Tomasz, Thanks for review. On 05/07/2014 03:36 AM, Tomasz Figa wrote: Hi Pankaj, On 06.05.2014 10:51, Pankaj Dubey wrote: Let's move I2C interrupt re-configuration code from machine file exynos.c to I2C driver. Since only Exynos5250, and Exynos5420 need to do this, added syscon based

Re: [PATCH 0/4] Introducing Exynos ChipId driver

2014-05-05 Thread Pankaj Dubey
Hi Arnd, Thanks for review and suggestions. On 05/04/2014 12:02 AM, Arnd Bergmann wrote: On Saturday 03 May 2014 15:11:36 Pankaj Dubey wrote: This patch series attempts to get rid of soc_is_exynos macros and eventually with the help of this series we can probably get rid

Re: [PATCH 3/4] misc: exynos-chipid: Add Exynos Chipid driver support

2014-05-05 Thread Pankaj Dubey
On 05/05/2014 04:57 PM, Krzysztof Kozlowski wrote: On sob, 2014-05-03 at 15:11 +0900, Pankaj Dubey wrote: diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 7eb4b69..48c8fb5 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -55,3 +55,4 @@ obj-$(CONFIG_SRAM

Re: [PATCH v3 00/12] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-05-02 Thread Pankaj Dubey
Hi, Gentle ping. Tomasz, Kukjin will you please have a look on this series. Thanks, Pankaj Dubey On 04/30/2014 02:17 PM, Pankaj Dubey wrote: This patch series, does some minor cleanup of exynos machine files. It also modifies Exynos Power Management Unit (PMU) related code for converting

[PATCH 3/4] misc: exynos-chipid: Add Exynos Chipid driver support

2014-05-02 Thread Pankaj Dubey
support is getting added. So this driver intends to provide initialization code all these functionalites and thus helping in removing macros. CC: Arnd Bergmann a...@arndb.de CC: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- drivers/misc

[PATCH 0/4] Introducing Exynos ChipId driver

2014-05-02 Thread Pankaj Dubey
/msg327677.html [2]: Exynos PMU cleanup and refactoring. https://lkml.org/lkml/2014/4/30/44 Pankaj Dubey (4): ARM: EXYNOS: remove soc_is_exynos4/5 from exynos.c ARM: EXYNOS: remove unused header inclusion from hotplug.c misc: exynos-chipid: Add Exynos Chipid driver support ARM: EXYNOS

[PATCH 1/4] ARM: EXYNOS: remove soc_is_exynos4/5 from exynos.c

2014-05-02 Thread Pankaj Dubey
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c| 30 +++--- arch/arm/plat-samsung/include/plat/cpu.h |3 --- 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm

[PATCH 2/4] ARM: EXYNOS: remove unused header inclusion from hotplug.c

2014-05-02 Thread Pankaj Dubey
This patch removed plat/cpu.h inclusion from hotplug.c as it is not required. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/hotplug.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index

Re: [PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-30 Thread Pankaj Dubey
Hi Sachin, On 04/30/2014 03:00 PM, Sachin Kamat wrote: Hi Pankaj, On 30 April 2014 10:47, Pankaj Dubey pankaj.du...@samsung.com wrote: As machine function ops are used only in this file let's make them static. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos

Re: [PATCH v3 11/12] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-04-30 Thread Pankaj Dubey
On 04/30/2014 03:05 PM, Vikas Sajjan wrote: Hi Pankaj, On Wed, Apr 30, 2014 at 10:47 AM, Pankaj Dubey pankaj.du...@samsung.com wrote: This patch modifies Exynos Power Management Unit (PMU) initialization implementation in following way: - Added platform_device support by registering static

Re: [RESUBMIT RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver

2014-04-29 Thread Pankaj Dubey
lee.jo...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/Makefile |2 -- drivers/mfd/Kconfig|9 + drivers/mfd

Re: [RESUBMIT RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver

2014-04-29 Thread Pankaj Dubey
...@samsung.com CC: Samuel Ortiz sa...@linux.intel.com CC: Lee Jones lee.jo...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/Makefile |2 -- drivers/mfd/Kconfig

[PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-29 Thread Pankaj Dubey
As machine function ops are used only in this file let's make them static. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos

[PATCH v3 04/12] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file.

2014-04-29 Thread Pankaj Dubey
-pmu.h Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/exynos.c |1 + arch/arm/mach-exynos/pm.c |1 + arch/arm/mach-exynos/regs-pmu.h |3 --- arch/arm

[PATCH v3 08/12] ARM: EXYNOS: Remove linux/bug.h from pmu.c

2014-04-29 Thread Pankaj Dubey
This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c

[PATCH v3 12/12] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-04-29 Thread Pankaj Dubey
From: Young-Gun Jang yg1004.j...@samsung.com This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in making PMU implementation independent of common.h header. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v3 05/12] ARM: EXYNOS: Remove file path from comment section

2014-04-29 Thread Pankaj Dubey
Many files under arm/mach-exynos are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/headsmp.S

[PATCH v3 03/12] ARM: EXYNOS: Cleanup mach-exynos/common.h file

2014-04-29 Thread Pankaj Dubey
Remove unused and unwanted declarations from mach-exynos/common.h Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h |9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 30123a0

[PATCH v3 02/12] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-04-29 Thread Pankaj Dubey
it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c

[PATCH v3 11/12] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-04-29 Thread Pankaj Dubey
that we can reduce dependency over machine header files. - Separate each SoC's PMU initialization function and make it as part of platform data. - It also removes uses of soc_is_exynos() thus making PMU implementation independent of plat/cpu.h. Signed-off-by: Pankaj Dubey pankaj.du

[PATCH v3 10/12] ARM: EXYNOS: Move mach/map.h inclusion from regs-pmu.h to platsmp.c

2014-04-29 Thread Pankaj Dubey
As we have removed static mappings from regs-pmu.h it does not need map.h anymore. But platsmp.c needed this and till now it got included indirectly. So lets move header inclusion of mach/map.h from regs-pmu.h to platsmp.c. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach

[PATCH v3 00/12] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-04-29 Thread Pankaj Dubey
] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29085 We have tested these patches on SMDK5250 board for System boot and Arndale (Exynos5250) board for System boot and PMU initialization and S2R. For testing on Arndale (Exynos5250) board: Tested-by: Pankaj Dubey pankaj.du...@samsung.com

[PATCH v3 06/12] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-04-29 Thread Pankaj Dubey
from pm_domain.c it's better we define this definition in pm_domain.c file itself and thus it will help in removing header file inclusion from pm_domain.c. Also removing S5P_ prefix from macro. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com

[PATCH v3 09/12] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-04-29 Thread Pankaj Dubey
: Arnd Bergmann a...@arndb.de Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/common.h|4 +- arch/arm/mach-exynos/exynos.c| 19 +- arch/arm/mach-exynos/hotplug.c |4 +- arch/arm/mach-exynos/include/mach/map.h

[PATCH v3 07/12] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-29 Thread Pankaj Dubey
handle. Signed-off-by: Young-Gun Jang yg1004.j...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/common.h |2 ++ arch/arm/mach-exynos/exynos.c | 39 +++ 3 files changed, 43

Re: [RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver

2014-04-28 Thread Pankaj Dubey
On 04/28/2014 08:21 PM, Lee Jones wrote: On Fri, 25 Apr 2014, Pankaj Dubey wrote: This patch moves Exynos PMU driver implementation from arm/mach-exynos to drivers/mfd. This driver is mainly used for setting misc bits of register from PMU IP of Exynos SoC which will be required to configure

<    1   2   3   4   5   >