Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Hi Mauro, On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 10 Sep 2015 20:14:04 +0300 > Sakari Ailus escreveu: > > > Hi Javier, > > > > Thanks for the set! A few comments below. > > > > Javier Martinez Canillas wrote: &g

[PATCH 1/1] media: Correctly determine whether an entity is a sub-device

If the function of an entity is not one of the pre-defined ones, it is not correctly recognised as a V4L2 sub-device. Signed-off-by: Sakari Ailus --- include/media/media-entity.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/media/media-entity.h b/include/media/media-entity.h

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

Hi Mauro, On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 12 Oct 2015 00:07:52 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote: > > > Instead of r

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

@ static int iss_pipeline_enable(struct iss_pipeline *pipe, > break; > > pad = media_entity_remote_pad(pad); > - if (pad == NULL || > - media_entity_type(pad->entity) != MEDIA_ENT_T_V4L2_SUBDEV) > + if (

Re: [PATCH v4 2/2] [media] media-device: split media initialization and registration

r dev being NULL instead. > > Also, add a media_device_cleanup() function that will destroy the > graph_mutex that is initialized in media_device_init(). > > Suggested-by: Sakari Ailus > Signed-off-by: Javier Martinez Canillas Thanks! For drivers/media/media-device.c, drivers/media/platfor

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Hi Mauro, Mauro Carvalho Chehab wrote: > Em Fri, 11 Sep 2015 09:31:36 +0200 > Javier Martinez Canillas escreveu: > >> Hello Sakari, >> >> On 09/11/2015 07:51 AM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Javier Martinez Canillas wrot

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Hi Javier, Javier Martinez Canillas wrote: Hello Sakari, On 09/10/2015 07:14 PM, Sakari Ailus wrote: Hi Javier, Thanks for the set! A few comments below. Thanks to you for your feedback. Javier Martinez Canillas wrote: The media device node is registered and so made visible to user

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Javier Martinez Canillas wrote: > Also, add a media_entity_cleanup() function that will destroy the > graph_mutex that is initialized in media_entity_init(). media_device_init() and media_device_cleanup()? -- Sakari Ailus sakari.ai...@linux.intel.com -- To unsubscribe from this list: se

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

plicitly > by the driver or asynchronously using v4l2_async_register_subdev(). > > Also, add a media_entity_cleanup() function that will destroy the > graph_mutex that is initialized in media_entity_init(). > > Suggested-by: Sakari Ailus > Signed-off-by: Javier Martinez Canill

Re: [PATCH RFC v3 07/16] media: get rid of unused "extra_links" param on media_entity_init()

media_entity *entity); > > int media_entity_create_link(struct media_entity *source, u16 source_pad, How about putting this in front of the set? It has no dependencies to the other patches, does it? Acked-by: Sakari Ailus -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMP

Re: [PATCH] media: v4l2: make alloction alogthim more robust and flexible

> *buf, > > order = get_order(size); > /* Dont over allocate*/ > - if ((PAGE_SIZE << order) > size) > + if (order > 0 && (PAGE_SIZE << order) > size) > order--; > >

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

>> new file mode 100644 > >> index 000..015cc13 > >> --- /dev/null > >> +++ b/drivers/media/platform/exynos5-is/fimc-is-param.h > > ... > >> +struct param_control { > >> + u32 cmd; > > > > You use uint32_t in some other he

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

shading_map_size; > + float shading_map[3][40][30]; > + uint32_tgeometric_correction_map_size; > + float geometric_correction_map[2][3][40][30]; > + enum lens_facingfacing;

Re: [PATCH v11 02/12] [media] exynos5-fimc-is: Add driver core files

gt; + > +#define FW_SHARED_OFFSET (0x8c) > +#define DEBUG_CNT(500 * 1024) > +#define DEBUG_OFFSET (0x84) > +#define DEBUGCTL_OFFSET (0x8bd000) > +#define DEBUG_FCOUNT (0x8c64c0) > + > +#defi

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

ue is board-specific. > > > sensor clock frequency from the FIMC driver you should reference a clock > > > in the sensor DT node. That obviously requires generic clock support, > > > which might not be available for your platform yet (that's one of the > > > rea