preparing the packed list with the comment from Maya Erez and
Venkatraman.
Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device
drivers/mmc/card/block.c | 454 ++--
drivers/mmc
This patch supports packed command of eMMC4.5 device.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in a
single transfer on the bus.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/card/block.c | 454
This patch adds packed command feature of eMMC4.5.
The maximum number for packing read(or write) is offered
and exception event relevant to packed command which is
used for error handling is enabled. If host wants to use
this feature, MMC_CAP2_PACKED_CMD should be set.
Signed-off-by: Seungwon
Maya Erez wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com
wrote:
@@ -943,7 +950,8 @@ static int mmc_blk_err_check(struct mmc_card
*card,
* kind. If it was a write, we may have transitioned to
* program mode, which we have to wait
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
While calling mmc_cache_ctrl() a host is not claimed. This patch
adds the mmc_try_claim_host() for quick response in suspend.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc
Sahitya Tummala wrote:
Hi,
On 10/27/2011 4:24 PM, Seungwon Jeon wrote:
+static int mmc_blk_packed_err_check(struct mmc_card *card,
+struct mmc_async_req *areq)
+{
+ struct mmc_queue_req *mq_mrq = container_of(areq, struct mmc_queue_req
will be
deferred next time.
If request can't be packed, it'd rather be sent at once than delayed
by returning a BLKPREP_DEFER for better responsiveness.
Thanks.
Seungwon Jeon.
The decision whether a request is packable or not should not be made per
request, therefore I don't see the need
Maya Erez wrote:
+ if (reqs = 2) {
+ mmc_blk_packed_hdr_wrq_prep(mq-mqrq_cur, card,
mq, reqs);
+ if (rq_data_dir(rqc) == READ) {
+ areq = mq-mqrq_cur-mmc_active;
+
S, Venkatraman svenk...@ti.com wrote:
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote:
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote
Maya Erez wrote:
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com
wrote:
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote:
+static u8
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote:
+static u8 mmc_blk_chk_packable(struct mmc_queue *mq, struct
request *req)
The function prepares the checkable list
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote:
S, Venkatraman svenk...@ti.com wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command of eMMC4.5 device.
Several
This patch-set adds support of packed command feature
for eMMC4.5 devices.
Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device
drivers/mmc/card/block.c | 355
This patch adds packed command feature of eMMC4.5.
The maximum number for packing read(or write) is offered
and exception event relevant to packed command which is
used for error handling is enabled. If host wants to use
this feature, MMC_CAP2_PACKED_CMD should be set.
Signed-off-by: Seungwon
S, Venkatraman svenk...@ti.com wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command of eMMC4.5 device.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in a
single
S, Venkatraman svenk...@ti.com wrote:
On Thu, Oct 27, 2011 at 4:24 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command feature of eMMC4.5 Spec.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in one
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
Girish K S wrote:
On 24 October 2011 15:40, Seungwon Jeon tgih@samsung.com wrote:
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message
Chris Ball wrote:
Hi Seungwon,
On Mon, Oct 24 2011, Seungwon Jeon wrote:
Code cleanup. The codes of related to eMMC4.5 are scattered.
This patch removes a duplicate if-statement and assembles all.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c | 20
at card-init.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c | 20 +---
1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 6354eb3..6354bac 100644
--- a/drivers/mmc/core/mmc.c
+++ b
Base code of V8 may be mixed.
Please check below for next resending. It seems like unrelated.
#define MMC_CAP2_CACHE_CTRL (1 1)
#define EXT_CSD_FLUSH_CACHE 32
Best regards,
Seungwon Jeon.
Girish K S wrote:
This patch adds the support for power off notify feature, available
This patch will apply the generic CMD6 timeout to switch command
for power class.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index f8ea938
This mail is a duplicate from our security machine.
V5 of related patch has already submitted.
Please ignore this resending.
I think that it was unfortunate.
Seungwon Jeon.
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation, sanitize, flush cache) in eMMC4.5 Spec.
Signed-off-by: Seungwon Jeon tgih
Andrei E. Warkentin wrote:
Hi Seungwon,
2011/10/6 Seungwon Jeon tgih@samsung.com:
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations
Adrian Hunter wrote:
On 06/10/11 07:38, Seungwon Jeon wrote:
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations.
Signed-off-by: Seungwon Jeontgih
= dw_mci_prepare_command(slot-mmc, mrq-stop);
If i misunderstood something, plz let me know...Thanks.
Yes, predefined transfer doesn't send stop command normally.
But if transfer error is occurred, stop command is required.
Thank you for test.
Best regards,
Seungwon Jeon.
Tested-by: Jaehoon Chung jh80.ch
Adrian Hunter wrote:
On 22/09/11 05:12, Seungwon Jeon wrote:
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations.
Signed-off-by: Seungwon Jeontgih@samsung.com
---
This patch is base on [PATCH v3] mmc: core
update this patch?
Best regards,
Seungwon Jeon.
regards
Girish K S
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation
Andrei Warkentin wrote:
2011/9/26 Seungwon Jeon tgih@samsung.com:
Andrei Warkentin wrote:
Hi Seungwon,
- Original Message -
From: Seungwon Jeon tgih@samsung.com
To: linux-...@vger.kernel.org
Cc: Chris Ball c...@laptop.org, linux-samsung-soc@vger.kernel.org
This patch adds the support for predefined multiple block read/write.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc.c | 32 ++--
1 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc
This patch adds the support for predefined multiple block read/write.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc.c | 32 ++--
1 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc
Andrei Warkentin wrote:
Hi Seungwon,
- Original Message -
From: Seungwon Jeon tgih@samsung.com
To: linux-...@vger.kernel.org
Cc: Chris Ball c...@laptop.org, linux-samsung-soc@vger.kernel.org,
kgene kim kgene@samsung.com, dh han
dh@samsung.com, Seungwon Jeon tgih
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation, sanitize, flush cache) in eMMC4.5 Spec.
Signed-off-by: Seungwon Jeon tgih
Hi,
J Freyensee wrote:
On 09/21/2011 07:12 PM, Seungwon Jeon wrote:
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background
Chris Ball wrote:
Hi,
On Thu, Sep 08 2011, Seungwon Jeon wrote:
Erase unit size of high capacity is multiple of 512KiB not 1024KiB.
Could we have some more info, please? What are the visible symptoms
of the erase unit size being incorrect, how did you realize this was
a problem
Chris Ball wrote:
Hi,
On Tue, Sep 13 2011, Seungwon Jeon wrote:
On Thu, Sep 08 2011, Seungwon Jeon wrote:
Erase unit size of high capacity is multiple of 512KiB not 1024KiB.
Could we have some more info, please? What are the visible symptoms
of the erase unit size being incorrect
Hi Girish,
Could you check my feedbacks about previous version?
There is something misunderstood.
I added comment below.
Best regards,
Seungwon Jeon.
Girish K S wrote:
This patch adds the power off notification handling
during suspend and system poweroff.
For suspend mode short timeout
Erase unit size of high capacity is multiple of 512KiB not 1024KiB.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index b148bb1..7991ecf 100644
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation, sanitize, flush cache) in eMMC4.5 Spec.
Signed-off-by: Seungwon Jeon tgih
Thank you for comment.
I will apply it.
Best regards,
Seungwon Jeon.
Kyungmin Park wrote:
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Nitpick: see below comments and typo.
On Thu, Sep 8, 2011 at 3:10 PM, Seungwon Jeon tgih@samsung.com wrote:
EXT_CSD[248] includes the default
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation, sanitize, flush cache) in eMMC4.5 Spec.
Signed-off-by: Seungwon Jeon tgih
Hi Girish K S,
I think short type is proper rather than long type by default.
Long type seems to be unacceptable in suspend regarding long timeout.
One question,
Is this patch considered for system power off besides suspend?
Beset regards,
Seungwon Jeon.
Girish K S wrote:
Hi Mr Park,
On 5
Hi Girish,
In case of system poweroff, mmc_power_off can be called indeed?
And I added some comments.
Best regards,
Seungwon Jeon.
Girish K S wrote:
This patch adds the power off notification handling
during suspend and system poweroff.
For suspend mode short timeout is used, whereas
Hi Girish,
Girish K S wrote:
V2- The datatype of the cmd6_timeout is changed from u8 to unsigned int,
as it can hold a value upto 255*10=2550.
This patch adds the code to handle the default timeout
for switch command.
For eMMC 4.5 devices if timeout is not specified for the switch
This patch adds platform device for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig |5 ++
arch/arm/mach-exynos4/Makefile |1 +
arch/arm/mach-exynos4/dev-dwmci.c
Hi,
Kyungmin Park wrote:
On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig
Hi
Kyungmin Park wrote:
On Fri, Jul 15, 2011 at 3:58 PM, Seungwon Jeon tgih@samsung.com
wrote:
Hi,
Kyungmin Park wrote:
On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia
Card
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig | 12
arch/arm/mach-exynos4/Makefile|1 +
arch/arm/mach-exynos4/dev-dwmci.c
Hi,
Kyungmin Park wrote:
On Wed, Jul 13, 2011 at 4:17 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig
before command done is occured, next request can be
sent, but CD of current request is not finished. This can bring about
a broken sequence of request and request-done.
And Data error interrupt(DRTO, DCRC, SBE, EBE) and data transfer
over(DTO) are same reanson.
Signed-off-by: Seungwon Jeon tgih
This patch sets the card_width bit of CTYPE for the corresponding card.
CTYPE[31] and CTYPE[16] correspond respectively to card[15] and card[0]
for 8-bit mode. And CTYPE[15] and CTYPE[0] correspond respectively to
card[15] and CTYPE[0] for 1-bit or 4-bit mode.
Signed-off-by: Seungwon Jeon tgih
101 - 154 of 154 matches
Mail list logo
