Re: [PATCH V3 2/3] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2013-01-20 Thread Shubhrajyoti Datta
On 1/17/13, Amit Daniel Kachhap amit.dan...@samsung.com wrote: Below fixes are done to support falling threshold interrupt, * Falling interrupt status macro corrected according to exynos5 data sheet. * The get trend function modified to calculate trip temperature correctly. * The clearing of

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

2012-11-22 Thread Shubhrajyoti Datta
On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410:

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 1:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-05 Thread Shubhrajyoti Datta
On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry about. Looks good. request irq could be devm_* also. Not an objection though. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH] i2c-s3c2410: Use plain pm_runtime_put()

2012-06-29 Thread Shubhrajyoti Datta
Hi Mark, On Thu, Jun 28, 2012 at 6:38 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: There's no point in using _sync() as we don't really care if the suspend has completed immediately. Agree. Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com Signed-off-by: Mark Brown

Re: [PATCH] serial: samsung: protect NULL dereference of clock name

2012-05-30 Thread Shubhrajyoti Datta
Hi Kim, On Wed, May 30, 2012 at 1:59 PM, Kyoungil Kim ki0351@samsung.com wrote: From: KeyYoung Park keyyoung.p...@samsung.com When priting the serial clock source, if clock source name is null, kernel reference NULL point. Could you help me understand why is that NULL ? Or the crash that

Re: [PATCH 3/3] i2c-s3c2410: Refactor ifdefs for PM_SLEEP

2012-02-17 Thread Shubhrajyoti Datta
On Tue, Feb 14, 2012 at 4:35 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Use the PM_SLEEP ifdef for system suspend and resume. This is partly in preparation for adding runtime operations and partly because a user may in theory choose to enable runtime suspend but not system

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-14 Thread Shubhrajyoti Datta
Hi Mark, The changes look good to me. Reviewed-by: Datta Shubhrajyoti shubhrajy...@ti.com For your changes. Some other doubts though not related to your patch. Just curious. On Sat, Jan 21, 2012 at 6:58 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Saves remembering to call

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-31 Thread Shubhrajyoti Datta
Hi Mark, On Mon, Jan 30, 2012 at 3:10 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sat, Jan 28, 2012 at 10:30:36PM +0530, Shubhrajyoti Datta wrote: Please delete irrelevant context from your replies. +   ret = request_irq(irq, s3c64xx_spi_irq, 0, spi-s3c64xx, sdd); Could

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-28 Thread Shubhrajyoti Datta
Hi Mark, Some minor doubts/ questions. On 1/21/12, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have