Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Sonny Rao
On Thu, Aug 28, 2014 at 8:50 AM, Doug Anderson diand...@google.com wrote: Ulf, On Thu, Aug 28, 2014 at 12:25 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 27 August 2014 17:52, Doug Anderson diand...@google.com wrote: Ulf, On Wed, Aug 27, 2014 at 4:17 AM, Ulf Hansson

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-22 Thread Sonny Rao
On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: Exynos 5250 and 5420 based boards uses built-in CD# line for card detection.But unfortunately CD# line is on the same voltage rails as of I/O

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-08-04 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com Signed

[PATCHv6] mmc: dw_mmc: change to use recommended reset procedure

2014-07-14 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com --- v2: Add Generic DMA support per

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Sonny Rao
On Fri, Jul 11, 2014 at 3:20 AM, Seungwon Jeon tgih@samsung.com wrote: On Fri, July 11, 2014, Sonny Rao wrote: On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Sonny, I have missed this patch. You finally choose to take extra interrupt handling

[PATCHv5] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com --- v2: Add Generic DMA support per

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-10 Thread Sonny Rao
and is just ignored. Please check one thing below. On Tue, June 10, 2014, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off

Using s5p-sss hw crypto causes ipsec to break

2014-06-23 Thread Sonny Rao
Hi, I've been investigating an issue relating to hardware crypto which is that when I enable the s5p-sss module for hardware cryptographic acceleration on Samsung Exynos SoCs the in-kernel IPSec seems to break, although cryptographic operations on filesystems/block devices using this driver seem

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-06-09 Thread Sonny Rao
On Wed, May 28, 2014 at 10:17 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. On 05/29/2014 09:35 AM, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-06-09 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com --- v2: Add Generic DMA support per

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-28 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com --- v2: Add Generic DMA support per

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-22 Thread Sonny Rao
On Mon, May 19, 2014 at 6:49 PM, Seungwon Jeon tgih@samsung.com wrote: On Sat, May 17, 2014, Sonny Rao wrote: On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, May 13, Sonny Rao wrote: On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-16 Thread Sonny Rao
On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, May 13, Sonny Rao wrote: On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote: As I mentioned in previous version, you put all reset stuff in existing fifo_reset function. Although

Re: [PATCH] arm: dts: exynos5: Remove multi core timer

2014-05-15 Thread Sonny Rao
On Thu, May 15, 2014 at 4:43 PM, Doug Anderson diand...@chromium.org wrote: Tomasz, On Thu, May 15, 2014 at 4:25 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 16.05.2014 01:18, David Riley wrote: On Thu, May 15, 2014 at 4:03 PM, Chirantan Ekbote chiran...@chromium.org wrote: Hi Tomasz,

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread Sonny Rao
on our testing it seems to work. I understand the skepticism, as I shared it initially when I saw this, but based on our experience, this is correct and it doesn't need to live in a separate function. Please check my comments below. On Tue, May 13, 2014, Sonny Rao wrote: This patch changes

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
, the controller_reset bit should be set in all cases, so I don't think that it should be separated. Thanks, Seungwon Jeon On Sat, May 10, 2014, Sonny Rao wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Fri, May 9, 2014 at 8:36 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment. As you mentioned, this reset sequence is recommended at Synopsys TRM. Add the minor

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Mon, May 12, 2014 at 2:44 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 8:36 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment. As you

[PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
-using_dma add proper return values (although it appears no caller checks) Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com --- drivers/mmc/host/dw_mmc.c | 55 ++- drivers/mmc/host/dw_mmc.h | 1 + 2

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-09 Thread Sonny Rao
have checked the Synopsys TRM.. On 05/09/2014 10:34 AM, Sonny Rao wrote: On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D yuvaraj

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: From: Sonny Rao sonny...@chromium.org This patch changes

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Any comments on this patch? I'll just add that without this fix, running the tuning loop for UHS modes is not reliable on dw_mmc because errors will happen and you will eventually hit this race and hang. This can happen

Re: [PATCH] ARM: dts: Fix mmc node on exynos5250 snow board

2013-12-05 Thread Sonny Rao
On Thu, Dec 5, 2013 at 2:06 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: Commits 64c138a (ARM: dts: Move fifo-depth property from exynos5250 board dts) and 0c3de788 (ARM: dts: change status property of dwmmc nodes for exynos5250) missed out handling the exynos5250 snow dts file. Delete

Re: [PATCH] clk: samsung: Fix PLL35XX lock time

2013-10-15 Thread Sonny Rao
On Mon, Oct 14, 2013 at 9:08 PM, Doug Anderson diand...@chromium.org wrote: Tomasz, On Fri, Oct 11, 2013 at 7:06 PM, Tomasz Figa t.f...@samsung.com wrote: Well, it's some kind of difference indeed. However, how often can a frequency transition happen? I believe that ondemand allows minimum