Re: [PATCH v7 05/15] drm/exynos: add Exynos5433 decon driver

2015-06-22 Thread Varka Bhadram
are using it...? Am i missing anything ? -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in

Re: [PATCH v7 05/15] drm/exynos: add Exynos5433 decon driver

2015-06-22 Thread Varka Bhadram
On 06/22/2015 05:27 PM, Inki Dae wrote: On 2015년 06월 22일 20:41, Varka Bhadram wrote: (..) +platform_set_drvdata(pdev, ctx); You are setting the driver data as ctx.. But no where you are using it...? Am i missing anything ? See decon_bind and decon_unbind functions. :) Cleared

Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()

2015-04-16 Thread Varka Bhadram
; -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Varka Bhadram
Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v3: - Rename MYNAME to DRV_NAME - Use devm_request_region() instead of request_region. Suggested by Varka Bhadram. - Remove release_region from cleanup handle logic by using devres API. Suggested by Varka Bhadram

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Varka Bhadram
, EC_HOST_CMD_REGION_SIZE); + release_region(EC_LPC_ADDR_MEMMAP, EC_MEMMAP_SIZE); + These also will be gone -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCHv5 3/9] devfreq: event: Add exynos-ppmu devfreq-event driver

2014-12-22 Thread Varka Bhadram
the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH] mtd: remove .owner field for driver using module_platform_driver

2014-11-11 Thread Varka Bhadram
/kernel/git/wsa/linux.git/log/?h=platform/remove_owner -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
= request_threaded_irq(gpio_to_irq(dsi-te_gpio), + exynos_dsi_te_irq_handler, NULL, + IRQF_TRIGGER_RISING, TE, dsi); why don't we use devm_request_threaded_irq()..? -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
. So I don't use devm_* APIs. You meant to say that in-case of GPIOs also you are following the same thing ..? Means requesting the GPIOs and Releasing several times ..? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
On 07/22/2014 05:23 PM, YoungJun Cho wrote: Hi Varka, On 07/22/2014 08:14 PM, Varka Bhadram wrote: On 07/22/2014 04:40 PM, YoungJun Cho wrote: Hi Varka, This irq handler should be registered in attach() and unregistered in detach(). The devm_* APIs are released(freed) in remove(), right

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

2014-07-22 Thread Varka Bhadram
, ADC_S3C2410_MUX_TS); + + timeout = wait_for_completion_timeout + (info-completion, EXYNOS_ADC_TIMEOUT); Should be properly aligned: wait_for_completion_timeout(info-completion, EXYNOS_ADC_TIMEOUT); -- Regards, Varka Bhadram