Re: [PATCH] ARM: S3C2443: Workaround for 2443 EXTINT error

2012-11-24 Thread Alexander Varnin
I've done it within another function, because otherwise users of other chips would pay for a one more runtime check, which they don't need. On the other hand, this function get called not so frequently, to make it valueable. The first version of my patch i've used internally worked as you said, so

Re: [PATCH] ARM: S3C2443: Workaround for 2443 EXTINT error

2012-11-24 Thread Heiko Stübner
Am Samstag, 24. November 2012, 12:24:49 schrieb Heiko Stübner: Am Samstag, 24. November 2012, 10:01:31 schrieb Alexander Varnin: I've done it within another function, because otherwise users of other chips would pay for a one more runtime check, which they don't need. On the other hand,

Re: [PATCH] ARM: S3C2443: Workaround for 2443 EXTINT error

2012-11-23 Thread Heiko Stübner
Am Freitag, 23. November 2012, 08:10:15 schrieb Alexander Varnin: Please take a look at this document. It describes the problem with EXTINTn registers on 2443. In fact, the irqext_set function for s3c2443 differs from common starting from //Hack for 2443 error workaround comment. wow ... this

[PATCH] ARM: S3C2443: Workaround for 2443 EXTINT error

2012-11-22 Thread Alexander Varnin
S3C2443 CPU has a problem with incorrect reading from EXTINTn registers. So s3c_irqext_type function wrongly modifies them. So add special function for s3c2443, to handle this case. Signed-off-by: Alexander Varnin fenix...@mail.ru --- arch/arm/mach-s3c24xx/s3c2443.c |8

Re: [PATCH] ARM: S3C2443: Workaround for 2443 EXTINT error

2012-11-22 Thread Heiko Stübner
Hi Alexander, first of all could you elaborate a bit more on the error you experience, because I currently have problems to understand it from the code alone :-) . More inline. Am Donnerstag, 22. November 2012, 14:00:01 schrieb Alexander Varnin: S3C2443 CPU has a problem with incorrect