Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Krzysztof, On 09/30/2015 02:30 AM, Krzysztof Kozlowski wrote: [snip] >> >> The DTS in the vendor ChromeOS tree are called exynos5250-snow-rev{4,5}.dtb >> but I decided to leave Rev4 as exynos5250-snow.dtb to avoid breaking u-boot >> that has CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" in

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Doug, On 09/29/2015 07:28 PM, Doug Anderson wrote: [snip] > > >> arch/arm/boot/dts/Makefile| 1 + >> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684 >> ++ >> arch/arm/boot/dts/exynos5250-snow-rev5.dts| 47 ++ >>

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 30.09.2015 16:06, Javier Martinez Canillas wrote: > Hello, > > On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >> On 30.09.2015 15:58, Kukjin Kim wrote: > > [snip] > Could you add the new compatible and fix patch issues pointed by Doug? >>> Documenting for the compatibles

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 30.09.2015 15:58, Kukjin Kim wrote: > On 09/30/15 09:30, Krzysztof Kozlowski wrote: >> On 29.09.2015 20:57, Javier Martinez Canillas wrote: >>> There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: >>> Rev4 and Rev5. The only difference between these 2 revisions is the

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello, On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 15:58, Kukjin Kim wrote: [snip] >>> >>> Could you add the new compatible and fix patch issues pointed by Doug? >>> >> Documenting for the compatibles would be required even I already applied >> its updated patch... >

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Krzysztof, On 09/30/2015 09:08 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 16:06, Javier Martinez Canillas wrote: >> Hello, >> >> On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >>> On 30.09.2015 15:58, Kukjin Kim wrote: >> >> [snip] >> > > Could you add the new compatible and

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hi, On Wed, Sep 30, 2015 at 4:44 PM, Krzysztof Kozlowski wrote: >> Switching the default meaning of "google,snow" to Rev5 is probably not >> something we'd ever want to do, since it could confuse "rev3" boards >> (which should be serviced by the rev4 dts). From comments

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 01.10.2015 01:17, Doug Anderson wrote: > Hi, > > On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski > wrote: >> Now the exynos5250-snow.dts means in fact Rev4... but there is no >> information in DTS about it. I think adding compatible >> "google,snow-rev4" makes

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hi, On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski wrote: > Now the exynos5250-snow.dts means in fact Rev4... but there is no > information in DTS about it. I think adding compatible > "google,snow-rev4" makes sense: > 1. For informational purposes (this could be

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Em Tue, 29 Sep 2015 13:57:35 +0200 Javier Martinez Canillas escreveu: > There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: > Rev4 and Rev5. The only difference between these 2 revisions is the codec, > Rev4 has a max98095 codec while Rev5 has a

[PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: Rev4 and Rev5. The only difference between these 2 revisions is the codec, Rev4 has a max98095 codec while Rev5 has a max98090. Mainline only supports Rev4 so this patch moves the common device nodes to a DTSI file and

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 29.09.2015 20:57, Javier Martinez Canillas wrote: > There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: > Rev4 and Rev5. The only difference between these 2 revisions is the codec, > Rev4 has a max98095 codec while Rev5 has a max98090. > > Mainline only supports Rev4 so

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Javier, On Tue, Sep 29, 2015 at 4:57 AM, Javier Martinez Canillas wrote: > There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: > Rev4 and Rev5. The only difference between these 2 revisions is the codec, > Rev4 has a max98095 codec while Rev5 has a