Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Ulf Hansson
On 20 November 2014 01:35, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 19, 2014 09:54:00 AM Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Grygorii Strashko
On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources - pm_runtime_enable() Well, and now how the driver knows if the device is on before accessing

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Ulf Hansson
On 20 November 2014 13:17, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources -

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Grygorii Strashko
On 11/20/2014 03:01 PM, Ulf Hansson wrote: On 20 November 2014 13:17, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/19/2014 10:54 AM, Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-20 Thread Rafael J. Wysocki
On Thursday, November 20, 2014 11:13:01 AM Ulf Hansson wrote: On 20 November 2014 01:35, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 19, 2014 09:54:00 AM Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() -

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-19 Thread Ulf Hansson
[...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources - pm_runtime_enable() Well, and now how the driver knows if the device is on before accessing it? In this case the driver don't need to

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-19 Thread Rafael J. Wysocki
On Wednesday, November 19, 2014 09:54:00 AM Ulf Hansson wrote: [...] Scenario 5), a platform driver with/without runtime PM callbacks. -probe() - do some initialization - may fetch handles to runtime PM resources - pm_runtime_enable() Well, and now how the driver knows if the

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Ulf Hansson
[...] It would not be the same for all buses. Each bus will have its own way of recognizing whether or not a driver has been probed (i.e., by checking some field in the bus-specific part of the device structure). However, is it allowed to call

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Alan Stern
On Mon, 17 Nov 2014, Dmitry Torokhov wrote: However, is it allowed to call pm_runtime_get_sync() on devices that didn't issue pm_runtime_enable()? Yes. But the bus has to issue pm_runtime_enable() before probing the driver, because the driver will expect runtime PM to work properly

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 11:13:28AM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: However, is it allowed to call pm_runtime_get_sync() on devices that didn't issue pm_runtime_enable()? Yes. But the bus has to issue pm_runtime_enable() before probing the

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Alan Stern
On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question then: pm_runtime_get_noresume() does literally this: atomic_inc(dev-power.usage_count); So who is responsible for actually waking up parent device and/or power domain? Is it simply missing because we did not really

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question then: pm_runtime_get_noresume() does literally this: atomic_inc(dev-power.usage_count); So who is responsible for actually waking up parent device and/or

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 09:55:15 AM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question then: pm_runtime_get_noresume() does literally this: atomic_inc(dev-power.usage_count);

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 09:55:15 AM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question then:

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 03:05:08 PM Ulf Hansson wrote: [...] It would not be the same for all buses. Each bus will have its own way of recognizing whether or not a driver has been probed (i.e., by checking some field in the bus-specific part of the device

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 12:04:38 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 09:55:15 AM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 12:04:38 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 09:55:15 AM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 12:04:38 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 01:02:29 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 12:04:38 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 10:58:17PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 01:02:29 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 10:58:17 PM Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 01:02:29 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November

[PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Ulf Hansson
The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a pm_runtime_get_sync() while probing their devices. Instead, once they have turned on their PM resourses during -probe() and are ready to handle I/O, these invokes pm_runtime_set_active() to

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Russell King - ARM Linux
On Mon, Nov 17, 2014 at 04:19:10PM +0100, Ulf Hansson wrote: The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a pm_runtime_get_sync() while probing their devices. Instead, once they have turned on their PM resourses during -probe() and

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Russell King - ARM Linux
On Mon, Nov 17, 2014 at 06:54:44PM +0200, Grygorii Strashko wrote: I'd be very appreciated if you would be able to clarify one point to me as I'm not familiar with amba hw? I've found at least 2 AMBA drivers where secondary clock is used to enable/disable device in addition to apb_pclk: -

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Kevin Hilman
Ulf Hansson ulf.hans...@linaro.org writes: The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a pm_runtime_get_sync() while probing their devices. Instead, once they have turned on their PM resourses during -probe() and are ready to

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Alan Stern
On Mon, 17 Nov 2014, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a pm_runtime_get_sync() while probing their devices. Instead, once they have turned on their PM

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 11:06 AM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 17 Nov 2014, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Alan Stern
On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler. The bus does _get_noresume() to make sure the device won't be runtime suspended while the probe routine is running. It doesn't do _get_sync(), because that would end up calling

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler. The bus does _get_noresume() to make sure the device won't be runtime suspended while the probe routine is

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Alan Stern
On Mon, 17 Nov 2014, Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler. The bus does _get_noresume() to make sure the device won't be

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 03:49:14PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler.

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Alan Stern
On Mon, 17 Nov 2014, Dmitry Torokhov wrote: When the runtime PM core invokes a power domain's callback routine, what does the domain's routine usually do? Does it go ahead and invoke the driver's callback? Or does it try to invoke the subsystem's callback? Obviously this depends on

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 04:44:56PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: When the runtime PM core invokes a power domain's callback routine, what does the domain's routine usually do? Does it go ahead and invoke the driver's callback? Or does it try to

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Alan Stern
On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call pm_generic_runtime_resume() which ends up fetching driver's callbacks. Maybe pm_generic_runtime_*() need be a bit smarter? No, the bus subsystem needs to be smarter. It shouldn't call

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call pm_generic_runtime_resume() which ends up fetching driver's callbacks. Maybe pm_generic_runtime_*() need be a bit smarter? No, the bus subsystem

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Rafael J. Wysocki
On Monday, November 17, 2014 02:17:00 PM Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call pm_generic_runtime_resume() which ends up fetching driver's callbacks. Maybe

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 12:28:26AM +0100, Rafael J. Wysocki wrote: On Monday, November 17, 2014 02:17:00 PM Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Rafael J. Wysocki
On Monday, November 17, 2014 03:26:04 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:28:26AM +0100, Rafael J. Wysocki wrote: On Monday, November 17, 2014 02:17:00 PM Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Rafael J. Wysocki
On Tuesday, November 18, 2014 01:26:38 AM Rafael J. Wysocki wrote: On Monday, November 17, 2014 03:26:04 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:28:26AM +0100, Rafael J. Wysocki wrote: On Monday, November 17, 2014 02:17:00 PM Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at