Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Viresh Kumar
On 31 January 2013 21:42, Viresh Kumar wrote: > On 31 January 2013 21:37, Tomasz Figa wrote: >> Hmm. Now as I think of it, there might be another confusing aspect: >> >> Could you explain what "sw coordination" and "any coordination" mean? >> I mean specifically cpufreq_policy.cpus and cpufreq_po

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Viresh Kumar
On 31 January 2013 21:37, Tomasz Figa wrote: > Hmm. Now as I think of it, there might be another confusing aspect: > > Could you explain what "sw coordination" and "any coordination" mean? > I mean specifically cpufreq_policy.cpus and cpufreq_policy.related_cpus > masks. Check this out: https://

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Tomasz Figa
On Thursday 31 of January 2013 20:46:10 Viresh Kumar wrote: > On 31 January 2013 20:34, Tomasz Figa wrote: > > Well, the fact that it isn't used at the moment doesn't mean that it > > shouldn't be set correctly. The field is present in the structure and > > has a set of defined values - one of whi

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Viresh Kumar
On 31 January 2013 20:34, Tomasz Figa wrote: > Well, the fact that it isn't used at the moment doesn't mean that it > shouldn't be set correctly. The field is present in the structure and has > a set of defined values - one of which should be selected. For example, > I can imagine some governor ta

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Tomasz Figa
On Thursday 31 of January 2013 20:22:50 Viresh Kumar wrote: > On 31 January 2013 20:15, Tomasz Figa wrote: > > On Thursday 31 of January 2013 09:50:37 Viresh Kumar wrote: > >> > + policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; > >> > >> I couldn't understand the use of this change.

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Viresh Kumar
On 31 January 2013 20:15, Tomasz Figa wrote: > On Thursday 31 of January 2013 09:50:37 Viresh Kumar wrote: >> > + policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; >> I couldn't understand the use of this change. Can you please explain ? > > All cores on Exynos SoCs share the same cloc

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-31 Thread Tomasz Figa
Hi Viresh, On Thursday 31 of January 2013 09:50:37 Viresh Kumar wrote: > On Tue, Nov 13, 2012 at 2:56 PM, Tomasz Figa wrote: > > On Exynos SoCs all cores share the same frequency setting, so changing > > frequency of one core will affect rest of cores. > > > > This patch modifies the exynos-cpuf

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2013-01-30 Thread Viresh Kumar
On Tue, Nov 13, 2012 at 2:56 PM, Tomasz Figa wrote: > On Exynos SoCs all cores share the same frequency setting, so changing > frequency of one core will affect rest of cores. > > This patch modifies the exynos-cpufreq driver to inform cpufreq core > about this behavior and broadcast frequency cha

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-22 Thread Rafael J. Wysocki
On Wednesday, November 21, 2012 10:23:02 PM Tomasz Figa wrote: > Hi Rafael, > > On Wednesday 21 of November 2012 21:47:42 Rafael J. Wysocki wrote: > > On Wednesday, November 21, 2012 02:52:26 PM Tomasz Figa wrote: > > > On Tuesday 13 of November 2012 10:26:12 Tomasz Figa wrote: > > > > On Exynos S

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-22 Thread Tomasz Figa
Hi Rafael, On Wednesday 21 of November 2012 21:47:42 Rafael J. Wysocki wrote: > On Wednesday, November 21, 2012 02:52:26 PM Tomasz Figa wrote: > > On Tuesday 13 of November 2012 10:26:12 Tomasz Figa wrote: > > > On Exynos SoCs all cores share the same frequency setting, so > > > changing > > > fre

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-21 Thread Rafael J. Wysocki
On Wednesday, November 21, 2012 02:52:26 PM Tomasz Figa wrote: > On Tuesday 13 of November 2012 10:26:12 Tomasz Figa wrote: > > On Exynos SoCs all cores share the same frequency setting, so changing > > frequency of one core will affect rest of cores. > > > > This patch modifies the exynos-cpufreq

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-21 Thread Tomasz Figa
On Tuesday 13 of November 2012 10:26:12 Tomasz Figa wrote: > On Exynos SoCs all cores share the same frequency setting, so changing > frequency of one core will affect rest of cores. > > This patch modifies the exynos-cpufreq driver to inform cpufreq core > about this behavior and broadcast freque

[PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-13 Thread Tomasz Figa
On Exynos SoCs all cores share the same frequency setting, so changing frequency of one core will affect rest of cores. This patch modifies the exynos-cpufreq driver to inform cpufreq core about this behavior and broadcast frequency change notifications for all cores. Signed-off-by: Tomasz Figa