[PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Padmavathi Venna
This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic dma incompatible platforms. Signed-off-by: Padmavathi Venna padm...@samsung.com --- Based on Vinod Koul next branch. drivers/dma/of-dma.c |8

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Rob Herring
On 03/05/2013 03:25 AM, Padmavathi Venna wrote: This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic dma incompatible platforms. Signed-off-by: Padmavathi Venna padm...@samsung.com NAK.

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Padma Venkat
On Tue, Mar 5, 2013 at 3:13 PM, Rob Herring robherri...@gmail.com wrote: On 03/05/2013 03:25 AM, Padmavathi Venna wrote: This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic dma incompatible

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Arnd Bergmann
On Tuesday 05 March 2013 03:43:52 Rob Herring wrote: On 03/05/2013 03:25 AM, Padmavathi Venna wrote: This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic dma incompatible platforms.

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Rob Herring
On 03/05/2013 04:15 AM, Arnd Bergmann wrote: On Tuesday 05 March 2013 03:43:52 Rob Herring wrote: On 03/05/2013 03:25 AM, Padmavathi Venna wrote: This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Arnd Bergmann
On Tuesday 05 March 2013, Rob Herring wrote: Why would you call of_dma_controller_register() for a dma engine that does not support slave channels, when that is the only purpose of that interface? Well maybe then that function should be allowed to fail without erroring out. I just fixed