Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-13 Thread Mark Brown
On Fri, Jul 13, 2012 at 10:37:12AM +0200, Wolfram Sang wrote: > On Mon, Jul 09, 2012 at 02:58:10PM +0100, Mark Brown wrote: > > The devm_ versions of the API aren't exported there yet and there's a > > bug fix pending too but Russell and Mike have ignored the patches thus > > far. > I'd rather wa

Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-13 Thread Wolfram Sang
On Mon, Jul 09, 2012 at 02:58:10PM +0100, Mark Brown wrote: > On Mon, Jul 09, 2012 at 03:52:29PM +0200, Wolfram Sang wrote: > > On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote: > > > A small code saving and less error handling to worry about. > > > > Signed-off-by: Mark Brown > > > Wh

Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-09 Thread Mark Brown
On Mon, Jul 09, 2012 at 03:52:29PM +0200, Wolfram Sang wrote: > On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote: > > A small code saving and less error handling to worry about. > > Signed-off-by: Mark Brown > What about devm for the clocks, too? The devm_ versions of the API aren't e

Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-09 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote: > A small code saving and less error handling to worry about. > > Signed-off-by: Mark Brown What about devm for the clocks, too? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Indus

[PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-06-28 Thread Mark Brown
A small code saving and less error handling to worry about. Signed-off-by: Mark Brown --- drivers/i2c/busses/i2c-s3c2410.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.