Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-02-11 Thread Olof Johansson
Hi, It looks like the bindings here are still completely unsettled, or at least unimplemented -- there seems to be a preference for an encoding similar to how interrupts/gpios/clks work. I think that wouldn't be a bad idea. For the case of this particular driver and connections, it'd just mean

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-29 Thread Naveen Krishna Ch
On 26 January 2013 16:27, Jonathan Cameron ji...@kernel.org wrote: On 01/24/2013 04:58 AM, Naveen Krishna Chatradhi wrote: This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-26 Thread Jonathan Cameron
On 01/24/2013 04:58 AM, Naveen Krishna Chatradhi wrote: This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Just a quick general comment on patch

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 01:42 AM, Doug Anderson wrote: Lars, On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote: Few doubts regarding the mappings and child device handling. Kindly, suggest me better methods. The patch looks mostly good now. As for the mappings, the problem is

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Naveen Krishna Ch
On 24 January 2013 15:24, Lars-Peter Clausen l...@metafoo.de wrote: On 01/24/2013 01:42 AM, Doug Anderson wrote: Lars, On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote: Few doubts regarding the mappings and child device handling. Kindly, suggest me better

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Doug Anderson
Lars, Thank you for your comments / thoughts... On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote: adc: adc@12D1 { #io-channel-cells = 1; io-channel-output-names = adc1, adc2, ...; ncp15wb473@0 { compatible =

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 03:20 PM, Naveen Krishna Ch wrote: On 24 January 2013 15:24, Lars-Peter Clausen l...@metafoo.de wrote: On 01/24/2013 01:42 AM, Doug Anderson wrote: Lars, On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote: Few doubts regarding the mappings and child

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 05:12 PM, Doug Anderson wrote: Lars, Thank you for your comments / thoughts... Hi, On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote: adc: adc@12D1 { #io-channel-cells = 1; io-channel-output-names = adc1, adc2, ...;

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Tomasz Figa
Hi, On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote: On 01/24/2013 05:12 PM, Doug Anderson wrote: Lars, Thank you for your comments / thoughts... Hi, On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote: adc: adc@12D1 {

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 08:15 PM, Tomasz Figa wrote: Hi, On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote: On 01/24/2013 05:12 PM, Doug Anderson wrote: Lars, Thank you for your comments / thoughts... Hi, On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote:

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Doug Anderson
Lars, On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote: Few doubts regarding the mappings and child device handling. Kindly, suggest me better methods. The patch looks mostly good now. As for the mappings, the problem is that we currently do not have any device tree

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Naveen Krishna Chatradhi
This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Changes

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Naveen Krishna Chatradhi
This patch add an ADC IP found on EXYNOS5250 and EXYNOS5410 SoCs from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Changes

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Lars-Peter Clausen
Hi, On 01/21/2013 02:37 PM, Naveen Krishna Chatradhi wrote: This patch add an ADC IP found on EXYNOS5 series socs from Samsung. Also adds the Documentation for device tree bindings. [...] diff --git a/drivers/iio/adc/exynos5_adc.c b/drivers/iio/adc/exynos5_adc.c new file mode 100644 index

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Naveen Krishna Ch
Hello All, On 22 January 2013 15:14, Lars-Peter Clausen l...@metafoo.de wrote: Hi, On 01/21/2013 02:37 PM, Naveen Krishna Chatradhi wrote: This patch add an ADC IP found on EXYNOS5 series socs from Samsung. Also adds the Documentation for device tree bindings. [...] diff --git

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Naveen Krishna Chatradhi
This patch add an ADC IP found on EXYNOS5 series socs from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Few doubts regarding

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Naveen Krishna Chatradhi
This patch add an ADC IP found on EXYNOS5 series socs from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Changes since v2: 1.

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-21 Thread Naveen Krishna Chatradhi
This patch add an ADC IP found on EXYNOS5 series socs from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- .../bindings/arm/samsung/exynos5-adc.txt | 20 + drivers/iio/adc/Kconfig