RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-21 Thread Seungwon Jeon
On Wed, May 21, 2014, Doug Anderson wrote: > Seungwon, > > On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon wrote: > >> > >> >> + } else { > >> > >> >> + /* > >> > >> >> +* If we don't have a command > >> > >> >> c

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-20 Thread Doug Anderson
Seungwon, On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon wrote: >> > >> >> + } else { >> > >> >> + /* >> > >> >> +* If we don't have a command >> > >> >> complete now we'll >> > >> >> +

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-19 Thread Seungwon Jeon
On Tue, May 13, 2014, Seungwon Jeon wrote: > Hi Doug, > > On Tue, May 13, 2014, Doug Anderson wrote: > > Seungwon, > > > > On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote: > > > On Fri, May 09, 2014, Sonny Rao wrote: > > >> On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar > > >> wrote: > > >>

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-19 Thread Seungwon Jeon
On Sat, May 17, 2014, Doug Anderson wrote: > Seungwon, > > On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon wrote: > > On Wed, May 14, 2014, Doug Anderson wrote: > >> Seungwon, > >> > >> On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon > >> wrote: > >> > Hi Doug, > >> > > >> > On Tue, May 13, 2014,

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-16 Thread Doug Anderson
Seungwon, On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon wrote: > On Wed, May 14, 2014, Doug Anderson wrote: >> Seungwon, >> >> On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon wrote: >> > Hi Doug, >> > >> > On Tue, May 13, 2014, Doug Anderson wrote: >> >> Seungwon, >> >> >> >> On Sat, May 10, 201

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-15 Thread Seungwon Jeon
On Wed, May 14, 2014, Doug Anderson wrote: > Seungwon, > > On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon wrote: > > Hi Doug, > > > > On Tue, May 13, 2014, Doug Anderson wrote: > >> Seungwon, > >> > >> On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon > >> wrote: > >> > On Fri, May 09, 2014, Sonny

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-13 Thread Doug Anderson
Seungwon, On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon wrote: > Hi Doug, > > On Tue, May 13, 2014, Doug Anderson wrote: >> Seungwon, >> >> On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote: >> > On Fri, May 09, 2014, Sonny Rao wrote: >> >> On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar >>

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-12 Thread Seungwon Jeon
Hi Doug, On Tue, May 13, 2014, Doug Anderson wrote: > Seungwon, > > On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote: > > On Fri, May 09, 2014, Sonny Rao wrote: > >> On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote: > >> > Any comments on this patch? > >> > > >> > >> I'll just add that w

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-12 Thread Doug Anderson
Seungwon, On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote: > On Fri, May 09, 2014, Sonny Rao wrote: >> On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote: >> > Any comments on this patch? >> > >> >> I'll just add that without this fix, running the tuning loop for UHS >> modes is not reliab

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-10 Thread Seungwon Jeon
On Fri, May 09, 2014, Sonny Rao wrote: > On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote: > > Any comments on this patch? > > > > I'll just add that without this fix, running the tuning loop for UHS > modes is not reliable on dw_mmc because errors will happen and you > will eventually hit thi

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote: > Any comments on this patch? > I'll just add that without this fix, running the tuning loop for UHS modes is not reliable on dw_mmc because errors will happen and you will eventually hit this race and hang. This can happen any time there is t

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-08 Thread Yuvaraj Kumar
Any comments on this patch? On Thu, Mar 27, 2014 at 11:48 AM, Yuvaraj Kumar C D wrote: > From: Doug Anderson > > If we happened to get a data error at just the wrong time the dw_mmc > driver could get into a state where it would never complete its > request. That would leave the caller just han

[PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-03-26 Thread Yuvaraj Kumar C D
From: Doug Anderson If we happened to get a data error at just the wrong time the dw_mmc driver could get into a state where it would never complete its request. That would leave the caller just hanging there. We fix this two ways and both of the two fixes on their own appear to fix the problem