Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-22 Thread Alim Akhtar
Hi Tomasz, On Mon, Sep 22, 2014 at 4:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 22.09.2014 01:10, Alim Akhtar wrote: [snip] As you said there is no support for ioremap on ARM, so this is not tested on ARM. Don't forget that this driver is primarily targeted for ARM platforms

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-21 Thread Alim Akhtar
Hi Tomasz, Thanks for your valuable feedback on this patch. Please see my comments inline. On Sat, Sep 20, 2014 at 7:09 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Alim, Please see my comments inline. On 16.09.2014 13:32, Alim Akhtar wrote: Add earlycon support for the samsung serial

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-21 Thread Tomasz Figa
On 21.09.2014 16:36, Alim Akhtar wrote: Hi Tomasz, Thanks for your valuable feedback on this patch. You're welcome. diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 5ae8608..e01c0e5 100644 --- a/Documentation/kernel-parameters.txt +++

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-21 Thread Alim Akhtar
Hi Tomasz, On Sun, Sep 21, 2014 at 10:54 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 21.09.2014 16:36, Alim Akhtar wrote: Hi Tomasz, Thanks for your valuable feedback on this patch. You're welcome. diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-21 Thread Tomasz Figa
On 22.09.2014 01:10, Alim Akhtar wrote: [snip] As you said there is no support for ioremap on ARM, so this is not tested on ARM. Don't forget that this driver is primarily targeted for ARM platforms (versus just one ARM64-based Exynos7), so either this feature should be clearly added as

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-20 Thread Alim Akhtar
Just realized that linux-arm-kernel email-id was wrongly typed. CCing the correct linux-arm-kernel email-id now. Sorry for the noise. On Tue, Sep 16, 2014 at 5:02 PM, Alim Akhtar alim.akh...@samsung.com wrote: Add earlycon support for the samsung serial port. This allows enabling the samsung

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-20 Thread Tomasz Figa
Hi Alim, Please see my comments inline. On 16.09.2014 13:32, Alim Akhtar wrote: Add earlycon support for the samsung serial port. This allows enabling the samsung serial port for console when early_params are parse and processed. Signed-off-by: Alim Akhtar alim.akh...@samsung.com ---

Re: [PATCH] tty/serial: samsung: Add earlycon support

2014-09-20 Thread Rob Herring
On 09/20/2014 08:39 AM, Tomasz Figa wrote: Hi Alim, Please see my comments inline. On 16.09.2014 13:32, Alim Akhtar wrote: Add earlycon support for the samsung serial port. This allows enabling the samsung serial port for console when early_params are parse and processed.

[PATCH] tty/serial: samsung: Add earlycon support

2014-09-16 Thread Alim Akhtar
Add earlycon support for the samsung serial port. This allows enabling the samsung serial port for console when early_params are parse and processed. Signed-off-by: Alim Akhtar alim.akh...@samsung.com --- Documentation/kernel-parameters.txt |6 ++ drivers/tty/serial/Kconfig |