Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-30 Thread Wim Van Sebroeck
Hi, Yes, if we set wdt_count value properly before request_irq, it's fine. Anyway, as registering the device (watchdog_register_device()) may be done after request_irq without any problem, moving request_irq right before it, not after it should be fine. So what that be attached patch then?

Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-30 Thread MyungJoo Ham
On Tue, Jan 31, 2012 at 4:01 AM, Wim Van Sebroeck w...@iguana.be wrote: Hi, Yes, if we set wdt_count value properly before request_irq, it's fine. Anyway, as registering the device (watchdog_register_device()) may be done after request_irq without any problem, moving request_irq right

Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-16 Thread MyungJoo Ham
On Sat, Jan 14, 2012 at 6:45 AM, Wim Van Sebroeck w...@iguana.be wrote: Hi, On Fri, Jan 13, 2012 at 11:11:17AM +, Russell King - ARM Linux wrote: On Fri, Jan 13, 2012 at 02:14:23PM +0900, MyungJoo Ham wrote: Probe function of s3c2410 watchdog calls request_irq before initializing

Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-13 Thread Russell King - ARM Linux
On Fri, Jan 13, 2012 at 02:14:23PM +0900, MyungJoo Ham wrote: Probe function of s3c2410 watchdog calls request_irq before initializing required value (wdt_count). This incurs resetting watchdog counter value and watchdog-reboot during booting up. This patch addresses such an issue by calling

[PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-12 Thread MyungJoo Ham
Probe function of s3c2410 watchdog calls request_irq before initializing required value (wdt_count). This incurs resetting watchdog counter value and watchdog-reboot during booting up. This patch addresses such an issue by calling request_irq later. Error handling in probe function and calling