Re: [PATCH 1/2] mfd: Add support for MAX77686.

2012-05-10 Thread Yadwinder Singh Brar
Hi Mark, On Wed, May 9, 2012 at 11:57 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 09, 2012 at 09:54:54PM +0530, Yadwinder Singh wrote: +int max77686_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest) +{ +     int ret; + +     ret = i2c_smbus_read_byte_data(i2c,

[PATCH 1/2] mfd: Add support for MAX77686.

2012-05-09 Thread Yadwinder Singh
From: Yadwinder Singh Brar yadi.b...@samsung.com MAX77686 is a mulitifunction device with PMIC, RTC and Charger on chip. This driver provides common support for accessing the device. This is initial version of this driver that supports to enable the chip with its primary I2C bus.It also includes

Re: [PATCH 1/2] mfd: Add support for MAX77686.

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 09:54:54PM +0530, Yadwinder Singh wrote: +int max77686_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest) +{ + int ret; + + ret = i2c_smbus_read_byte_data(i2c, reg); + if (ret 0) It would really be better if this used the regmap API - the regulator API

Re: [PATCH 1/2] mfd: Add support for MAX77686.

2012-05-09 Thread Chanwoo Choi
Hi Mark, We have posted following patch on the last week and received your comment. So, We are implementing that use regmap API for I2C and modify MFD driver of MAX77686 according to your comment. [PATCH] MFD : add MAX77686 mfd driver - https://lkml.org/lkml/2012/4/30/96 Additionally, We are