Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Marc Zyngier
On 11/02/14 23:36, Olof Johansson wrote: Hi, Besides what Mark Rutland already commented on: On Mon, Feb 10, 2014 at 10:29 PM, Kukjin Kim kgene@samsung.com wrote: +/ { + model = SAMSUNG GH7; + compatible = samsung,gh7; Model and compatible in the dtsi should probably

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Mark Rutland
+ gic: interrupt-controller@1C00 { + compatible = arm,cortex-a15-gic, arm,cortex-a9-gic; This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc? arm,cortex-a9-gic is definitely wrong (the A9 GIC doesn't have the virt

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Marc Zyngier
On 12/02/14 11:29, Mark Rutland wrote: + gic: interrupt-controller@1C00 { + compatible = arm,cortex-a15-gic, arm,cortex-a9-gic; This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc? arm,cortex-a9-gic is definitely wrong

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Kukjin Kim
On 02/12/14 20:40, Marc Zyngier wrote: On 12/02/14 11:29, Mark Rutland wrote: + gic: interrupt-controller@1C00 { + compatible = arm,cortex-a15-gic, arm,cortex-a9-gic; This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Kukjin Kim
On 02/12/14 03:15, Mark Rutland wrote: On Tue, Feb 11, 2014 at 06:29:41AM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kimkgene@samsung.com Reviewed-by: Thomas Abrahamthomas...@samsung.com Cc: Catalin Marinascatalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 108

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Kukjin Kim
On 02/12/14 08:36, Olof Johansson wrote: Hi, Hi Olof, Besides what Mark Rutland already commented on: OK, thanks :-) On Mon, Feb 10, 2014 at 10:29 PM, Kukjin Kimkgene@samsung.com wrote: +/ { + model = SAMSUNG GH7; + compatible = samsung,gh7; Model and compatible in

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-11 Thread Mark Rutland
On Tue, Feb 11, 2014 at 06:29:41AM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-11 Thread Olof Johansson
Hi, Besides what Mark Rutland already commented on: On Mon, Feb 10, 2014 at 10:29 PM, Kukjin Kim kgene@samsung.com wrote: +/ { + model = SAMSUNG GH7; + compatible = samsung,gh7; Model and compatible in the dtsi should probably always be overridden by a dts that includes it,

[PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-10 Thread Kukjin Kim
Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++ 2 files