Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-19 Thread Tomasz Figa
On 19.05.2014 05:30, Tushar Behera wrote: On 15 May 2014 19:37, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, Tushar, On 15.05.2014 15:44, Rahul Sharma wrote: Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-18 Thread Tushar Behera
On 15 May 2014 19:37, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, Tushar, On 15.05.2014 15:44, Rahul Sharma wrote: Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can be reused to support clkout. I see 3 major

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-15 Thread Rahul Sharma
Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can be reused to support clkout. I see 3 major problem here: 1) Clkout - (Mux + Gate). You clubbed mux and gate together, and exposing as a single clock which is something

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-15 Thread Tomasz Figa
Hi Rahul, Tushar, On 15.05.2014 15:44, Rahul Sharma wrote: Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can be reused to support clkout. I see 3 major problem here: 1) Clkout - (Mux + Gate). You clubbed mux

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-15 Thread Rahul Sharma
On 15 May 2014 19:37, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, Tushar, On 15.05.2014 15:44, Rahul Sharma wrote: Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can be reused to support clkout. I see 3 major

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-11 Thread Tushar Behera
On 05/10/2014 09:21 AM, Pankaj Dubey wrote: On 05/09/2014 10:00 PM, Tushar Behera wrote: All SoC in Exynos-series have a clock with name XCLKOUT to provide debug information about various clocks available in the SoC. The register controlling the MUX and GATE of this clock is provided within

[PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-09 Thread Tushar Behera
All SoC in Exynos-series have a clock with name XCLKOUT to provide debug information about various clocks available in the SoC. The register controlling the MUX and GATE of this clock is provided within PMU domain. Since PMU domain can't be dedicatedly mapped by every driver, the register needs to

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-09 Thread Pankaj Dubey
On 05/09/2014 10:00 PM, Tushar Behera wrote: All SoC in Exynos-series have a clock with name XCLKOUT to provide debug information about various clocks available in the SoC. The register controlling the MUX and GATE of this clock is provided within PMU domain. Since PMU domain can't be