Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-18 Thread Sachin Kamat
On 17 October 2012 21:27, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 10/17/2012 05:35 PM, Sachin Kamat wrote: Most of the s5p-* drivers have already added support for clk_(un)prepare. Thus most of your changes in this patch are not needed. I seem to have only missed fimc-mdevice.c,

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
Hi Sachin, On 10/17/2012 01:11 PM, Sachin Kamat wrote: Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare as required by the common clock framework. I think this statement is misleading. In my understanding it is not the common clock framework requirement to use

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sachin Kamat
Hi Sylwester, Thanks for the review. On 17 October 2012 20:03, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Sachin, On 10/17/2012 01:11 PM, Sachin Kamat wrote: Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare as required by the common clock framework.

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
On 10/17/2012 05:35 PM, Sachin Kamat wrote: Most of the s5p-* drivers have already added support for clk_(un)prepare. Thus most of your changes in this patch are not needed. I seem to have only missed fimc-mdevice.c, other modules are already reworked I did not find these changes in your