Move out code from enable and disable routines to prepare
and unprepare routines, so that functionality is properly
distributed across all the panel functions.

Signed-off-by: Ajay Kumar <ajaykumar...@samsung.com>
---
 drivers/gpu/drm/panel/panel-s6e8aa0.c |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c 
b/drivers/gpu/drm/panel/panel-s6e8aa0.c
index 60694dd..cf4be7f 100644
--- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
+++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
@@ -889,6 +889,11 @@ static int s6e8aa0_power_off(struct s6e8aa0 *ctx)
 
 static int s6e8aa0_disable(struct drm_panel *panel)
 {
+       return 0;
+}
+
+static int s6e8aa0_unprepare(struct drm_panel *panel)
+{
        struct s6e8aa0 *ctx = panel_to_s6e8aa0(panel);
 
        s6e8aa0_dcs_write_seq_static(ctx, MIPI_DCS_ENTER_SLEEP_MODE);
@@ -900,18 +905,8 @@ static int s6e8aa0_disable(struct drm_panel *panel)
        return s6e8aa0_power_off(ctx);
 }
 
-static int s6e8aa0_unprepare(struct drm_panel *panel)
-{
-       return 0;
-}
-
 static int s6e8aa0_prepare(struct drm_panel *panel)
 {
-       return 0;
-}
-
-static int s6e8aa0_enable(struct drm_panel *panel)
-{
        struct s6e8aa0 *ctx = panel_to_s6e8aa0(panel);
        int ret;
 
@@ -923,11 +918,16 @@ static int s6e8aa0_enable(struct drm_panel *panel)
        ret = ctx->error;
 
        if (ret < 0)
-               s6e8aa0_disable(panel);
+               s6e8aa0_unprepare(panel);
 
        return ret;
 }
 
+static int s6e8aa0_enable(struct drm_panel *panel)
+{
+       return 0;
+}
+
 static int s6e8aa0_get_modes(struct drm_panel *panel)
 {
        struct drm_connector *connector = panel->connector;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to