RE: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Kukjin Kim
Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ...

Re: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 06:38:36PM +0900, Kukjin Kim wrote: Julia Lawall wrote: Signed-off-by: Julia Lawall julia.law...@lip6.fr Acked-by: Kukjin Kim kgene@samsung.com (Cc'ed Mark Brown who is handling spi for a moment) Please resend the patch to me so I can apply this.

Re: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when

Re: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 01:42:47PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Initialize return variable before exiting on an error path. Applied, thanks. signature.asc Description: Digital signature

[PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-19 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when