Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-16 Thread Mark Brown
On Tue, May 15, 2012 at 07:17:11PM +0530, Yadwinder Singh Brar wrote: > On Thu, May 10, 2012 at 12:17 AM, Mark Brown > > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > >> +     if (iodev->dev->of_node) { > >> +             ret = max77686_pmic_dt_parse_pdata(iodev, pdata); > >>

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-15 Thread Yadwinder Singh Brar
Hi Mark, On Thu, May 10, 2012 at 12:17 AM, Mark Brown wrote: > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > >> +/* Voltage maps in mV */ >> +static const struct voltage_map_desc ldo_voltage_map_desc = { >> +     .min = 800,     .max = 3950,    .step = 50,     .n_bits = 6, >>

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-10 Thread Yadwinder Singh Brar
Hi Mark, On Thu, May 10, 2012 at 3:04 PM, Mark Brown wrote: > On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote: >> On Thu, May 10, 2012 at 12:17 AM, Mark Brown >> > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > >> >> +     [MAX77686_EN32KHZ_AP] = NULL, >>

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-10 Thread Mark Brown
On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote: > On Thu, May 10, 2012 at 12:17 AM, Mark Brown > > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > >> +     [MAX77686_EN32KHZ_AP] = NULL, > >> +     [MAX77686_EN32KHZ_CP] = NULL, > > Now that the generic cloc

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-10 Thread Yadwinder Singh Brar
Hi Sylwester, On Thu, May 10, 2012 at 1:24 AM, Sylwester Nawrocki wrote: > Hi, > > just a few nitpicks... > > > On 05/09/2012 06:24 PM, Yadwinder Singh wrote: >> >> From: Yadwinder Singh Brar >> >> Add support for PMIC/regulator portion of MAX77686 multifunction device. >> MAX77686 provides LDOs

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-10 Thread Yadwinder Singh Brar
Hi Mark, On Thu, May 10, 2012 at 12:17 AM, Mark Brown wrote: > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > >> +/* Voltage maps in mV */ >> +static const struct voltage_map_desc ldo_voltage_map_desc = { >> +     .min = 800,     .max = 3950,    .step = 50,     .n_bits = 6, >>

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-09 Thread Sylwester Nawrocki
Hi, just a few nitpicks... On 05/09/2012 06:24 PM, Yadwinder Singh wrote: From: Yadwinder Singh Brar Add support for PMIC/regulator portion of MAX77686 multifunction device. MAX77686 provides LDOs[1-26] and BUCKs[1-9]. This is initial release of driver which supports setting and getting the vo

Re: [PATCH 2/2] regulator: Add support for MAX77686.

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: > +/* Voltage maps in mV */ > +static const struct voltage_map_desc ldo_voltage_map_desc = { > + .min = 800, .max = 3950,.step = 50, .n_bits = 6, > +}; /* LDO3 ~ 5, 9 ~ 14, 16 ~ 26 */ Hrm, f

[PATCH 2/2] regulator: Add support for MAX77686.

2012-05-09 Thread Yadwinder Singh
From: Yadwinder Singh Brar Add support for PMIC/regulator portion of MAX77686 multifunction device. MAX77686 provides LDOs[1-26] and BUCKs[1-9]. This is initial release of driver which supports setting and getting the voltage of a regulator with I2C interface. Signed-off-by: Yadwinder Singh Brar