On 8 February 2013 08:56, amit kachhap wrote:
> + dvfs_info->dvfs_init = true;
why do you need this ?
>>> This is added to synchronize the interrupts.
>>
>> How? You are setting it once in init() and not touching it afterwards. :)
>
> Yes but during init also if interrupts star
On Thu, Feb 7, 2013 at 6:42 PM, Viresh Kumar wrote:
> On 8 February 2013 00:38, amit kachhap wrote:
>> Hi Viresh,
>>
>> Thanks for the detailed review. Will try to handle them in the next version,
>
> np. I haven't seen reply to few questions, you missed them or accept them.
Many of your comment
On 8 February 2013 00:38, amit kachhap wrote:
> Hi Viresh,
>
> Thanks for the detailed review. Will try to handle them in the next version,
np. I haven't seen reply to few questions, you missed them or accept them.
General tip: Leave a blank line before and after your comment, it makes it more
r
Hi Viresh,
Thanks for the detailed review. Will try to handle them in the next version,
On Thu, Feb 7, 2013 at 3:17 AM, Viresh Kumar wrote:
> On Thu, Feb 7, 2013 at 1:09 AM, Amit Daniel Kachhap
> wrote:
>> This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
>> clock contro
Hi Inder,
Thanks for the review,
On Wed, Feb 6, 2013 at 9:09 PM, Inderpal Singh
wrote:
> On 7 February 2013 01:09, Amit Daniel Kachhap wrote:
>> This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
>> clock controller is different from previous exynos controllers so not usin
On 7 February 2013 16:49, Viresh Kumar wrote:
> On Thu, Feb 7, 2013 at 10:39 AM, Inderpal Singh
> wrote:
>>> +#define DRIVER_NAME"exynos5440_dvfs"
>
>>> +static struct cpufreq_driver exynos_driver = {
>>> + .name = DRIVER_NAME,
>>> +};
>>> +
>>
>> Since this driver is
On Thu, Feb 7, 2013 at 10:39 AM, Inderpal Singh
wrote:
>> +#define DRIVER_NAME"exynos5440_dvfs"
>> +static struct cpufreq_driver exynos_driver = {
>> + .name = DRIVER_NAME,
>> +};
>> +
>
> Since this driver is only for exynos5440, having the same names as
> common exyn
On Thu, Feb 7, 2013 at 1:09 AM, Amit Daniel Kachhap
wrote:
> This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
> clock controller is different from previous exynos controllers so not using
> the common exynos cpufreq framework. Also, the device tree parsing is added
> to ge
On 7 February 2013 01:09, Amit Daniel Kachhap wrote:
> This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
> clock controller is different from previous exynos controllers so not using
> the common exynos cpufreq framework. Also, the device tree parsing is added
> to get diff
This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
clock controller is different from previous exynos controllers so not using
the common exynos cpufreq framework. Also, the device tree parsing is added
to get different parameters like frequency, voltage etc.
Signed-off-by:
10 matches
Mail list logo
