Hi,
> >> Reorganize driver a bit to better handle device tree-based systems:
> >>
> >> - move machine type to driver's private structure instead of
> >>quering platform device variants in runtime
> >>
> >> - replace s3c24xx_i2c_type enum with unsigned int that holds
> >>bitmask with revi
On 17.04.2012 19:31, Wolfram Sang wrote:
> Hi,
Hi Wolfram!
>
> On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
>> Reorganize driver a bit to better handle device tree-based systems:
>>
>> - move machine type to driver's private structure instead of
>>quering platform de
Hi,
On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
> Reorganize driver a bit to better handle device tree-based systems:
>
> - move machine type to driver's private structure instead of
>quering platform device variants in runtime
>
> - replace s3c24xx_i2c_type enum wit
On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
> Reorganize driver a bit to better handle device tree-based systems:
>
> - move machine type to driver's private structure instead of
>quering platform device variants in runtime
>
> - replace s3c24xx_i2c_type enum with uns
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device variants in runtime
- replace s3c24xx_i2c_type enum with unsigned int that holds
bitmask with revision-specific quirks
Signed-off-by: K
On 21.03.2012 12:50, Mark Brown wrote:
> On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote:
>
>> What do you think about following changes, then?
>
> That looks reasonable.
Thanks. I'll incorporate this change and post whole patchset again.
Regards,
--
Karol Lewandowski | Sam
On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote:
> What do you think about following changes, then?
That looks reasonable.
signature.asc
Description: Digital signature
On 19.03.2012 20:55, Mark Brown wrote:
> On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
>
>> If you consider code to be inherently less readable because of this
>> approach I'll rework it. If it's not a such big deal for you I would
>> prefer to keep it as is.
>
> The thing
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
> If you consider code to be inherently less readable because of this
> approach I'll rework it. If it's not a such big deal for you I would
> prefer to keep it as is.
The thing that was causing me to think the code was funny was
On 15.03.2012 13:56, Mark Brown wrote:
> On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
>
>> Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
>> attempt to solve this issue. However, this required adding explicit
>> checks to driver code all over the pla
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
> Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
> attempt to solve this issue. However, this required adding explicit
> checks to driver code all over the place (if (type == S3C2400 ||
> type == S3c2440_HD
On 14.03.2012 18:29, Mark Brown wrote:
> On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:
>
>> - replace s3c24xx_i2c_type enum with plain unsigned int that can
>>hold not only device type but also hw revision-specific quirks
>
> Would it not be clearer to just have explici
On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:
> - replace s3c24xx_i2c_type enum with plain unsigned int that can
>hold not only device type but also hw revision-specific quirks
Would it not be clearer to just have explicit flags for the quirks (eg,
as a set of bitfield f
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device variants in runtime
- replace s3c24xx_i2c_type enum with plain unsigned int that can
hold not only device type but also hw revision-spec
14 matches
Mail list logo
