Re: [PATCH 2/3] mfd: tps65090: Stop caching registers

2014-04-16 Thread Lee Jones
Nearly all of the registers in tps65090 combine control bits and status bits. Turn off caching of registers so that we can read status bits reliably. NOTE: the IRQnMASK and CG_CTRLn registers are the exception and could be cached. If we find that we spend a lot of time reading those we

Re: [PATCH 2/3] mfd: tps65090: Stop caching registers

2014-04-16 Thread Mark Brown
On Wed, Apr 16, 2014 at 10:59:22AM +0100, Lee Jones wrote: NOTE: the IRQnMASK and CG_CTRLn registers are the exception and could be cached. If we find that we spend a lot of time reading those we can turn on cache for just those registers. -static bool is_volatile_reg(struct device

Re: [PATCH 2/3] mfd: tps65090: Stop caching registers

2014-04-16 Thread Doug Anderson
Mark, On Wed, Apr 16, 2014 at 3:13 AM, Mark Brown broo...@kernel.org wrote: On Wed, Apr 16, 2014 at 10:59:22AM +0100, Lee Jones wrote: NOTE: the IRQnMASK and CG_CTRLn registers are the exception and could be cached. If we find that we spend a lot of time reading those we can turn on

[PATCH 2/3] mfd: tps65090: Stop caching registers

2014-04-15 Thread Doug Anderson
Nearly all of the registers in tps65090 combine control bits and status bits. Turn off caching of registers so that we can read status bits reliably. NOTE: the IRQnMASK and CG_CTRLn registers are the exception and could be cached. If we find that we spend a lot of time reading those we can turn