Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-18 Thread Chris Ball
Hi, On Fri, Sep 14 2012, Chander Kashyap wrote: > If sdhci-s3c driver is built as module, it gives following error if inserted > again after removing. This was happening as pm_runtime_use_autosuspend() is > called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its > complementry > pm_run

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Girish K S
good catch Reviewed by: Girish K S On 14 September 2012 14:38, Chander Kashyap wrote: > If sdhci-s3c driver is built as module, it gives following error if inserted > again after removing. This was happening as pm_runtime_use_autosuspend() is > called in sdhci_s3c_probe() function but in sdhci_s

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Jaehoon Chung
Looks good to me.. Acked-by: Jaehoon Chung On 09/14/2012 06:08 PM, Chander Kashyap wrote: > If sdhci-s3c driver is built as module, it gives following error if inserted > again after removing. This was happening as pm_runtime_use_autosuspend() is > called in sdhci_s3c_probe() function but in sdh

[PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Chander Kashyap
If sdhci-s3c driver is built as module, it gives following error if inserted again after removing. This was happening as pm_runtime_use_autosuspend() is called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its complementry pm_runtime_dont_use_autosuspend() is not called. BUG: spinlock ba