Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-23 Thread Wolfram Sang
Hi Karol, ... and this one, if we declare a new compatible-entry for exynos4? It is not strictly related to Exynos4 SoCs. Exynos4 SoC has 8 standard s3c2440 style i2c controllers and one additional, internal controller for HDMIPHY, which needs some workarounds in the driver.

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-23 Thread Karol Lewandowski
On 23.04.2012 12:01, Wolfram Sang wrote: Hi Karol, Tomasz had similar doubts when I've posted patch that checked these quirks only for S3C2440: http://permalink.gmane.org/gmane.linux.drivers.i2c/10305 Thus, I've chosen properties and not separate type. I understand this reasoning. I

RE: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Marek Szyprowski
Hi Wolfram, On Tuesday, April 17, 2012 7:40 PM Wolfram Sang wrote: On Wed, Mar 21, 2012 at 08:11:53PM +0100, Karol Lewandowski wrote: This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Wolfram Sang
Optional properties: + - gpios: The order of the gpios should be the following: SDA, SCL. +The gpio specifier depends on the gpio controller. Required in all cases +except when samsung,i2c-no-gpio is also specified. + - samsung,i2c-no-gpio: input/output lines of the

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Karol Lewandowski
On 18.04.2012 15:46, Wolfram Sang wrote: Optional properties: + - gpios: The order of the gpios should be the following: SDA, SCL. +The gpio specifier depends on the gpio controller. Required in all cases +except when samsung,i2c-no-gpio is also specified. + -

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-17 Thread Wolfram Sang
Hi, On Wed, Mar 21, 2012 at 08:11:53PM +0100, Karol Lewandowski wrote: This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between HDMIPHY and other I2C controllers on Exynos4. These differences

[PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-03-21 Thread Karol Lewandowski
This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between HDMIPHY and other I2C controllers on Exynos4. These differences are: - no GPIOs, HDMIPHY is inside the SoC and the controller is connected

[PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-03-13 Thread Karol Lewandowski
This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between HDMIPHY and other I2C controllers on Exynos4. These differences are: - no GPIOs, HDMIPHY is inside the SoC and the controller is connected

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-03-13 Thread Tomasz Stanislawski
Hi Karol, Please refer to comments below, Regards, Tomasz Stanislawski On 03/13/2012 05:54 PM, Karol Lewandowski wrote: This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between HDMIPHY and

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-03-13 Thread Karol Lewandowski
On 13.03.2012 18:27, Tomasz Stanislawski wrote: Hi Karol, Please refer to comments below, Regards, Tomasz Stanislawski On 03/13/2012 05:54 PM, Karol Lewandowski wrote: This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are