RE: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-28 Thread Kukjin Kim
Ben Dooks wrote: On 21/07/10 09:57, Kukjin Kim wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com ---

RE: [rtc-linux] [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-27 Thread Kukjin Kim
Wan ZongShun wrote: 2010/7/23 Kukjin Kim kgene@samsung.com: Wan ZongShun wrote: 2010/7/21 Kukjin Kim kgene@samsung.com: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Do you mean that the hardware register

RE: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-23 Thread Kukjin Kim
Sergei Shtylyov wrote: Hello. Hi :-) Kukjin Kim wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com [...] diff

Re: [rtc-linux] [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-23 Thread Wan ZongShun
2010/7/23 Kukjin Kim kgene@samsung.com: Wan ZongShun wrote: 2010/7/21 Kukjin Kim kgene@samsung.com: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Do you mean that the hardware register does not have default value?

[PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Kukjin Kim
From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/rtc/rtc-s3c.c | 14 -- 1 files changed, 12 insertions(+), 2

Re: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Sergei Shtylyov
Hello. Kukjin Kim wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com [...] diff --git a/drivers/rtc/rtc-s3c.c

Re: [rtc-linux] [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Wan ZongShun
2010/7/21 Kukjin Kim kgene@samsung.com: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Do you mean that the hardware register does not have default value? Any results if no initialized value here? Signed-off-by: Taekgyun Ko