Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. [...] Signed-off-by: Joe Perches j...@perches.com diff --git a/drivers/input/joystick/as5011.c

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may get changed in the future to not dump stack (that was added

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. [...] Signed-off-by: Joe

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already be 2 messages anyway. Then mention that in the commit log if you

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already be

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 12:10 -0700, Dmitry Torokhov wrote: On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't

[PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-23 Thread Joe Perches
Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. Signed-off-by: Joe Perches j...@perches.com --- drivers/input/joystick/as5011.c | 2 -- drivers/input/joystick/db9.c| 1 -