[PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on prepare_count. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- This fixes the warnings in the boot log coming out of enabling the common clock

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on prepare_count. Hmm, do you think warnings like below are any better that WARN_ON() on wrong clock's

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Hi Sylwester, On Tue, Apr 9, 2013 at 3:39 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Hi Sylwester, On Tue, Apr 9, 2013 at 6:21 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Sylwester, On Tue, Apr 9, 2013 at 3:39 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 03:34 PM, Vivek Gautam wrote: Aah !! actually missed a similar patch from Thomas Abraham :( doing the same as suggested by you. Its available at: http://patchwork.ozlabs.org/patch/188687/ There's a change required in the above mentioned patch, so possibly Thomas can go ahead

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
On Tue, Apr 9, 2013 at 7:29 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 03:34 PM, Vivek Gautam wrote: Aah !! actually missed a similar patch from Thomas Abraham :( doing the same as suggested by you. Its available at: http://patchwork.ozlabs.org/patch/188687/