RE: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Byungho An
Florian Fainelli wrote : > 2014-03-18 15:16 GMT-07:00 Byungho An : > > Florian Fainelli wrote: > >> 2014-03-18 11:19 GMT-07:00 Byungho An : > >> > From: Siva Reddy > >> > > >> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > >> > > >> > - sxgbe core initialization > >> > - T

Re: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Florian Fainelli
2014-03-18 15:16 GMT-07:00 Byungho An : > Florian Fainelli wrote: >> 2014-03-18 11:19 GMT-07:00 Byungho An : >> > From: Siva Reddy >> > >> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). >> > >> > - sxgbe core initialization >> > - Tx and Rx support >> > - MDIO support >> > - I

RE: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Byungho An
Florian Fainelli wrote: > 2014-03-18 11:19 GMT-07:00 Byungho An : > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > > > - sxgbe core initialization > > - Tx and Rx support > > - MDIO support > > - ISRs for Tx and Rx > > - ifconfig support to driver

RE: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Byungho An
Joe Perches wrote : > On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > More trivia, nothing that should stop this from being applied and updated > later... > > > diff --git a/drivers/net/ethe

Re: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Joe Perches
On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote: > From: Siva Reddy > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). More trivia, nothing that should stop this from being applied and updated later... > diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c > b/dri

Re: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Florian Fainelli
2014-03-18 11:19 GMT-07:00 Byungho An : > From: Siva Reddy > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > - sxgbe core initialization > - Tx and Rx support > - MDIO support > - ISRs for Tx and Rx > - ifconfig support to driver Too many files to review at once, the diffst