RE: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-19 Thread Kukjin Kim
Mark Rutland wrote: On Fri, Mar 14, 2014 at 01:26:31AM +, Kukjin Kim wrote: + cpu@000 { + device_type = cpu; + compatible = arm,armv8; The arm,armv8 should be a fallback rather than the only entry. The precise

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-18 Thread Mark Rutland
On Fri, Mar 14, 2014 at 01:26:31AM +, Kukjin Kim wrote: + cpu@000 { + device_type = cpu; + compatible = arm,armv8; The arm,armv8 should be a fallback rather than the only entry. The precise core should be first (see

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-14 Thread Mark Brown
On Thu, Mar 13, 2014 at 10:33:29AM +, Mark Rutland wrote: On Wed, Mar 12, 2014 at 04:31:56AM +, Kukjin Kim wrote: +/ { + model = SAMSUNG SSDK-GH7 board based on GH7 SoC; Is the based on GH7 SoC part necessary? Does the SSDK-GH7 not give that away? In this case,

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-13 Thread Mark Rutland
On Wed, Mar 12, 2014 at 04:31:56AM +, Kukjin Kim wrote: Mark Rutland wrote: Hi Mark, On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas

RE: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-13 Thread Kukjin Kim
Mark Rutland wrote: [...] +/memreserve/ 0x8000 0x0C40; Please have a comment as to what this memreserve is intended to protect. This is very large, and we don't want pointless memreserves. Well, you mean I need to comment about each reserved memory area? Please

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-11 Thread Catalin Marinas
On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com This patch should go to the devicetree list as well to get some reviews/acks from the DT

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-11 Thread Mark Rutland
On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 106 +++

RE: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-11 Thread Kukjin Kim
Mark Rutland wrote: Hi Mark, On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 106

[PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-10 Thread Kukjin Kim
Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 106 +++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 2 files