Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Doug Anderson
Javier, On Thu, Oct 16, 2014 at 3:13 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: The regulator framework has a set of helpers functions to be used when the system is entering and leaving from suspend but these are not called on Exynos platforms. This means that the

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Javier Martinez Canillas
[adding Chris Zong as cc who posted a similar patch for Rockchip] Hello Doug, On 10/20/2014 06:26 PM, Doug Anderson wrote: Javier, On Thu, Oct 16, 2014 at 3:13 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: The regulator framework has a set of helpers functions to be

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Doug Anderson
Javier, On Mon, Oct 20, 2014 at 9:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: It turns out that regulator_suspend_finish() actually returns an error code. Could you print a warning if you see it? Yes, I noticed this when looking at Chris patch for Rockchip but

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Javier Martinez Canillas
[adding Rafael Wysocki to cc as Suspend-to-RAM maintainer] On 10/20/2014 07:36 PM, Doug Anderson wrote: Javier, On Mon, Oct 20, 2014 at 9:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: It turns out that regulator_suspend_finish() actually returns an error code.

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Mark Brown
On Mon, Oct 20, 2014 at 09:50:57PM +0200, Javier Martinez Canillas wrote: On 10/20/2014 07:36 PM, Doug Anderson wrote: I guess I was just trying to follow the suggestion that was in the regulator code: http://lxr.free-electrons.com/source/drivers/regulator/core.c#L3699 that says This

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Javier Martinez Canillas
Hello Mark, On 10/20/2014 09:56 PM, Mark Brown wrote: On Mon, Oct 20, 2014 at 09:50:57PM +0200, Javier Martinez Canillas wrote: On 10/20/2014 07:36 PM, Doug Anderson wrote: I guess I was just trying to follow the suggestion that was in the regulator code:

[PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-16 Thread Javier Martinez Canillas
The regulator framework has a set of helpers functions to be used when the system is entering and leaving from suspend but these are not called on Exynos platforms. This means that the .set_suspend_* function handlers defined by regulator drivers are not called when the system is suspended.