[PATCH v3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off

2014-07-16 Thread Krzysztof Kozlowski
On Exynos4 USE_DELAYED_RESET_ASSERTION must be set in ARM_COREx_OPTION register during CPU power down. This is the proper way of powering down CPU on Exynos4. Additionally on Exynos4212 without this the CPU clock down feature won't work after powering down some CPU and the online CPUs will work

Re: [PATCH v3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off

2014-07-16 Thread Tomasz Figa
Hi Krzysztof, On 16.07.2014 14:07, Krzysztof Kozlowski wrote: [snip] +#ifdef CONFIG_SMP +extern void exynos_clear_delayed_reset_assertion(u32 core_id); +#endif Is the ifdef really needed? The only difference it makes if the function is used but not compiled in is that with it the

Re: [PATCH v3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off

2014-07-16 Thread Krzysztof Kozlowski
On śro, 2014-07-16 at 15:05 +0200, Tomasz Figa wrote: Hi Krzysztof, On 16.07.2014 14:07, Krzysztof Kozlowski wrote: [snip] +#ifdef CONFIG_SMP +extern void exynos_clear_delayed_reset_assertion(u32 core_id); +#endif Is the ifdef really needed? The only difference it makes if the