Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add disable-wp device tree property

2013-01-10 Thread Olof Johansson
On Thu, Jan 10, 2013 at 10:24:26AM -0800, Doug Anderson wrote: The disable-wp property is used to specify that a given SD card slot doesn't have a concept of write protect. This eliminates the need for special case code for SD slots that should never be write protected (like a micro SD slot

Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add disable-wp device tree property

2013-01-10 Thread Doug Anderson
Olof, Thanks for your comments. On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson o...@lixom.net wrote: The previous code used the controller-common quirk field to set a per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to do this per-slot? And if so, please explain in the

Re: [PATCH v3 1/4] mmc: dw_mmc: Add disable-wp device tree property

2012-12-19 Thread Doug Anderson
Chris, On Fri, Nov 30, 2012 at 3:57 AM, Seungwon Jeon tgih@samsung.com wrote: Doug, Thanks to work. Looks good to me with other patches. Acked-by: Seungwon Jeon tgih@samsung.com Does this series look reasonable to you? I can check back later when things are less hectic, but I wanted

RE: [PATCH v3 1/4] mmc: dw_mmc: Add disable-wp device tree property

2012-11-30 Thread Seungwon Jeon
Doug, Thanks to work. Looks good to me with other patches. Acked-by: Seungwon Jeon tgih@samsung.com On Friday, November 30, 2012, Doug Anderson wrote: The disable-wp property is used to specify that a given SD card slot doesn't have a concept of write protect. This eliminates the need for

[PATCH v3 1/4] mmc: dw_mmc: Add disable-wp device tree property

2012-11-29 Thread Doug Anderson
The disable-wp property is used to specify that a given SD card slot doesn't have a concept of write protect. This eliminates the need for special case code for SD slots that should never be write protected (like a micro SD slot or a dev board). The dw_mmc driver is special in needing to specify