Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-28 Thread Krzysztof Kozlowski
On czw, 2014-11-27 at 18:30 +, Mark Brown wrote: On Thu, Nov 27, 2014 at 12:20:48PM +0100, Krzysztof Kozlowski wrote: +- ena-gpios: GPIO to use for enable control. Actual implementation depends + on regulator driver. The bindings documentation for given driver describes + which

Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-28 Thread Mark Brown
On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: I understand your concerns here however I didn't want to overengineer this. Is the same GPIO (on more complex PMICs) used in different contexts? Like enable control and something more in the same time? Yes, and it's often

Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-28 Thread Krzysztof Kozlowski
On pią, 2014-11-28 at 11:21 +, Mark Brown wrote: On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: I understand your concerns here however I didn't want to overengineer this. Is the same GPIO (on more complex PMICs) used in different contexts? Like enable control

Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-28 Thread Mark Brown
On Fri, Nov 28, 2014 at 12:54:27PM +0100, Krzysztof Kozlowski wrote: On pią, 2014-11-28 at 11:21 +, Mark Brown wrote: On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: I understand your concerns here however I didn't want to overengineer this. Is the same GPIO (on

[PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-27 Thread Krzysztof Kozlowski
Document new properties for regulators (ena-gpios and ena-gpio-open-drain) for enabling control over GPIO. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/regulator/regulator.txt | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

2014-11-27 Thread Mark Brown
On Thu, Nov 27, 2014 at 12:20:48PM +0100, Krzysztof Kozlowski wrote: +- ena-gpios: GPIO to use for enable control. Actual implementation depends + on regulator driver. The bindings documentation for given driver describes + which regulator actually supports it. +- ena-gpio-open-drain: GPIO