Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-08-02 Thread Andreas Färber
Am 02.08.2014 07:15, schrieb Doug Anderson: On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 31.07.2014 21:20, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: On 31.07.2014 18:08, Andreas Färber wrote: +sd1_clk { + samsung,pin-drv = 0; +}; +

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-08-02 Thread Tomasz Figa
On 01.08.2014 05:17, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: + +i2c_2 { + status = okay; + samsung,i2c-sda-delay = 100; + samsung,i2c-max-bus-freq = 66000; + + hdmiddc@50 { + compatible = samsung,exynos4210-hdmiddc; + reg = 0x50; +

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-08-01 Thread Doug Anderson
Tomasz, On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Andreas, On 31.07.2014 21:20, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: On 31.07.2014 18:08, Andreas Färber wrote: Adds initial support for the HP Chromebook 11. [snip] + gpio-keys

[PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin vpala...@chromium.org Cc: Doug Anderson diand...@chromium.org Cc: Stephan van Schaik step...@synkhronix.com Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: * Fixed samsung,pin-function 1 - 0 for dp-hpd-gpio *

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Vincent Palatin
Always a bit late to the game. One small comment inline. Reviewed-by: Vincent Palatin vpala...@chromium.org On Thu, Jul 31, 2014 at 9:08 AM, Andreas Färber afaer...@suse.de wrote: Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin vpala...@chromium.org Cc: Doug Anderson

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Hi, Am 31.07.2014 19:00, schrieb Vincent Palatin: Always a bit late to the game. One small comment inline. Reviewed-by: Vincent Palatin vpala...@chromium.org Thanks, On Thu, Jul 31, 2014 at 9:08 AM, Andreas Färber afaer...@suse.de wrote: + usb3_vbus_reg: regulator-usb3 { +

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Tomasz Figa
Hi Andreas, Sorry for joining the party a bit late, but there were patches with less people involved so I preferred to review them first. You can find my comments inline. On 31.07.2014 18:08, Andreas Färber wrote: Adds initial support for the HP Chromebook 11. [snip] + gpio-keys { +

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Hi Tomasz, Am 31.07.2014 21:05, schrieb Tomasz Figa: Hi Andreas, Sorry for joining the party a bit late, but there were patches with less people involved so I preferred to review them first. You can find my comments inline. On 31.07.2014 18:08, Andreas Färber wrote: Adds initial

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Am 31.07.2014 21:05, schrieb Tomasz Figa: +}; + +fixed-rate-clocks { +xxti { +compatible = samsung,clock-xxti; +clock-frequency = 2400; +}; +}; This is also referencing a node from higher level, so it should

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Tomasz Figa
On 31.07.2014 22:36, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: + }; + + fixed-rate-clocks { + xxti { + compatible = samsung,clock-xxti; + clock-frequency = 2400; + }; + }; This is also referencing

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Am 31.07.2014 21:40, schrieb Tomasz Figa: On 31.07.2014 21:20, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: On 31.07.2014 18:08, Andreas Färber wrote: + usb-hub { + compatible = smsc,usb3503a; + reset-gpios = hsic_reset; Hmm, why a -gpios property

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Am 01.08.2014 01:26, schrieb Tomasz Figa: On 01.08.2014 01:17, Andreas Färber wrote: Am 31.07.2014 21:40, schrieb Tomasz Figa: On 31.07.2014 21:20, Andreas Färber wrote: Am 31.07.2014 21:05, schrieb Tomasz Figa: On 31.07.2014 18:08, Andreas Färber wrote: [snip] +dp_hpd { +

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Am 31.07.2014 21:05, schrieb Tomasz Figa: + +i2c_2 { +status = okay; +samsung,i2c-sda-delay = 100; +samsung,i2c-max-bus-freq = 66000; + +hdmiddc@50 { +compatible = samsung,exynos4210-hdmiddc; +reg = 0x50; +}; I don't think this matches