Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-28 Thread Rahul Sharma
Thanks Inki, I removed fimd_clear_win from fimd_probe and verified this change in chrome setup. Not seeing any noticeable difference. I have posted another patch at: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31629.html Thanks everybody for your review effort. Regards,

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-27 Thread Rahul Sharma
Gentle Reminder On 26 May 2014 14:21, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, Please review this patch. [snip] + +

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-27 Thread Inki Dae
On 2014년 05월 27일 18:55, Rahul Sharma wrote: Gentle Reminder On 26 May 2014 14:21, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Inki, Please review this patch. Regards, Rahul Sharma On 23 May 2014 17:17, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Daniel Kurtz
On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, Please review this patch. Regards, Rahul Sharma On 23 May 2014 17:17, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, Please review this patch. [snip] + + ret = clk_prepare_enable(ctx-lcd_clk); Hi Rahul, Can you explain why exactly

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled.